Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui by Oneirical · Pull Request #127820 · rust-lang/rust

Oneirical · 2024-07-16T17:28:00Z

Part of #121876 and the associated Google Summer of Code project.

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc

rustbot · 2024-07-16T17:28:08Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-16T17:28:10Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-17T07:48:56Z

@bors try

Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: x86_64-msvc

bors · 2024-07-17T07:50:07Z

⌛ Trying commit 6ef6243 with merge 33935cc...

bors · 2024-07-17T09:26:35Z

☀️ Try build successful - checks-actions
Build commit: 33935cc (33935ccd6a3885667a569d6825450436544214ae)

tests/run-make/invalid-tmpdir-env-var/rmake.rs

jieyouxu · 2024-07-18T03:50:23Z

@rustbot author

Oneirical · 2024-07-18T13:39:51Z

@rustbot ready

jieyouxu · 2024-07-20T10:01:07Z

Thanks!
@bors r+ rollup

bors · 2024-07-20T10:01:10Z

📌 Commit 1a0baaa has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: x86_64-msvc

bors · 2024-07-20T22:16:45Z

☔ The latest upstream changes (presumably #127663) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-22T14:12:33Z

Conflict removed, please re-approve.
@rustbot ready

jieyouxu · 2024-07-22T14:13:45Z

Thanks!

bors · 2024-07-22T14:13:48Z

📌 Commit 8990df7 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - rust-lang#117932 (Correct rustdoc section where we talk about rustdoc emitting errors on invalid code) - rust-lang#125990 (Rename `deprecated_safe` lint to `deprecated_safe_2024`) - rust-lang#127506 (rustc_target: add known safe s390x target features) - rust-lang#127820 (Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui) - rust-lang#127923 (Use reuse tool 4.0) - rust-lang#128008 (Start using `#[diagnostic::do_not_recommend]` in the standard library) - rust-lang#128036 (add more tests) - rust-lang#128051 (rustdoc: revert spacing change in item-table) - rust-lang#128059 (Add regression test for items list size (rust-lang#128023)) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127820 - Oneirical:intestellar-travel, r=jieyouxu Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: x86_64-msvc

rustbot assigned jieyouxu Jul 16, 2024

This comment has been minimized.

Sign in to view

Oneirical force-pushed the intestellar-travel branch from 9216284 to 6ef6243 Compare July 16, 2024 18:37

Kobzol mentioned this pull request Jul 17, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

Kobzol changed the title ~~Rewrite and rename issue-14698. issue-33329 and issue-10794 run-make tests to rmake or ui~~ Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui Jul 17, 2024

jieyouxu reviewed Jul 18, 2024

View reviewed changes

tests/run-make/invalid-tmpdir-env-var/rmake.rs Outdated Show resolved Hide resolved

jieyouxu reviewed Jul 18, 2024

View reviewed changes

tests/run-make/invalid-tmpdir-env-var/rmake.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024

Oneirical force-pushed the intestellar-travel branch from 6ef6243 to 1a0baaa Compare July 18, 2024 13:39

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024

tgross35 mentioned this pull request Jul 20, 2024

Rollup of 8 pull requests #128000

Closed

matthiaskrgr mentioned this pull request Jul 20, 2024

Rollup of 7 pull requests #128017

Closed

matthiaskrgr mentioned this pull request Jul 20, 2024

Rollup of 6 pull requests #128019

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2024

Oneirical added 3 commits July 22, 2024 10:11

rewrite and rename issue-14698 to rmake

e870ab8

rewrite and rename issue-33329 to ui test

613a7a7

rewrite and rename issue-107094 to rmake

8990df7

Oneirical force-pushed the intestellar-travel branch from 1a0baaa to 8990df7 Compare July 22, 2024 14:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2024

tgross35 mentioned this pull request Jul 22, 2024

Rollup of 9 pull requests #128063

Merged

bors merged commit 3ba92be into rust-lang:master Jul 22, 2024

rustbot added this to the 1.82.0 milestone Jul 22, 2024

Uh oh!

Conversation

Oneirical commented Jul 16, 2024 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 16, 2024

Uh oh!

rustbot commented Jul 16, 2024

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 17, 2024

Uh oh!

bors commented Jul 17, 2024

Uh oh!

bors commented Jul 17, 2024

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

Oneirical commented Jul 18, 2024

Uh oh!

jieyouxu commented Jul 20, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

Oneirical commented Jul 22, 2024

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Oneirical commented Jul 16, 2024 •

edited by jieyouxu

Loading