Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
npmccallum
force-pushed
the
cow_borrow
branch
from
ce9573b to
e84a425
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`Cow` already has a `Deref<Target=B>` implementation that is `const` when the `Borrow` impl from the owned type is also `const`. However, none of the major types actually implement this, so the `Deref` impl doesn't really work. This change constifies the two major `Cow::Owned` types so that the `Deref` impl on `Cow` will work for those two types.
npmccallum
force-pushed
the
cow_borrow
branch
from
e8737a1 to
89f4adb
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
r? libs-api |
rustbot
added
the
T-libs-api
tisonkun
approved these changes
Jan 6, 2026
Contributor
|
☔ The latest upstream changes (presumably #152574) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cowalready has aDeref<Target=B>implementation that isconstwhen theBorrowimpl from the owned type is alsoconst. However, none of the major types actually implement this, so theDerefimpl doesn't really work.This change constifies the two major
Cow::Ownedtypes so that theDerefimpl onCowwill work for those two types.