Skip to content

more float constants #146934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joshuarayton wants to merge 1 commit into from
Closed

more float constants #146934

joshuarayton wants to merge 1 commit into from

Conversation

@joshuarayton
Copy link
Contributor

@joshuarayton joshuarayton commented Sep 23, 2025 •
edited by rustbot
Loading

more float constants: sqrt(5), 1/sqrt(5), ln(3)
rename EGAMMA to GAMMA

Adds constants discussed in #103883
I discuss why I prefer the variable name GAMMA in the issue but if a majority disagrees then I can change it back.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joshuarayton joshuarayton mentioned this pull request Sep 23, 2025
Closed
3 tasks
tgross35
tgross35 requested changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to file an ACP for this so the API team discusses it? It's an issue template at https://github.com/rust-lang/libs-team/issues, should be pretty easy.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025
@tgross35 tgross35 added the needs-acp This change is blocked on the author creating an ACP. label Sep 23, 2025
@joshuarayton joshuarayton mentioned this pull request Sep 24, 2025
Open
@joshuarayton
Copy link
Contributor Author

joshuarayton commented Sep 24, 2025

Would you be able to file an ACP for this so the API team discusses it? It's an issue template at https://github.com/rust-lang/libs-team/issues, should be pretty easy.

View changes since this review

Done at: rust-lang/libs-team#661

@tgross35 tgross35 added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2025
@rustbot

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Sep 28, 2025

☔ The latest upstream changes (presumably #147104) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 28, 2025
@rustbot

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor

tgross35 commented Nov 19, 2025

The ACP was accepted with changes, this PR will need to be updated rust-lang/libs-team#661.

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@tgross35 tgross35 removed the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joshuarayton
more float constants: sqrt(5), 1/sqrt(5)
dedf260 
rename EGAMMA to EULER_GAMMA
rename PHI to GOLDEN_RATIO
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 16, 2026

☔ The latest upstream changes (presumably #151183) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 27, 2026
@tgross35
Copy link
Contributor

tgross35 commented Jan 28, 2026

@joshuarayton any reason you closed this? The ACP was mostly accepted, this just needs some easy changes to meet rust-lang/libs-team#661 (comment).

@joshuarayton
Copy link
Contributor Author

joshuarayton commented Jan 29, 2026

Sorry. When I tried updating the code, I wasn't sure how to stabilise EULER_GAMMA and GOLDEN_RATIO under their new name. I updated their name and thought the stabilisation process would be done someplace else before a release. Then when this PR became unmergeable because of #151164, I thought that was all done. I then closed this PR and deleted my fork. Now I realise that it wasn't finished because $\sqrt{5}$ and $\frac{1}{\sqrt{5}}$ aren't implemented. I have now forked again and made relevant changes in the more-float-constants branch. It won't let me reopen this pull request, saying 'The repository that submitted this pull request has been deleted.'.

@tgross35
Copy link
Contributor

tgross35 commented Jan 29, 2026

Thanks for the update, you were doing the right thing. It will just make you submit a new PR, feel free to request a review from me.

@joshuarayton joshuarayton mentioned this pull request Jan 29, 2026
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151825 - joshuarayton:more-float-constants,…
60e1cc1 
… r=tgross35

more float constants

Add constants discussed in rust-lang#146939 rust-lang/libs-team#661
Retry of rust-lang#146934

r? @tgross35
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151825 - joshuarayton:more-float-constants,…
995a5a6 
… r=tgross35

more float constants

Add constants discussed in rust-lang#146939 rust-lang/libs-team#661
Retry of rust-lang#146934

r? @tgross35
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151825 - joshuarayton:more-float-constants,…
9914413 
… r=tgross35

more float constants

Add constants discussed in rust-lang#146939 rust-lang/libs-team#661
Retry of rust-lang#146934

r? @tgross35
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151825 - joshuarayton:more-float-constants,…
81af082 
… r=tgross35

more float constants

Add constants discussed in rust-lang#146939 rust-lang/libs-team#661
Retry of rust-lang#146934

r? @tgross35
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151825 - joshuarayton:more-float-constants,…
f0355cc 
… r=tgross35

more float constants

Add constants discussed in rust-lang#146939 rust-lang/libs-team#661
Retry of rust-lang#146934

r? @tgross35
rust-timer added a commit that referenced this pull request Feb 3, 2026
@rust-timer
Unrolled build for #151825
2a7b7e6 
Rollup merge of #151825 - joshuarayton:more-float-constants, r=tgross35

more float constants

Add constants discussed in #146939 rust-lang/libs-team#661
Retry of #146934

r? @tgross35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 requested changes

Assignees

@tgross35 tgross35

Labels

needs-acp This change is blocked on the author creating an ACP. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshuarayton @rustbot @bors @tgross35 @rust-log-analyzer