Rollup of 5 pull requests by Zalathar · Pull Request #149166 · rust-lang/rust

Zalathar · 2025-11-21T03:44:45Z

Successful merges:

Exhaustively specify names and stability of --print values #148990 (Exhaustively specify names and stability of --print values)
unwrap ret ty of iter::ArrayChunks::into_remainder #149127 (unwrap ret ty of iter::ArrayChunks::into_remainder )
std: sys: net: uefi: Implement read_vectored #149134 (std: sys: net: uefi: Implement read_vectored)
Constify residual_into_try_type #149135 (Constify residual_into_try_type)
Check for intrinsic to fn ptr casts in unified coercions #149160 (Check for intrinsic to fn ptr casts in unified coercions)

r? @ghost
@rustbot modify labels: rollup

- Basically a copy of write_vectored [0] - Tested on QEMU ovmf. [0]: rust-lang#146301 Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Ensures that when coercing multiple expressions to a unified type, the same "intrinsic to fn ptr" check is applied as for other coercions.

Exhaustively specify names and stability of `--print` values While trying to add a new unstable `--print` kind for use by compiletest, I found that the relevant code is quite awkward to work with, for a few reasons: - It's spread across various parts of a multi-thousand-line source file. - All newly-added `PrintKind` values are automatically treated as *stable*, unless they are explicitly marked as unstable in a helper function far away. - Parsing `--print` values relies on a separate table of name/value mappings, but there's no exhaustiveness check for that table. This PR therefore: - Extracts the relevant code into its own `print_request` submodule. - Uses a macro-rules derive to obtain an exhaustive list of values. - Uses exhaustive matches to associate a name and stability status with each `PrintKind` value. --- The first commit moves code to a separate module; the second commit contains actual changes. There should be no change to compiler output.

…inder_is_non_optional, r=dtolnay unwrap ret ty of `iter::ArrayChunks::into_remainder` changes [`iter::ArrayChunks::into_remainder`](rust-lang#100450) to return `array::IntoIter` instead of `Option<array::IntoIter>` as suggested by [`@WaffleLapkin](https://github.com/rust-lang/rust/issues/100450#issuecomment-3555519025)`

std: sys: net: uefi: Implement read_vectored - Basically a copy of write_vectored [0] - Tested on QEMU ovmf. [0]: rust-lang#146301

…pe, r=scottmcm Constify `residual_into_try_type` Feature: `const_try_residual` (related to `try_trait_v2_residual`) Tracking issue: rust-lang#91285 Constify `residual_into_try_type` introduced in rust-lang#148725. r? ``@scottmcm``

…ercion-ice, r=Kivooeo,BoxyUwU Check for intrinsic to fn ptr casts in unified coercions Fixes rust-lang#149143 by ensuring that when coercing multiple expressions to a unified type, the same "intrinsic to fn ptr" check is applied as for other coercions.

Zalathar · 2025-11-21T03:44:58Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-11-21T03:45:00Z

📌 Commit db50517 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-11-21T03:46:28Z

⌛ Testing commit db50517 with merge e22dab3...

bors · 2025-11-21T06:59:06Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing e22dab3 to main...

rust-timer · 2025-11-21T07:00:33Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#148990	Exhaustively specify names and stability of `--print` values	`2603ead3c9f2e78c23ea6e481bb96845f2988435` (link)
#149127	unwrap ret ty of `iter::ArrayChunks::into_remainder`	`52ad9456d492e82eb8cc5e15898ceeff473234e5` (link)
#149134	std: sys: net: uefi: Implement read_vectored	`34352078252781fac573ec1494fa69cfeb00201b` (link)
#149135	Constify `residual_into_try_type`	`30ecba4b30ca5298bafc40fc806ae84976198541` (link)
#149160	Check for intrinsic to fn ptr casts in unified coercions	`2b62a35d54552afdf06b745f5686d9d371e2b326` (link)

previous master: 5f7653df82

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-21T07:02:14Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f7653d (parent) -> e22dab3 (this PR)

Test differences

Show 10 test diffs

Stage 1

[ui] tests/ui/coercion/intrinsic-in-unifying-coercion-149143.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/coercion/intrinsic-in-unifying-coercion-149143.rs: [missing] -> pass (J1)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e22dab387f6b4f6a87dfc54ac2f6013dddb41e68 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

tidy: 163.6s -> 192.1s (+17.4%)
pr-check-1: 1721.7s -> 2017.9s (+17.2%)
x86_64-gnu-llvm-20: 2316.4s -> 2697.2s (+16.4%)
x86_64-gnu-stable: 6476.0s -> 7435.8s (+14.8%)
i686-gnu-2: 5323.3s -> 6088.9s (+14.4%)
x86_64-gnu-gcc: 3098.1s -> 3543.4s (+14.4%)
i686-gnu-nopt-1: 7379.9s -> 8324.7s (+12.8%)
x86_64-gnu-llvm-21-1: 3127.2s -> 3526.5s (+12.8%)
x86_64-rust-for-linux: 2652.7s -> 2986.1s (+12.6%)
x86_64-gnu-miri: 4360.2s -> 4867.6s (+11.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-21T08:19:44Z

Finished benchmarking commit (e22dab3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.3%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

Results (primary 2.1%, secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.5%, -2.3%]	2
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.873s -> 473.456s (0.12%)
Artifact size: 388.93 MiB -> 388.90 MiB (-0.01%)

bend-n and others added 11 commits November 20, 2025 15:27

iter::ArrayChunks::into_remainder ought not return option

68abe69

std: sys: net: uefi: Implement read_vectored

3f08502

- Basically a copy of write_vectored [0] - Tested on QEMU ovmf. [0]: rust-lang#146301 Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Constify residual_into_try_type

5590d7d

Check for intrinsic to fn ptr casts in unified coercions

ebf1c38

Ensures that when coercing multiple expressions to a unified type, the same "intrinsic to fn ptr" check is applied as for other coercions.

Extract module rustc_session::config::print_request

c81d22d

Exhaustively specify names and stability of --print values

9c7e7cc

Rollup merge of rust-lang#149134 - Ayush1325:uefi-tcp4-vector, r=joboet

e397c5d

std: sys: net: uefi: Implement read_vectored - Basically a copy of write_vectored [0] - Tested on QEMU ovmf. [0]: rust-lang#146301

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2025

bors merged commit e22dab3 into rust-lang:main Nov 21, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 21, 2025

Zalathar deleted the rollup-fyrwtcb branch November 21, 2025 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#149166

Rollup of 5 pull requests#149166
bors merged 11 commits intorust-lang:mainfrom
Zalathar:rollup-fyrwtcb

Zalathar commented Nov 21, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

Zalathar commented Nov 21, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

bors commented Nov 21, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 21, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Zalathar commented Nov 21, 2025 •

edited by rustbot

Loading