transmutability: only short-circuit is_transmutable for non-region infers#149228
Open
lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Open
transmutability: only short-circuit is_transmutable for non-region infers#149228lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
is_transmutable for non-region infers#149228lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
Contributor
|
It seems wrong to return an error here. It should not be impossible to transmute. We should instead stall somehow here. There should probably just be an |
Contributor
|
☔ The latest upstream changes (presumably #151003) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #141400, fixes #148809
An ICE occurs when using
std::mem::TransmuteFormfor trait resolution when it contains inferred variables. This can be resolved by adding an early return condition tois_transmutable. However, since most existing type resolution appears to be handled byrustc_transmute::TransmuteTypeEnv, I've added a guard that only applies when non-regional inference variables remain.