std: Don't use linkat on the wasm32-wasi* targets
#149864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-up to 147572 and the issue reported at the end of that PR where the `std::fs::hard_link` function is broken after that PR landed. The true culprit and bug here is fixed in WebAssembly/wasi-libc/690 but until that's released in a wasi-sdk version it should be reasonable, on WASI, to skip the `linkat` function.
rustbot
added
S-waiting-on-review
Collaborator
alexcrichton
commented
Dec 10, 2025
Comment on lines
-2080
to
+2098
| any(target_os = "vxworks", target_os = "redox", target_os = "android", target_os = "espidf", target_os = "horizon", target_os = "vita", target_env = "nto70") => { | ||
| // VxWorks, Redox and ESP-IDF lack `linkat`, so use `link` instead. POSIX leaves | ||
| // it implementation-defined whether `link` follows symlinks, so rely on the | ||
| // `symlink_hard_link` test in library/std/src/fs/tests.rs to check the behavior. | ||
| // Android has `linkat` on newer versions, but we happen to know `link` | ||
| // always has the correct behavior, so it's here as well. | ||
| any( | ||
| // VxWorks, Redox and ESP-IDF lack `linkat`, so use `link` instead. | ||
| // POSIX leaves it implementation-defined whether `link` follows | ||
| // symlinks, so rely on the `symlink_hard_link` test in | ||
| // library/std/src/fs/tests.rs to check the behavior. | ||
| target_os = "vxworks", | ||
| target_os = "redox", | ||
| target_os = "espidf", | ||
| // Android has `linkat` on newer versions, but we happen to know | ||
| // `link` always has the correct behavior, so it's here as well. | ||
| target_os = "android", | ||
| // wasi-sdk-29-and-prior have a buggy `linkat` so use `link` instead | ||
| // until wasi-sdk is updated (see WebAssembly/wasi-libc#690) | ||
| target_os = "wasi", | ||
| // Other misc platforms | ||
| target_os = "horizon", | ||
| target_os = "vita", | ||
| target_env = "nto70", | ||
| ) => { |
Member
Author
There was a problem hiding this comment.
As a note for this I took the liberty to reformat the line to be less long and arrange the comments to apply to the platform-in-question too.
Member
|
Yup, makes sense. |
Collaborator
bors
added
S-waiting-on-bors
Member
|
For future reference, the relevant code in wasi-libc is which indeed calls |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
…joboet std: Don't use `linkat` on the `wasm32-wasi*` targets This commit is a follow-up to rust-lang#147572 and the issue reported at the end of that PR where the `std::fs::hard_link` function is broken after that PR landed. The true culprit and bug here is fixed in WebAssembly/wasi-libc#690 but until that's released in a wasi-sdk version it should be reasonable, on WASI, to skip the `linkat` function.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
…joboet std: Don't use `linkat` on the `wasm32-wasi*` targets This commit is a follow-up to rust-lang#147572 and the issue reported at the end of that PR where the `std::fs::hard_link` function is broken after that PR landed. The true culprit and bug here is fixed in WebAssembly/wasi-libc#690 but until that's released in a wasi-sdk version it should be reasonable, on WASI, to skip the `linkat` function.
bors
added a commit
that referenced
this pull request
Dec 14, 2025
Rollup of 7 pull requests Successful merges: - #146794 (std: reorganize pipe implementations) - #148196 (Implement create_dir_all() to operate iteratively instead of recursively) - #148490 (dangling pointer from temp cleanup) - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets) - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs) - #149949 (Cleanup of attribute parsing errors) - #149969 (don't use no_main and no_core to test IBT) Failed merges: - #148847 (Share Timespec between Unix and Hermit) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 14, 2025
Rollup of 8 pull requests Successful merges: - #146794 (std: reorganize pipe implementations) - #148490 (dangling pointer from temp cleanup) - #149837 (Update `wrapping_sh[lr]` docs and examples) - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets) - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs) - #149949 (Cleanup of attribute parsing errors) - #149969 (don't use no_main and no_core to test IBT) - #149998 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup of 8 pull requests Successful merges: - #146794 (std: reorganize pipe implementations) - #148490 (dangling pointer from temp cleanup) - #149837 (Update `wrapping_sh[lr]` docs and examples) - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets) - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs) - #149949 (Cleanup of attribute parsing errors) - #149969 (don't use no_main and no_core to test IBT) - #149998 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup merge of #149864 - alexcrichton:wasi-avoid-linkat, r=joboet std: Don't use `linkat` on the `wasm32-wasi*` targets This commit is a follow-up to #147572 and the issue reported at the end of that PR where the `std::fs::hard_link` function is broken after that PR landed. The true culprit and bug here is fixed in WebAssembly/wasi-libc#690 but until that's released in a wasi-sdk version it should be reasonable, on WASI, to skip the `linkat` function.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#146794 (std: reorganize pipe implementations) - rust-lang/rust#148490 (dangling pointer from temp cleanup) - rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples) - rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets) - rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs) - rust-lang/rust#149949 (Cleanup of attribute parsing errors) - rust-lang/rust#149969 (don't use no_main and no_core to test IBT) - rust-lang/rust#149998 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 23, 2025
std: Use `usleep` temporarily on WASI targets This fixes some fallout from #147572 where the `thread::sleep` function is is broken on `wasm32-wasip2` after that PR. The cause for this is a broken implementation of `nanosleep` in wasi-libc itself which is being fixed in WebAssembly/wasi-libc#696. Similar to #149864 this avoids the problematic function for now while the wasi-libc changes take some time to propagate into a wasi-sdk release. Closes #150290
Kobzol
pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 23, 2025
std: Use `usleep` temporarily on WASI targets This fixes some fallout from rust-lang/rust#147572 where the `thread::sleep` function is is broken on `wasm32-wasip2` after that PR. The cause for this is a broken implementation of `nanosleep` in wasi-libc itself which is being fixed in WebAssembly/wasi-libc#696. Similar to rust-lang/rust#149864 this avoids the problematic function for now while the wasi-libc changes take some time to propagate into a wasi-sdk release. Closes rust-lang/rust#150290
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 24, 2025
std: Use `usleep` temporarily on WASI targets This fixes some fallout from rust-lang/rust#147572 where the `thread::sleep` function is is broken on `wasm32-wasip2` after that PR. The cause for this is a broken implementation of `nanosleep` in wasi-libc itself which is being fixed in WebAssembly/wasi-libc#696. Similar to rust-lang/rust#149864 this avoids the problematic function for now while the wasi-libc changes take some time to propagate into a wasi-sdk release. Closes rust-lang/rust#150290
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 25, 2025
std: Use `usleep` temporarily on WASI targets This fixes some fallout from rust-lang/rust#147572 where the `thread::sleep` function is is broken on `wasm32-wasip2` after that PR. The cause for this is a broken implementation of `nanosleep` in wasi-libc itself which is being fixed in WebAssembly/wasi-libc#696. Similar to rust-lang/rust#149864 this avoids the problematic function for now while the wasi-libc changes take some time to propagate into a wasi-sdk release. Closes rust-lang/rust#150290
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Update wasi-sdk used in CI/releases This is similar to prior updates such as #149037 in that this is just updating a URL. This update though has some technical updates accompanying it as well, however: * The `wasm32-wasip2` target no longer uses APIs from WASIp1 on this target, even for startup. This means that the final binary no longer has an "adapter" which can help making instantiation of a component a bit more lean. * In #147572 libstd was updated to use wasi-libc more often on the `wasm32-wasip2` target. This uncovered a number of bugs in wasi-libc such as #149864, #150291, and #151016. These are all fixed in wasi-sdk-30 so the workarounds in the standard library are all removed. Overall this is not expected to have any sort of major impact on users of WASI targets. Instead it's expected to be a normal routine update to keep the wheels greased and oiled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to #147572 and the issue reported at the end of that PR where the
std::fs::hard_linkfunction is broken after that PR landed. The true culprit and bug here is fixed in WebAssembly/wasi-libc#690 but until that's released in a wasi-sdk version it should be reasonable, on WASI, to skip thelinkatfunction.