Add x86_64-asan-windows-msvc tier 3 target#149892
Add x86_64-asan-windows-msvc tier 3 target#149892eholk wants to merge 5 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
|
r? wesleywiser I'll wait for a bit to see if there are any objections from the other target maintainers against adding this but I'm very much in favor! |
|
|
||
| ("x86_64-pc-cygwin", x86_64_pc_cygwin), | ||
|
|
||
| ("x86_64-asan-windows-msvc", x86_64_asan_windows_msvc), |
There was a problem hiding this comment.
nit: let's make sure this ends up grouped with x86_64-asan-unknown-gnu once #149644 lands.
|
|
||
| ## Testing | ||
|
|
||
| Programs compiled for this target require `clang_rt.asan_dynamic-x86_64.dll` to |
There was a problem hiding this comment.
I was initially going to suggest we just fold this file into the existing windows-msvc.md file but there are some important things to note like this, so I guess it makes sense to keep it as a separate file. If other maintainers feel differently, feel free to comment.
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
|
☔ The latest upstream changes (presumably #149831) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Looks like linux is going with Should we change to |
This is a companion to #149644 and adds a target that can be used to enable AddressSanitizer by default on Windows.
I and the other maintainers of the Windows MSVC targets will be responsible for this target.
(cc @ChrisDenton @dpaoliello @Fulgen301 @lambdageek @sivadeilra @wesleywiser)
This target follows the naming conventions agreed on for the similar
x86_64-asan-linux-gnutarget.This PR introduces no new legal terms or conditions.
Understood.
This is able to implement the same portions of the standard library that are supported by the other MSVC targets.
This PR includes such documentation.
Understood.
Understood.
This target uses LLVM for code generation.