Skip to content

Rollup of 4 pull requests#150240

Merged
bors merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-anx8c35
Dec 22, 2025
Merged

Rollup of 4 pull requests#150240
bors merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-anx8c35

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 22, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tshepang and others added 10 commits December 17, 2025 20:29
@tshepang
crash test readme: point to rustc-dev-guide
977bf0a 
There is information that is duplicated here and in rustc-dev-guide, and the latter is more comprehensive, so point there.
@tshepang
show how to view docs locally
e17c2f3
@Bryntet
add expected_non_empty_string_literal to attribute parser
38c6672 
Signed-off-by: Edvin Bryntesson <epost@edvinbryntesson.se>
@Bryntet
Port #[cfi_encoding] to attribute parser
d719a49
@jieyouxu
tidy: skip target-specific check for run-make-cargo too
5fc0030 
I forgot to change this when implementing the run-make fission.
@jieyouxu
bootstrap: update comment for STAGE0_MISSING_TARGETS
de0945b
@JonathanBrouwer
Rollup merge of rust-lang#149840 - jieyouxu:bootstrap-missing-stage0,…
e1f41dc 
… r=Zalathar

Update comment for `STAGE0_MISSING_TARGETS`
@JonathanBrouwer
Rollup merge of rust-lang#150109 - tshepang:patch-1, r=jieyouxu
43f270a 
crash test readme: point to rustc-dev-guide

There is information that is duplicated here and in rustc-dev-guide, and the latter is more comprehensive, so point there.
@JonathanBrouwer
Rollup merge of rust-lang#150204 - Bryntet:parse_cfi_encoding, r=Jona…
d31a2be 
…thanBrouwer

Port `#[cfi_encoding]` to attribute parser

The error message is kind of saying the same thing twice, would like input on which .expect function I should use instead to not have it be double, otherwise this passes all tests locally where this attribute is used

r? `@JonathanBrouwer`
@JonathanBrouwer
Rollup merge of rust-lang#150237 - jieyouxu:tidy-run-make-cargo, r=Za…
fdc84e8 
…lathar

Skip tidy target-specific check for `run-make-cargo` too

I forgot to change this when implementing the run-make fission.

Noticed in rust-lang#149624 (comment).
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 22, 2025

@bors r+ rollup=never p=5

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-tidy Area: The tidy tool PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 22, 2025
@bors
Copy link
Collaborator

bors commented Dec 22, 2025

📌 Commit fdc84e8 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2025
@bors
Copy link
Collaborator

bors commented Dec 22, 2025

⌛ Testing commit fdc84e8 with merge e951f47...

@bors
Copy link
Collaborator

bors commented Dec 22, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing e951f47 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 22, 2025
@bors bors merged commit e951f47 into rust-lang:main Dec 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 22, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 22, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149840 Update comment for STAGE0_MISSING_TARGETS a0c6ffdc12da6a2da822bd0069cc3f83cc3c8eb6 (link)
#150109 crash test readme: point to rustc-dev-guide cbdc6d5bb438c78ba9ad10331419cb2e2e7a86d8 (link)
#150204 Port #[cfi_encoding] to attribute parser 8f56f49e86aa2d2674a52137fadc31fd9f41a38f (link)
#150237 Skip tidy target-specific check for run-make-cargo too 9ed91945f985bd82bde9ba055c0bd106fb8d612a (link)

previous master: 000ccd651d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 000ccd6 (parent) -> e951f47 (this PR)

Test differences

Show 8 test diffs

8 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e951f470d76febcc6f0a5b409c509eb77450a336 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3767.5s -> 4829.8s (+28.2%)
  2. aarch64-apple: 13081.0s -> 10224.0s (-21.8%)
  3. dist-x86_64-apple: 9656.7s -> 7805.7s (-19.2%)
  4. dist-aarch64-apple: 7968.1s -> 6936.2s (-13.0%)
  5. i686-gnu-2: 5653.4s -> 6261.5s (+10.8%)
  6. x86_64-msvc-ext1: 7148.0s -> 7879.9s (+10.2%)
  7. dist-x86_64-msvc-alt: 9739.1s -> 8843.7s (-9.2%)
  8. aarch64-gnu-debug: 4113.1s -> 4470.4s (+8.7%)
  9. dist-aarch64-linux: 7055.4s -> 6506.8s (-7.8%)
  10. dist-aarch64-llvm-mingw: 5791.3s -> 6227.4s (+7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 22, 2025

Finished benchmarking commit (e951f47): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 0.3% [0.0%, 0.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.8% [3.1%, 6.5%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.8% [3.1%, 6.5%] 2

Cycles

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.34s -> 481.595s (0.05%)
Artifact size: 390.37 MiB -> 390.31 MiB (-0.02%)

@bors bors mentioned this pull request Dec 22, 2025
Open
This was referenced Dec 22, 2025
Closed
Merged
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 22, 2025

@rust-timer build 8f56f49

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 22, 2025

Finished benchmarking commit (8f56f49): comparison URL.

Overall result: ❌ regressions - no action needed

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 0.2% [0.0%, 0.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary 6.5%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 6.5% [6.5%, 6.5%] 1
Regressions ❌
(secondary)		 1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.5% [-1.5%, -1.5%] 1
All ❌✅ (primary) 6.5% [6.5%, 6.5%] 1

Cycles

Results (primary -2.4%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.3% [2.7%, 4.0%] 2
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.34s -> 482.814s (0.31%)
Artifact size: 390.37 MiB -> 390.31 MiB (-0.02%)

@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 22, 2025
Merged
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer @bors @rust-timer @rustbot @tshepang @Bryntet @jieyouxu