Disallow eii in statement position by jdonszelmann · Pull Request #150971 · rust-lang/rust

jdonszelmann · 2026-01-11T15:35:43Z

With how v2 macros resolve, and the name resolution of super works, I realized with @WaffleLapkin that there's actually no way to consistently expand EIIs in statement position.

r? @WaffleLapkin

rust-bors · 2026-01-12T20:25:05Z

☔ The latest upstream changes (presumably #151003) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin

r=me with nits

View changes since this review

tests/ui/eii/error_statement_position.rs

WaffleLapkin · 2026-01-13T08:13:09Z

compiler/rustc_builtin_macros/src/eii.rs

+            extern_item_path: ecx.path(
+                foreign_item_name.span,
+                // prefix super to explicitly escape the const block generated below
+                // NOTE: this is why EIIs can't be used on statements


nit: "can't be used in statement position" to be consistent with the other places

compiler/rustc_builtin_macros/src/eii.rs

compiler/rustc_builtin_macros/src/errors.rs

rustbot · 2026-01-13T11:04:32Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-01-13T11:08:51Z

@bors r=wafflelapkin rollup

rust-bors · 2026-01-13T11:08:55Z

📌 Commit 8dd701c has been approved by wafflelapkin

It is now in the queue for this repository.

rust-log-analyzer · 2026-01-13T12:12:55Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 255: expected 0 elements, found 1: for command `assert-count: ("//*[@class='tooltip popover']", 0)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

jdonszelmann · 2026-01-13T13:40:22Z

@bors r-

rust-bors · 2026-01-13T13:40:27Z

Commit 8dd701c has been unapproved.

jdonszelmann · 2026-01-14T11:20:28Z

@GuillaumeGomez another spurious failure I think?

jdonszelmann · 2026-01-14T11:20:44Z

@bors r=wafflelapkin

rust-bors · 2026-01-14T11:20:47Z

📌 Commit 8dd701c has been approved by wafflelapkin

It is now in the queue for this repository.

GuillaumeGomez · 2026-01-14T11:23:12Z

Yep. Should be fixed by #151053.

@WaffleLapkin

…, r=wafflelapkin Disallow eii in statement position With how v2 macros resolve, and the name resolution of `super` works, I realized with @WaffleLapkin that there's actually no way to consistently expand EIIs in statement position. r? @WaffleLapkin

@WaffleLapkin

…, r=wafflelapkin Disallow eii in statement position With how v2 macros resolve, and the name resolution of `super` works, I realized with @WaffleLapkin that there's actually no way to consistently expand EIIs in statement position. r? @WaffleLapkin

@ghost

…uwer Rollup of 12 pull requests Successful merges: - #150585 (Add a context-consistency check before emitting redundant generic-argument suggestions) - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150590 (Don't try to recover keyword as non-keyword identifier ) - #150817 (cleanup: remove borrowck handling for inline const patterns) - #150939 (resolve: Relax some asserts in glob overwriting and add tests) - #150966 (rustc_target: Remove unused Arch::PowerPC64LE) - #150971 (Disallow eii in statement position) - #151016 (fix: WASI threading regression by disabling pthread usage) - #151046 (compiler: Make Externally Implementable Item (eii) macros "semiopaque") - #151103 (mir_build: Simplify length-determination and indexing for array/slice patterns) - #151117 (Avoid serde dependency in build_helper when not necessary) - #151127 (Delete `MetaItemOrLitParser::Err`) r? @ghost

@WaffleLapkin

…, r=wafflelapkin Disallow eii in statement position With how v2 macros resolve, and the name resolution of `super` works, I realized with @WaffleLapkin that there's actually no way to consistently expand EIIs in statement position. r? @WaffleLapkin

@ghost

…uwer Rollup of 16 pull requests Successful merges: - #150585 (Add a context-consistency check before emitting redundant generic-argument suggestions) - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150590 (Don't try to recover keyword as non-keyword identifier ) - #150817 (cleanup: remove borrowck handling for inline const patterns) - #150939 (resolve: Relax some asserts in glob overwriting and add tests) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #150966 (rustc_target: Remove unused Arch::PowerPC64LE) - #150971 (Disallow eii in statement position) - #151016 (fix: WASI threading regression by disabling pthread usage) - #151046 (compiler: Make Externally Implementable Item (eii) macros "semiopaque") - #151099 (Recover parse gracefully from `<const N>`) - #151117 (Avoid serde dependency in build_helper when not necessary) - #151127 (Delete `MetaItemOrLitParser::Err`) - #151128 (Add temporary new bors e-mail address to the mailmap) - #151130 (resolve: Downgrade `ambiguous_glob_imports` to warn-by-default) - #151138 (Rename `rust.use-lld` to `rust.bootstrap-override-lld` in INSTALL.md) r? @ghost

@ghost

…uwer Rollup of 15 pull requests Successful merges: - #150585 (Add a context-consistency check before emitting redundant generic-argument suggestions) - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150590 (Don't try to recover keyword as non-keyword identifier ) - #150817 (cleanup: remove borrowck handling for inline const patterns) - #150939 (resolve: Relax some asserts in glob overwriting and add tests) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #150966 (rustc_target: Remove unused Arch::PowerPC64LE) - #150971 (Disallow eii in statement position) - #151016 (fix: WASI threading regression by disabling pthread usage) - #151046 (compiler: Make Externally Implementable Item (eii) macros "semiopaque") - #151099 (Recover parse gracefully from `<const N>`) - #151117 (Avoid serde dependency in build_helper when not necessary) - #151127 (Delete `MetaItemOrLitParser::Err`) - #151128 (Add temporary new bors e-mail address to the mailmap) - #151138 (Rename `rust.use-lld` to `rust.bootstrap-override-lld` in INSTALL.md) r? @ghost

@WaffleLapkin

Rollup merge of #150971 - disallow-eii-in-statement-position, r=wafflelapkin Disallow eii in statement position With how v2 macros resolve, and the name resolution of `super` works, I realized with @WaffleLapkin that there's actually no way to consistently expand EIIs in statement position. r? @WaffleLapkin

@ghost

…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#150585 (Add a context-consistency check before emitting redundant generic-argument suggestions) - rust-lang/rust#150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - rust-lang/rust#150590 (Don't try to recover keyword as non-keyword identifier ) - rust-lang/rust#150817 (cleanup: remove borrowck handling for inline const patterns) - rust-lang/rust#150939 (resolve: Relax some asserts in glob overwriting and add tests) - rust-lang/rust#150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - rust-lang/rust#150966 (rustc_target: Remove unused Arch::PowerPC64LE) - rust-lang/rust#150971 (Disallow eii in statement position) - rust-lang/rust#151016 (fix: WASI threading regression by disabling pthread usage) - rust-lang/rust#151046 (compiler: Make Externally Implementable Item (eii) macros "semiopaque") - rust-lang/rust#151099 (Recover parse gracefully from `<const N>`) - rust-lang/rust#151117 (Avoid serde dependency in build_helper when not necessary) - rust-lang/rust#151127 (Delete `MetaItemOrLitParser::Err`) - rust-lang/rust#151128 (Add temporary new bors e-mail address to the mailmap) - rust-lang/rust#151138 (Rename `rust.use-lld` to `rust.bootstrap-override-lld` in INSTALL.md) r? @ghost

rustbot assigned WaffleLapkin Jan 11, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026

jdonszelmann force-pushed the disallow-eii-in-statement-position branch from 0397f4f to b40d3c4 Compare January 11, 2026 17:07

WaffleLapkin approved these changes Jan 13, 2026

View reviewed changes

use self instead of super

467a2d2

jdonszelmann force-pushed the disallow-eii-in-statement-position branch from b40d3c4 to d58770f Compare January 13, 2026 11:04

jdonszelmann added 2 commits January 13, 2026 12:08

disallow in statement position

df55233

add test for rejecting EIIs in statement position

8dd701c

jdonszelmann force-pushed the disallow-eii-in-statement-position branch from d58770f to 8dd701c Compare January 13, 2026 11:08

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 14, 2026

jdonszelmann mentioned this pull request Jan 14, 2026

Tracking Issue for externally implementable items #125418

Open

48 tasks

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 10 pull requests #151125

Closed

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 12 pull requests #151129

Closed

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 16 pull requests #151139

Closed

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 15 pull requests #151144

Merged

rust-bors bot merged commit 46d4bbf into rust-lang:main Jan 15, 2026
8 of 11 checks passed

rustbot added this to the 1.94.0 milestone Jan 15, 2026

github-actions bot mentioned this pull request Jan 28, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Open

Uh oh!

Conversation

jdonszelmann commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 12, 2026

Uh oh!

WaffleLapkin left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WaffleLapkin Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jan 13, 2026

Uh oh!

jdonszelmann commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

rust-log-analyzer commented Jan 13, 2026

Uh oh!

jdonszelmann commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

jdonszelmann commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Jan 14, 2026

Uh oh!

rust-bors bot commented Jan 14, 2026

Uh oh!

GuillaumeGomez commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WaffleLapkin left a comment •

edited by rustbot

Loading

jdonszelmann commented Jan 14, 2026 •

edited

Loading