Support GPR pair in RISC-V inline assembly#150973
Open
taiki-e wants to merge 1 commit intorust-lang:mainfrom
Open
Support GPR pair in RISC-V inline assembly#150973taiki-e wants to merge 1 commit intorust-lang:mainfrom
taiki-e wants to merge 1 commit intorust-lang:mainfrom
Conversation
This was referenced Jan 11, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
I would expect this to come with a format modifier which allows you to get the name of the second register of the pair. |
Member
Author
|
Indeed, it would significantly limit its uses without that. @rustbot author |
Contributor
|
☔ The latest upstream changes (presumably #152825) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports RISC-V even-odd GPR pair as
reg_pairclass underasm_experimental_regfeature (#133416).Both LLVM (20+) and GCC support this as
Rconstraint, and this is useful for using AMOCAS.D on RV32 and AMOCAS.Q on RV64 instructions (currently, we need to split the value and pass it by specifying the specific register name).Note: For now, this only implements register class and support for explicitly specifying register names is not implemented. (What name should we choose?)
reg_pairi64reg_pairi128Refs:
r? @Amanieu
@rustbot label +A-inline-assembly +O-riscv