-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
UnsafePinned: implement opsem effects of UnsafeUnpin #151365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The Miri subtree was changed cc @rust-lang/miri |
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
This comment has been minimized.
This comment has been minimized.
faea4bb to
ee603cd
Compare
This comment has been minimized.
This comment has been minimized.
ee603cd to
296a434
Compare
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
|
Uh, what is happening with the link checker here? I have no idea why this PR would add new links to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Uh, no idea what's going on, but it some sort of rustdoc weirdness... Cc @rust-lang/rustdoc |
e978d76 to
ba96ef7
Compare
ba96ef7 to
860c3a8
Compare
|
@davidtwco will you be fine to review this or should I go look for someone else? Not sure who else knows their way around our LLVM attribute handling here... @nikic @workingjubilee maybe? |
This comment has been minimized.
This comment has been minimized.
|
@rustbot reroll |
860c3a8 to
8a4619e
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sorry for the delay in getting back to you, some of this is a bit out of cache for me, so probably best to reroll. |
|
@rustbot reroll |
This implements the next step for #125735: actually making
UnsafePinnedhave special opsem effects by suppressing thenoaliaseven if the type is wrapped in anUnpinwrapper.For backwards compatibility we also still keep the
Unpinhack, i.e. a type must be bothUnpinandUnsafeUnpinto getnoalias.