cmse: don't use BackendRepr when checking return type
#151590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
added
F-cmse_nonsecure_entry
rustbot
added
S-waiting-on-review
Collaborator
|
HIR ty lowering was modified cc @fmease |
| // Accept (transparently wrapped) scalar 64-bit primitives. | ||
| matches!( | ||
| layout.ty.kind(), | ||
| ty::Int(ty::IntTy::I64) | ty::Uint(ty::UintTy::U64) | ty::Float(ty::FloatTy::F64) |
Member
There was a problem hiding this comment.
...I was about to ask about pointers but then remembered this is 32-bit.
folkertdev
force-pushed
the
cmse-unwrap-transparent
branch
from
6ad57fe to
8d3215e
Compare
This comment has been minimized.
This comment has been minimized.
davidtwco
requested changes
Feb 5, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
folkertdev
force-pushed
the
cmse-unwrap-transparent
branch
from
8d3215e to
685e692
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
cmse-unwrap-transparent
branch
from
685e692 to
e73c02e
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
cmse-unwrap-transparent
branch
from
e73c02e to
eb9d515
Compare
Contributor
Author
|
@bors r=davidtwco |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
…, r=davidtwco cmse: don't use `BackendRepr` when checking return type tracking issue: rust-lang#81391 tracking issue: rust-lang#75835 r? davidtwco cc @RalfJung context: rust-lang/rfcs#3884 (comment) I believe this is more reliable, and no longer relies on `BackendRepr`. I also added a test specifically for using `repr(Rust)`.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
…, r=davidtwco cmse: don't use `BackendRepr` when checking return type tracking issue: rust-lang#81391 tracking issue: rust-lang#75835 r? davidtwco cc @RalfJung context: rust-lang/rfcs#3884 (comment) I believe this is more reliable, and no longer relies on `BackendRepr`. I also added a test specifically for using `repr(Rust)`.
This was referenced Feb 6, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…uwer Rollup of 6 pull requests Successful merges: - #151590 (cmse: don't use `BackendRepr` when checking return type) - #151945 (feat: Add `NonZero::<T>::from_str_radix`) - #152000 (Fix ICE in normalizing inherent associated consts with `#[type_const]`) - #152192 (Always use Xcode-provided Clang in macOS CI) - #152196 (bootstrap: Remove `ShouldRun::paths`) - #152222 (Re-add TaKO8Ki to triagebot review queue)
rust-timer
added a commit
that referenced
this pull request
Feb 6, 2026
Rollup merge of #151590 - folkertdev:cmse-unwrap-transparent, r=davidtwco cmse: don't use `BackendRepr` when checking return type tracking issue: #81391 tracking issue: #75835 r? davidtwco cc @RalfJung context: rust-lang/rfcs#3884 (comment) I believe this is more reliable, and no longer relies on `BackendRepr`. I also added a test specifically for using `repr(Rust)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #81391
tracking issue: #75835
r? davidtwco
cc @RalfJung
context: rust-lang/rfcs#3884 (comment)
I believe this is more reliable, and no longer relies on
BackendRepr. I also added a test specifically for usingrepr(Rust).