Skip to content

Tweak inlining for try_mark_previous_green#151877

Closed
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:try-mark-inline-tweaks
Closed

Tweak inlining for try_mark_previous_green#151877
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:try-mark-inline-tweaks

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 30, 2026

This tweaks inlining for try_mark_previous_green to see if we can make inlining more stable without hurting performance.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2026
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 31, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 31, 2026
Tweak inlining for `try_mark_previous_green`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 31, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

☀️ Try build successful (CI)
Build commit: 7557519 (7557519846a448d9cb932d3bd47c95472322d9a6, parent: 44e34e1ac6d7e69b40856cf1403d3da145319c30)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7557519): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.3%, -0.2%] 4
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 3
All ❌✅ (primary) -0.3% [-0.3%, -0.2%] 4

Max RSS (memory usage)

Results (primary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.9% [2.1%, 3.8%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.9% [2.1%, 3.8%] 3

Cycles

Results (primary 3.3%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.436s -> 475.499s (0.22%)
Artifact size: 397.79 MiB -> 397.80 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 31, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 14, 2026

☔ The latest upstream changes (presumably #152516) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc closed this Feb 14, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants