-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Update to Xcode 26.2 #152013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Xcode 26.2 #152013
Conversation
|
I suspect this will run into issues with some badly written tests, will do a CI run once it starts working again. |
|
@bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 16cbdc0 failed: CI. Failed job:
|
|
I think we might need to use the Xcode-provided Clang on @bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
|
Hmm. I'd expect the first build with this to take longer because it busts basically the entire build cache, but I wouldn't have expected it to take that long. Maybe it's due to the recent CI outage that GitHub Actions had, which might make jobs slower while they're catching up? I'll wait a few more hours to a day, and then retry the build. |
This comment has been minimized.
This comment has been minimized.
|
@bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
|
Seems like the second time might have access to more cached data: |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
Seemed to complete within reasonable timeframes, so was probably just some caching weirdness. @rustbot ready |
|
This is probably compile-time performance-sensitive, since LLVM will be built with a newer Clang version (as I understand it, LLVM is only built once, unlike Should still be safe to rollup though, as macOS performance isn't tested by |
|
@bors r+ ...what's the worst that can happen /s |
Update to Xcode 26.2
Update our CI to run with Xcode 26.
This means that:
- LLVM will be built with a newer Clang version (before Apple Clang 15, now Apple Clang 17).
- Our binaries (e.g. `rustc` and `libstd*.dylib`) will have their SDK version raised (before macOS 14.5, now 26.2).
- Our binaries will be built with a newer linker (before 1053.12, now 1230.1).
The last two points can be observed with:
```sh
$ vtool -show-build ./build/host/stage1/bin/rustc
Load command 10
cmd LC_BUILD_VERSION
cmdsize 32
platform MACOS
minos 11.0
sdk 26.2
ntools 1
tool LD
version 1230.1
$ vtool -show-build ./build/host/stage1/lib/rustlib/aarch64-apple-darwin/lib/libstd*.dylib
Load command 9
cmd LC_BUILD_VERSION
cmdsize 32
platform MACOS
minos 11.0
sdk 26.2
ntools 1
tool LD
version 1230.1
```
This shouldn't have much of an effect, but things like `dyld` is known to inspect the SDK version, so it _might_ expose some latent bugs (I really don't expect it to though).
This also updates the macOS runners to run on macOS 15 (the macOS 14 runners only have up to Xcode 16.2 available). That is desirable anyhow, as [the macOS 14 runners will be deprecated in July](actions/runner-images#13518). This is probably also required for rust-lang#147192.
r? shepmaster
…uwer Rollup of 7 pull requests Successful merges: - #151960 (rustc_parse: improve the error diagnostic for "missing let") - #152157 (Fix error spans for `asm!()` args that are macros) - #152317 (fix: sup_trace to sub_trace) - #150897 (rustc_parse_format: improve diagnostics for unsupported debug = syntax) - #151154 (Add `s390x-unknown-none-softfloat` with `RustcAbi::Softfloat`) - #152013 (Update to Xcode 26.2) - #152326 (Remove the compiler adhoc group)
Rollup merge of #152013 - madsmtm:update-xcode, r=shepmaster Update to Xcode 26.2 Update our CI to run with Xcode 26. This means that: - LLVM will be built with a newer Clang version (before Apple Clang 15, now Apple Clang 17). - Our binaries (e.g. `rustc` and `libstd*.dylib`) will have their SDK version raised (before macOS 14.5, now 26.2). - Our binaries will be built with a newer linker (before 1053.12, now 1230.1). The last two points can be observed with: ```sh $ vtool -show-build ./build/host/stage1/bin/rustc Load command 10 cmd LC_BUILD_VERSION cmdsize 32 platform MACOS minos 11.0 sdk 26.2 ntools 1 tool LD version 1230.1 $ vtool -show-build ./build/host/stage1/lib/rustlib/aarch64-apple-darwin/lib/libstd*.dylib Load command 9 cmd LC_BUILD_VERSION cmdsize 32 platform MACOS minos 11.0 sdk 26.2 ntools 1 tool LD version 1230.1 ``` This shouldn't have much of an effect, but things like `dyld` is known to inspect the SDK version, so it _might_ expose some latent bugs (I really don't expect it to though). This also updates the macOS runners to run on macOS 15 (the macOS 14 runners only have up to Xcode 16.2 available). That is desirable anyhow, as [the macOS 14 runners will be deprecated in July](actions/runner-images#13518). This is probably also required for #147192. r? shepmaster
Update our CI to run with Xcode 26.
This means that:
rustcandlibstd*.dylib) will have their SDK version raised (before macOS 14.5, now 26.2).The last two points can be observed with:
This shouldn't have much of an effect, but things like
dyldis known to inspect the SDK version, so it might expose some latent bugs (I really don't expect it to though).This also updates the macOS runners to run on macOS 15 (the macOS 14 runners only have up to Xcode 16.2 available). That is desirable anyhow, as the macOS 14 runners will be deprecated in July. This is probably also required for #147192.
r? shepmaster