Skip to content

Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2 #152021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
madsmtm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2 #152021

madsmtm wants to merge 2 commits into from
+61 −44

Conversation

@madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Feb 2, 2026 •
edited
Loading

Promote the following targets to Tier 2 without host tools:

  • aarch64-apple-tvos.
  • aarch64-apple-tvos-sim.
  • aarch64-apple-watchos.
  • aarch64-apple-watchos-sim.
  • aarch64-apple-visionos.
  • aarch64-apple-visionos-sim.

This implements MCP rust-lang/compiler-team#918. Fixes #151705.

r? shepmaster

@madsmtm madsmtm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-target-specs Area: Compile-target specifications O-watchos Operating System: watchOS O-tvos Operating system: tvOS (including simulator) O-visionos Apple visionOS O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) labels Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
madsmtm
madsmtm commented Feb 2, 2026
View reviewed changes
src/ci/github-actions/jobs.yml
Comment on lines 469 to 482
env:
SCRIPT: ./x.py dist bootstrap --include-default-paths --host='' --target=aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim,aarch64-apple-ios-macabi,x86_64-apple-ios-macabi
# Build and distribute the standard library for these targets.
TARGETS: "aarch64-apple-ios,aarch64-apple-ios-sim,x86_64-apple-ios,\
aarch64-apple-ios-macabi,x86_64-apple-ios-macabi,\
aarch64-apple-tvos,aarch64-apple-tvos-sim,\
aarch64-apple-visionos,aarch64-apple-visionos-sim,\
aarch64-apple-watchos,aarch64-apple-watchos-sim"
SCRIPT: ./x.py dist bootstrap --include-default-paths --host='' --target=$TARGETS
# Mac Catalyst cannot currently compile the sanitizer:
Copy link
Contributor Author

@madsmtm madsmtm Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure how exactly I'd verify that this doesn't take too long? Do I need to run bors twice, once to populate the cache, and the second time to actually time it?

@madsmtm madsmtm mentioned this pull request Feb 2, 2026
Open
5 tasks
@madsmtm

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

@bors try jobs=dist-apple-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 3, 2026
@bors
Auto merge of #152021 - madsmtm:tvos-visionos-watchos-tier-2, r=<try>
196a7ea 
Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2


try-job: dist-apple-various
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madsmtm madsmtm closed this Feb 3, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2026
@madsmtm madsmtm reopened this Feb 3, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2026
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

Closed and reopened because of spurious CI failure (tracked in #93784).

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

💔 Test for 196a7ea failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madsmtm madsmtm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 5, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152021 - madsmtm:tvos-visionos-watchos-tier-2, r=<try>
3ff7f71 
Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2


try-job: dist-apple-various
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

💔 Test for 3ff7f71 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 10, 2026

Whoops, bad GH actions syntax:
@bors try jobs=dist-apple-various

@madsmtm madsmtm force-pushed the tvos-visionos-watchos-tier-2 branch from 58d9605 to 87d0f76 Compare February 10, 2026 08:41
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152021 - madsmtm:tvos-visionos-watchos-tier-2, r=<try>
1a03846 
Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2


try-job: dist-apple-various
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 10, 2026

@bors try cancel

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

Try build cancelled. Cancelled workflows:

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 10, 2026

Sent the message before I had pushed 🤦
@bors try jobs=dist-apple-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152021 - madsmtm:tvos-visionos-watchos-tier-2, r=<try>
46512a7 
Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2


try-job: dist-apple-various
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

☀️ Try build successful (CI)
Build commit: 46512a7 (46512a7e311292f1c99512a2ed6e9f9719d14524, parent: f21b4c0888ca6a388fcf9365fc0044fa0642ab98)

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 10, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026
shepmaster
shepmaster reviewed Feb 10, 2026
View reviewed changes
Copy link
Member

@shepmaster shepmaster left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

View changes since this review

@madsmtm madsmtm force-pushed the tvos-visionos-watchos-tier-2 branch from 87d0f76 to 4fa388c Compare February 10, 2026 16:42
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 10, 2026

Fixed them, thanks for the review!

@shepmaster
Copy link
Member

shepmaster commented Feb 10, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

📌 Commit 4fa388c has been approved by shepmaster

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152021 - madsmtm:tvos-visionos-watchos-tier…
26ad0f7 
…-2, r=shepmaster

Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2

Promote the following targets to Tier 2 without host tools:
- `aarch64-apple-tvos`.
- `aarch64-apple-tvos-sim`.
- `aarch64-apple-watchos`.
- `aarch64-apple-watchos-sim`.
- `aarch64-apple-visionos`.
- `aarch64-apple-visionos-sim`.

This implements MCP rust-lang/compiler-team#918. Fixes rust-lang#151705.

r? shepmaster
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152451 - JonathanBrouwer:rollup-1mjEpG1, r=JonathanBro…
e1f5019 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #149937 (try enabling `linker-messages` by default again)
 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152120 (Don't ICE on layout error in vtable computation)
 - #152419 (Move more query system code)
 - #152431 (Restrict the set of things that const stability can be applied to)
 - #152436 (Reenable a GCI+mGCA+GCPT test case)
 - #151142 (Support ADT types in type info reflection)
 - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2)
 - #152146 (mGCA: Add associated const type check)
 - #152372 (style: remove unneeded trailing commas)
 - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable)
 - #152397 (Update books)
 - #152441 (Fix typos and grammar in top-level and src/doc documentation)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2026
@matthiaskrgr
Rollup merge of rust-lang#152021 - madsmtm:tvos-visionos-watchos-tier…
7dd4cca 
…-2, r=shepmaster

Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2

Promote the following targets to Tier 2 without host tools:
- `aarch64-apple-tvos`.
- `aarch64-apple-tvos-sim`.
- `aarch64-apple-watchos`.
- `aarch64-apple-watchos-sim`.
- `aarch64-apple-visionos`.
- `aarch64-apple-visionos-sim`.

This implements MCP rust-lang/compiler-team#918. Fixes rust-lang#151705.

r? shepmaster
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shepmaster shepmaster shepmaster left review comments

Assignees

@shepmaster shepmaster

Labels

A-CI Area: Our Github Actions CI A-target-specs Area: Compile-target specifications A-testsuite Area: The testsuite used to check the correctness of rustc O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-tvos Operating system: tvOS (including simulator) O-visionos Apple visionOS O-watchos Operating System: watchOS relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 918: Promote tvOS/watchOS/visionOS to Tier 2

5 participants

@madsmtm @rustbot @rust-log-analyzer @shepmaster @Mark-Simulacrum