Pull implied bound computation out of borrowck #152051
Draft
+562
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
tiif
commented
Feb 3, 2026
Member
Author
There was a problem hiding this comment.
This change in this file is mainly duplicating the existing function to not use nll var. The new implied bound query needs these functions, but it doesn't makes sense to use nll var there. boxy gave some ideas on how to deduplicate this, but I haven't got to it yet.
This comment has been minimized.
This comment has been minimized.
tiif
commented
Feb 10, 2026
Comment on lines
+53
to
+56
| if let Ok(bounds) = compute_implied_outlives_bounds_inner(&ocx, param_env, ty, span, false) | ||
| { | ||
| outlives_bounds.extend(bounds); | ||
| } |
Member
Author
There was a problem hiding this comment.
we have a first implied bound computation call here
tiif
commented
Feb 10, 2026
Comment on lines
+87
to
+91
| if ty != norm_ty { | ||
| if let Ok(bounds) = | ||
| compute_implied_outlives_bounds_inner(&ocx, param_env, norm_ty, span, false) | ||
| { | ||
| outlives_bounds.extend(bounds); |
Member
Author
There was a problem hiding this comment.
and this is the second one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open this draft PR so it's easier to discuss, feel free to point out any logic / soundness / error handling issues :>
Current status: