Rollup of 3 pull requests #152087
Closed
Rollup of 3 pull requests #152087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm one of the rare cases that does have uv, but doesn't have python installed globally
add a link to the issue fix test stderr
Move the query list into a new `rustc_middle::queries` module This moves the query list from `rustc_middle::query` into a new `rustc_middle::queries` module. This splits up the use of the query system from the remaining implementation of it in `rustc_middle::query`, which conceptually belong to `rustc_query_system`. The goal is to let rustc crates define queries with their own `queries` module, and this makes `rustc_middle` also fit this pattern. The inner `queries` module used by the macros are renamed to `query_info`, so it doesn't conflict with the new outer name.
Add uv to the list of possible python runners Fixes the unlikely case that one has uv, but not python, globally installed (It's me, I'm the unlikely case)
…, r=nnethercote Avoid semicolon suggestion when tail expr is error Fixes rust-lang#151610 When the tail expression is Err due to recovery, HIR constructs `StmtKind::Semi(Err(..))`. The suggestion path then uses `stmt.span.with_lo(tail_expr.span.hi())` to target the semicolon, but `stmt.span == tail_expr.span` so the derived span is empty/invalid.
rustbot
added
A-query-system
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_middle::queriesmodule #151893 (Move the query list into a newrustc_middle::queriesmodule)Failed merges:
rustc_query_systemcleanups #152023 (Somerustc_query_systemcleanups)r? @ghost
Create a similar rollup