-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Rollup of 9 pull requests #152093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 9 pull requests #152093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom target specs This also takes the chance to move forward the job to Linux v6.19-rc7, thus the previous workaround is not needed anymore. Link: rust-lang#151534 Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
It's a tiny module with one trait and a default impl. It's not used in `rustc_query_system`; all uses and non-default impls are in `rustc_middle` and `rustc_query_impl`. This commit moves it into `rustc_middle`, which makes things simpler overall.
It's a better place for it, because it relates to queries.
They are defined in `rustc_query_system` but used in `rustc_query_impl`. This is very much *not* how things are supposed to be done; I suspect someone got lazy and took a shortcut at some point. This commit moves the errors into `rustc_query_impl`. This requires more lines of code to give `rustc_query_impl` an errors module, but it's worthwhile to do things in the normal way instead of a weird exceptional way.
It's unused. And it's nice to remove this function that didn't behave like normal `clear` does, as the comment explained.
Extend CI postprocessing to aggregate pass/fail/ignored counts for debuginfo tests. Tests are identified via their reported suite names (e.g. debuginfo-gdb, debuginfo-lldb or debuginfo-cdb). Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
To match the opening `(` before the reference to PR 127786
…json-again, r=chenyukang target: fix destabilising target-spec-json cc rust-lang#151528 rust-lang#150151 missed a case and didn't entirely destabilise target-spec-json - this patch corrects that. Closes rust-lang#71009
Some `rustc_query_system` cleanups Small improvements I found while looking closely at `rustc_query_system`. Best reviewed one commit at a time. r? @cjgillot
rustbook/README.md: add missing `)` To match the opening `(` before the reference to PR 127786
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
…obzol citool: report debuginfo test statistics Extend CI postprocessing to aggregate pass/fail/ignored counts for debuginfo tests. Tests are identified via their reported suite names (e.g. debuginfo-gdb, debuginfo-lldb or debuginfo-cdb).
…r=lqd Convert to inline diagnostics in `rustc_ty_utils` For rust-lang#151366 r? @jdonszelmann
…=jdonszelmann Convert to inline diagnostics in `rustc_session` For rust-lang#151366 r? @jdonszelmann
…=lqd Convert to inline diagnostics in `rustc_privacy` For rust-lang#151366 r? @jdonszelmann
…ze, r=jdonszelmann Convert to inline diagnostics in `rustc_monomorphize` For rust-lang#151366 r? @jdonszelmann
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
Member
|
Contributor
Author
|
True! I'll re-make the rollup without that, thanks for the warning |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CI
Area: Our Github Actions CI
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_query_systemcleanups #152023 (Somerustc_query_systemcleanups))#152088 (rustbook/README.md: add missing))rustc_ty_utils#152065 (Convert to inline diagnostics inrustc_ty_utils)rustc_session#152066 (Convert to inline diagnostics inrustc_session)rustc_privacy#152069 (Convert to inline diagnostics inrustc_privacy)rustc_monomorphize#152072 (Convert to inline diagnostics inrustc_monomorphize)Failed merges:
rustc_resolve#152068 (Convert to inline diagnostics inrustc_resolve)rustc_pattern_analysis#152070 (Convert to inline diagnostics inrustc_pattern_analysis)r? @ghost
Create a similar rollup