Remove the 4 failing tests from rustdoc-gui #152194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in GUI tests. |
rustbot
added
S-waiting-on-review
2 tasks
Member
|
Tracked in #152197. Given that a contributor said they can reproduce test failures of these 4 tests locally (#t-infra > CI failure because `tests/rustdoc-gui/search-filter.goml` @ 💬), I am going to r+ this to try to unblock the tree. Hopefully it at least reduces the likelihood down from "every PR is hitting these" to "occassionally". @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Rollup of 4 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #152194 (Remove the 4 failing tests from rustdoc-gui) Failed merges: - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
rust-timer
added a commit
that referenced
this pull request
Feb 6, 2026
Rollup merge of #152194 - JonathanBrouwer:fix-rustdoc-gui, r=jieyouxu Remove the 4 failing tests from rustdoc-gui These are the 4 tests that @Bryntet got to fail locally See [#t-infra > CI failure because `tests/rustdoc-gui/search-filter.goml`](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20failure.20because.20.60tests.2Frustdoc-gui.2Fsearch-filter.2Egoml.60/with/572271674) r? @ghost
Member
|
Isn't there a way to disable rather than remove them? Makes it easier to revert this later. |
JonathanBrouwer
added
the
beta-nominated
JonathanBrouwer
added
the
stable-nominated
Member
I don't think this is implemented; |
Member
|
We need to unblock beta too, so: @rustbot label beta-accepted |
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
cuviper
added
the
stable-accepted
GuillaumeGomez
removed
the
stable-nominated
Member
|
Marked it as accepted for stable backport as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the 4 tests that @Bryntet got to fail locally
See #t-infra > CI failure because `tests/rustdoc-gui/search-filter.goml`
r? @ghost