Rollup of 9 pull requests #152358
Merged
Rollup of 9 pull requests #152358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was broken by 258ace6, which changed `self.normalized_pos` to use relative offsets however this method continued to compare against an absolute offset. Also adds a regression test for the issue that this method was originally introduced to fix.
…t_all_rtls into global ctor
Handle DefKind::TraitAlias in resolve_bound_vars so that associated item constraints and return type notation work through trait aliases.
This fixes the ICE by renaming conflicting arguments in the diagnostic.
…llot Fix `SourceFile::normalized_byte_pos` This method was broken by 258ace6, which changed `self.normalized_pos` to use relative offsets however this method continued to compare against an absolute offset. Also adds a regression test for the issue that this method was originally introduced to fix. Closes rust-lang#149568 Fixes regression of rust-lang#110885 r? cjgillot (as author of the breaking commit)
…jdonszelmann Remove support for slugs in diagnostic messages This PR contains 5 commits, and is best reviewed commit-by-commit: - rust-lang@ea87331 Removes support from slugs from `rustc_errors` - rust-lang@62dd371 Removes support from slugs from `rustc_macros` (which declares `derive(Diagnostic)`) - rust-lang@2289e6c Adjuist the `ui-fulldeps` testsuite to match the changes in `rustc_macros` - rust-lang@0db0acd Removes support for the fallback bundle (which previously contained all messages, but is now empty) from `rustc_driver_impl` and `rustc_session` - rust-lang@81d4214 Removes an integration test that tested the translation system using fluent
Replace some `feature(core_intrinsics)` with stable hints I noticed that some compiler crates use `feature(core_intrinsics)` for optimization hints, when they could potentially be using stable `std::hint` functions instead. This PR replaces the occurrences in `rustc_arena` and `rustc_data_structures`.
…hanBrouwer Fix a few diagnostics When working on the inline diagnostics conversion (rust-lang#151366), I noticed that my script sometimes took the wrong message. Because it didn't happen very often, I just fixed it manually when a uitest fails. However I got paranoid that the script changed messages that were not covered by uitests, so I checked for all messages in the previous `messages.ftl` files, whether they occured at least once in the codebase. I found 3 messages that indeed were wrongly replaced by my script, fixed them, and added uitests to make sure this doesn't happen again :) r? @jdonszelmann (Anyone else, also feel free to review, just assigning to Jana because she's been reviewing the other PRs)
…thercote Cleanup offload datatransfer There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back. At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage. cc @jdoerfert @kevinsala r? compiler
…ouwer Port some attributes to the attr parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer
…alias, r=fmease Fix bound var resolution for trait aliases Fixes rust-lang#152158 Fixes rust-lang#152244
…rgau diagnostics: fix ICE in closure signature mismatch Fixes rust-lang#152331 Fixes an ICE where `AdjustSignatureBorrow` caused a panic because it attempted to set the `len` argument which was already defined by the parent diagnostic. Both variants used `len` as argument name, but can both be present in a diagnostic. They now use different names for the argument.
…ma, r=JonathanBrouwer
`cfg_select!`: allow optional comma after `{ /* ... */ }`
rustbot
added
A-attributes
rustbot
added
A-LLVM
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 286fbe5 (parent) -> 6efa357 (this PR) Test differencesShow 29 test diffsStage 0
Stage 1
Stage 2
Additionally, 11 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6efa357bff60d192688e02de0c78cae24a7f3a55 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 286fbe5d84 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 8, 2026
Collaborator
|
Finished benchmarking commit (6efa357): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.8%, secondary 5.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.129s -> 477.097s (0.84%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
SourceFile::normalized_byte_pos#151455 (FixSourceFile::normalized_byte_pos)feature(core_intrinsics)with stable hints #152322 (Replace somefeature(core_intrinsics)with stable hints)cfg_select!: allow optional comma after{ /* ... */ }#152341 (cfg_select!: allow optional comma after{ /* ... */ })r? @ghost
Create a similar rollup