Skip to content

allow deprecated(since = "CURRENT_RUSTC_VERSION") #152488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 12, 2026
Merged

allow deprecated(since = "CURRENT_RUSTC_VERSION") #152488

rust-bors merged 1 commit into from
Feb 12, 2026
+3 −0

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Feb 11, 2026

Motivated by #149978.

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 67 candidates
  • Random selection from 15 candidates

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 11, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 11, 2026

📌 Commit 31f4f0a has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2026
@cyrgani cyrgani mentioned this pull request Feb 11, 2026
Open
madsmtm
madsmtm reviewed Feb 11, 2026
View reviewed changes
@madsmtm
Copy link
Contributor

madsmtm commented Feb 11, 2026 •
edited
Loading

Haha, I was annoyed enough to begin implementing this exact thing too!

I'll unapprove just to give you time to make my suggested change before it's rolled up, feel free to r+ again if you disagree / don't wanna make that change
@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2026
@rust-cloud-vms rust-cloud-vms bot force-pushed the deprecation-staged-api branch from 31f4f0a to 52919c7 Compare February 11, 2026 21:39
@cyrgani cyrgani added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 11, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 11, 2026

📌 Commit 52919c7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2026
@Urgau Urgau mentioned this pull request Feb 11, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
@bors
Auto merge of #152506 - Urgau:rollup-MlGAszj, r=Urgau
605f49b 
Rollup of 7 pull requests

Successful merges:

 - #152505 (Sync relnotes for stable 1.93.1)
 - #137487 (Stabilize `assert_matches`)
 - #152281 (borrowck: suggest `&mut *x` for pattern reborrows)
 - #151142 (Support ADT types in type info reflection)
 - #152477 (rustc-dev-guide subtree update)
 - #152488 (allow `deprecated(since = "CURRENT_RUSTC_VERSION")`)
 - #152491 (Remove unused `fluent-syntax` dependency from tidy)
@rust-bors rust-bors bot merged commit f8203c6 into rust-lang:main Feb 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 12, 2026
rust-timer added a commit that referenced this pull request Feb 12, 2026
@rust-timer
Unrolled build for #152488
159701b 
Rollup merge of #152488 - cyrgani:deprecation-staged-api, r=JonathanBrouwer

allow `deprecated(since = "CURRENT_RUSTC_VERSION")`

Motivated by #149978.
@cyrgani cyrgani deleted the deprecation-staged-api branch February 12, 2026 07:03
@cyrgani cyrgani mentioned this pull request Feb 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments

@madsmtm madsmtm madsmtm left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cyrgani @rustbot @JonathanBrouwer @madsmtm @mati865