Rollup of 17 pull requests by jhpratt · Pull Request #152517 · rust-lang/rust

jhpratt · 2026-02-12T05:41:13Z

Successful merges:

Add note when inherent impl for a alias type defined outside of the crate #142415 (Add note when inherent impl for a alias type defined outside of the crate)
Fix passing/returning structs with the 64-bit SPARC ABI #142680 (Fix passing/returning structs with the 64-bit SPARC ABI)
Don't compute FnAbi for LLVM intrinsics in backends #150768 (Don't compute FnAbi for LLVM intrinsics in backends)
Add FCW for derive helper attributes that will conflict with built-in attributes #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
layout: handle rigid aliases without params #151814 (layout: handle rigid aliases without params)
Borrowck: simplify diagnostics for placeholders #151863 (Borrowck: simplify diagnostics for placeholders)
Add note for ?Sized params in int-ptr casts diag #152159 (Add note for ?Sized params in int-ptr casts diag)
Clarify names of QueryVTable functions for "executing" a query #152434 (Clarify names of QueryVTable functions for "executing" a query)
Remove tm_factory field from CodegenContext #152478 (Remove tm_factory field from CodegenContext)
Partially revert "resolve: Update NameBindingData::vis in place" #152498 (Partially revert "resolve: Update NameBindingData::vis in place")
fix: add continue #152316 (fix: add continue)
Correctly check if a macro call is actually a macro call in rustdoc highlighter #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter)
Port #![test_runner] to the attribute parser #152425 (Port #![test_runner] to the attribute parser)
Use cg_ssa's produce_final_output_artifacts in cg_clif #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif)
fix issue#152482 #152485 (fix issue#152482)
Clean up some subdiagnostics #152495 (Clean up some subdiagnostics)
Implement BinaryHeap::from_raw_vec #152502 (Implement BinaryHeap::from_raw_vec)

…rate

…ighlighter

Co-authored-by: beetrees <b@beetr.ee>

aliases may be rigid even if they don't reference params. If the alias isn't well-formed, trying to normalize it as part of the input should have already failed

This essentially folds the call to `region_from_element` into `RegionInferenceContext`, and simplifies the error variant for this case. It also clarifies the type information on the methods called to emphasise the fact that they only ever use placeholder regions in the diagnostics, and completely ignore any other element.

… attributes

This also changes the signature of `call_query_method` to not return a value, because its only caller immediately discards the value anyway.

…pected

This is necessary to support serializing the CodegenContext to a .rlink file in the future for moving LTO to the -Zlink-only step.

Add note when inherent impl for a alias type defined outside of the crate Fixes rust-lang#141679 r? compiler

@psumbera

… r=tgross35 Fix passing/returning structs with the 64-bit SPARC ABI Fixes the 64-bit SPARC part of rust-lang#115609 by replacing the current implementation with a new implementation modelled on the RISC-V calling convention code ([SPARC ABI reference](https://sparc.org/wp-content/uploads/2014/01/SCD.2.4.1.pdf.gz)). Pinging `sparcv9-sun-solaris` target maintainers: @psumbera @kulikjak Fixes rust-lang#115336 Fixes rust-lang#115399 Fixes rust-lang#122620 Fixes rust-lang#147883 r? @workingjubilee

@JonathanBrouwer

…ouwer Port #![test_runner] to the attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

…, r=fmease Use cg_ssa's produce_final_output_artifacts in cg_clif

fix issue#152482 Close rust-lang#152482

…ags, r=lqd Clean up some subdiagnostics Just a nice minor cleanup :) * Removes some empty subdiagnostics which could just be subdiagnostic attributes * Convert some manual implementation of `Subdiagnostic` to derives

Implement `BinaryHeap::from_raw_vec` Implements rust-lang#152500. Adds a `BinaryHeap::from_raw_vec` function, which constructs a `BinaryHeap` without performing a heapify, for data that is already a max-heap.

jhpratt · 2026-02-12T05:41:35Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-12T05:41:38Z

📌 Commit faac3c5 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-02-12T10:11:33Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 13m 26s
Pushing 7ad4e69 to main...

github-actions · 2026-02-12T10:14:16Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 605f49b (parent) -> 7ad4e69 (this PR)

Test differences

Show 758 test diffs

Stage 1

[rustdoc-html] tests/rustdoc-html/source-code-pages/macro-call-2.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/source-code-pages/macro-call.rs: [missing] -> pass (J0)
[ui] tests/ui/attributes/ambiguous_derive_helpers.rs: [missing] -> pass (J0)
[ui] tests/ui/imports/overwrite-different-vis-2.rs: [missing] -> pass (J0)
[ui] tests/ui/imports/overwrite-vis-unused.rs: [missing] -> pass (J0)
[ui] tests/ui/incoherent-inherent-impls/insufficient-suggestion-issue-141679.rs: [missing] -> pass (J0)
[ui] tests/ui/layout/rigid-alias-no-params.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/attributes/ambiguous_derive_helpers.rs: [missing] -> pass (J1)
[ui] tests/ui/imports/overwrite-different-vis-2.rs: [missing] -> pass (J1)
[ui] tests/ui/imports/overwrite-vis-unused.rs: [missing] -> pass (J1)
[ui] tests/ui/incoherent-inherent-impls/insufficient-suggestion-issue-141679.rs: [missing] -> pass (J1)
[ui] tests/ui/layout/rigid-alias-no-params.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/source-code-pages/macro-call-2.rs: [missing] -> pass (J2)
[rustdoc-html] tests/rustdoc-html/source-code-pages/macro-call.rs: [missing] -> pass (J2)

Additionally, 744 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7ad4e69ad585d8ff214f7b42d01f1959eda08f40 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 1h 35m -> 2h (+26.5%)
dist-aarch64-llvm-mingw: 2h 1m -> 1h 39m (-18.1%)
i686-gnu-nopt-1: 2h 3m -> 2h 19m (+12.9%)
dist-x86_64-apple: 2h 20m -> 2h 38m (+12.4%)
test-various: 1h 53m -> 2h 6m (+12.0%)
x86_64-gnu-llvm-21-2: 1h 37m -> 1h 26m (-10.7%)
x86_64-gnu-llvm-20-1: 1h 8m -> 1h 13m (+7.5%)
x86_64-gnu-debug: 1h 54m -> 2h 2m (+7.5%)
x86_64-msvc-1: 2h 30m -> 2h 40m (+6.7%)
tidy: 2m 58s -> 2m 46s (-6.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-12T10:16:23Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142415	Add note when inherent impl for a alias type defined outsid…	`e0518901256bd00e5b80b116f7ff17f5dcc17f43` (link)
#142680	Fix passing/returning structs with the 64-bit SPARC ABI	`d2a43dc8db7e5a54991054e4cb06e0fe36a11b25` (link)
#150768	Don't compute FnAbi for LLVM intrinsics in backends	`cd18cd6094769889df232bd0bf757b472d0fc29f` (link)
#151152	Add FCW for derive helper attributes that will conflict wit…	`04e1e27b8db0ed2ecbb2936002e43b842c61d912` (link)
#151814	layout: handle rigid aliases without params	`f87d1b1010af52405801dcc9a11c1a1393dd06d4` (link)
#151863	Borrowck: simplify diagnostics for placeholders	`5f821e064567148f0640aa911ee3a82ea23d7617` (link)
#152159	Add note for `?Sized` params in int-ptr casts diag	`583f6b7dad117ff112bcee00f5ee3e458b010f04` (link)
#152316	fix: add continue	`a087acf2f134f9ed4beeb8215f4c35ee5eb32a2f` (link)
#152394	Correctly check if a macro call is actually a macro call in…	`38dac833a2c1aafd94da843e242f0e3c7505fddd` (link)
#152425	Port #![test_runner] to the attribute parser	`67993890a88751cf0c8e95983aed3f916dfefaed` (link)
#152434	Clarify names of `QueryVTable` functions for "executing" a …	`d3ffc1efb1a678828eb27a45daaf62af4c518a95` (link)
#152478	Remove tm_factory field from CodegenContext	`e57878b78643720654f741fe505ba8d360c53a2e` (link)
#152481	Use cg_ssa's produce_final_output_artifacts in cg_clif	`8b1592bd8e476489ce07ff9c58af14552cb70b0a` (link)
#152485	fix issue#152482	`7330f32761020f3bf4d2d328a3e78407ac9d2006` (link)
#152495	Clean up some subdiagnostics	`c0590ee52a20f8c5b439f0f6ee61ef3b576685b4` (link)
#152498	Partially revert "resolve: Update `NameBindingData::vis` in…	`aca08ce102fe94465094841a177f564660ee0cd2` (link)
#152502	Implement `BinaryHeap::from_raw_vec`	`193f08b08d5b1f8153195416f91818369e31d7f1` (link)

previous master: 605f49b274

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-02-12T11:13:46Z

Finished benchmarking commit (7ad4e69): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.9%, secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-1.9%	[-3.5%, -0.8%]	13
Improvements ✅ (secondary)	-1.9%	[-3.7%, -0.6%]	21
All ❌✅ (primary)	-1.9%	[-3.5%, -0.8%]	13

Cycles

Results (primary 1.9%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	4.6%	[2.1%, 8.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-11.2%	[-11.2%, -11.2%]	1
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.252s -> 480.915s (1.62%)
Artifact size: 395.87 MiB -> 398.15 MiB (0.57%)

bjorn3 and others added 30 commits January 8, 2026 10:45

Reduce usage of FnAbi in codegen_llvm_intrinsic_call

acc8c0b

Don't compute FnAbi for LLVM intrinsics in backends

f1ab003

Remove support for ScalarPair unadjusted arguments

fe9715b

add regression test

d4454e5

Add note for ?Sized params in int-ptr casts diag

aa7c785

fix: add continue

d3ec6a3

Add ui test insufficient-suggestion-issue-141679.rs

3b705ea

Add note when inherent impl for a alias type defined outside of the c…

ed90b35

…rate

Correctly check if a macro call is actually a macro call in rustdoc h…

61b5382

…ighlighter

Add regression test for macro call highlighting

31c4ad3

Fix passing/returning structs with the 64-bit SPARC ABI

c9b5c93

Co-authored-by: beetrees <b@beetr.ee>

prevent incorrect layout error

39a5324

aliases may be rigid even if they don't reference params. If the alias isn't well-formed, trying to normalize it as part of the input should have already failed

fix rustdoc test

337abba

Add FCW for derive helper attributes that will conflict with built-in…

846e4ee

… attributes

Clarify names of QueryVTable functions for "executing" a query

0de45db

This also changes the signature of `call_query_method` to not return a value, because its only caller immediately discards the value anyway.

Remove a couple of unused errors

70587ce

Move target machine factory error reporting into codegen backend

2d07e81

Add extra test to ensure the highlighting for macros is working as ex…

5107af2

…pected

Port #![test_runner] to the attribute parser

d1f11fd

Remove tm_factory field from CodegenContext

f49223c

This is necessary to support serializing the CodegenContext to a .rlink file in the future for moving LTO to the -Zlink-only step.

Use cg_ssa's produce_final_output_artifacts in cg_clif

1106018

fix issue#152482

f48448e

Remove some empty subdiagnostics

635dcd8

Convert some impl Subdiagnostics to derives

ab4891c

Add tests for issues 152004, 151124 and 152347

0cd0840

Partially revert "resolve: Update NameBindingData::vis in place"

324267c

add BinaryHeap::from_raw_vec

9383138

Rollup merge of rust-lang#142415 - xizheyin:141679, r=estebank

c509454

Add note when inherent impl for a alias type defined outside of the crate Fixes rust-lang#141679 r? compiler

jhpratt added 5 commits February 12, 2026 00:41

Rollup merge of rust-lang#152425 - Ozzy1423:test-runner, r=JonathanBr…

9cbcd11

…ouwer Port #![test_runner] to the attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

Rollup merge of rust-lang#152481 - bjorn3:backends_reduce_duplication…

596faf0

…, r=fmease Use cg_ssa's produce_final_output_artifacts in cg_clif

Rollup merge of rust-lang#152485 - ban-xiu:fix-issue-152482, r=jieyouxu

5822878

fix issue#152482 Close rust-lang#152482

Rollup merge of rust-lang#152502 - Dan54:heap-from-raw-vec, r=scottmcm

faac3c5

Implement `BinaryHeap::from_raw_vec` Implements rust-lang#152500. Adds a `BinaryHeap::from_raw_vec` function, which constructs a `BinaryHeap` without performing a heapify, for data that is already a max-heap.

rust-bors bot added the rollup A PR which is a rollup label Feb 12, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2026

rust-bors bot merged commit 7ad4e69 into rust-lang:main Feb 12, 2026
12 checks passed

jhpratt deleted the rollup-fGRcId6 branch February 12, 2026 10:16

This was referenced Feb 12, 2026

Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for bf16(xN) and i1xN #140763

Open

Mangle personality symbol #148413

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 17 pull requests#152517

Rollup of 17 pull requests#152517
rust-bors[bot] merged 45 commits intorust-lang:mainfrom
jhpratt:rollup-fGRcId6

jhpratt commented Feb 12, 2026

Uh oh!

jhpratt commented Feb 12, 2026

Uh oh!

rust-bors bot commented Feb 12, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 12, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 12, 2026

Uh oh!

rust-timer commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Conversation

jhpratt commented Feb 12, 2026

Uh oh!

jhpratt commented Feb 12, 2026

Uh oh!

rust-bors bot commented Feb 12, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 12, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 12, 2026

Uh oh!

rust-timer commented Feb 12, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants