Skip to content

rustc_query_impl: Use ControlFlow in visit_waiters instead of nested options#152582

Open
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:waitvisit
Open

rustc_query_impl: Use ControlFlow in visit_waiters instead of nested options#152582
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:waitvisit

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 13, 2026

Noticed when reviewing #152229.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2026
@petrochenkov petrochenkov marked this pull request as ready for review February 13, 2026 16:14
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, query-system
  • compiler, query-system expanded to 68 candidates
  • Random selection from 17 candidates

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Feb 14, 2026

Thanks. @bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 14, 2026

📌 Commit 2ee28ca has been approved by TaKO8Ki

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152582 - petrochenkov:waitvisit, r=TaKO8Ki
7c36d15 
rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options

Noticed when reviewing rust-lang#152229.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 14, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Feb 14, 2026
@bors
Auto merge of #152632 - JonathanBrouwer:rollup-hVWecYA, r=JonathanBro…
60f234f 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #152622 (Update GCC subtree)
 - #145024 (Optimize indexing slices and strs with inclusive ranges)
 - #151365 (UnsafePinned: implement opsem effects of UnsafeUnpin)
 - #152381 (Do not require `'static` for obtaining reflection information.)
 - #143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s)
 - #152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23)
 - #152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TaKO8Ki TaKO8Ki

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petrochenkov @rustbot @TaKO8Ki