[EXPERIMENT] Measure the perf impact of PackedFingerprint#152695
[EXPERIMENT] Measure the perf impact of PackedFingerprint#152695Zalathar wants to merge 1 commit intorust-lang:mainfrom
PackedFingerprint#152695Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[EXPERIMENT] Measure the perf impact of `PackedFingerprint`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7d1c6cc): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.7%, secondary 4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.0%, secondary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 482.657s -> 482.803s (0.03%) |
I noticed that the
PackedFingerprintoptimization in #78646 is only applied on x86-family hosts, and not on other host architectures, even if they can be expected to support unaligned memory access efficiently (e.g. modernaarch64).Before I propose expanding that optimization to some or all other architectures, let's measure the perf and memory impact that it currently has on x86-64.