Add bootstrap step for stdarch-verify by xonx4l · Pull Request #153957 · rust-lang/rust

xonx4l · 2026-03-16T13:56:39Z

This PR hooks library/stdarch/crates/stdarch-verify crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test.

Changes :
-> Added StdarchVerify in src/bootstrap/src/core/build_steps/test.rs
-> Added test::StdarchVerify in src/bootstrap/src/core/builder/mod.rs

Tests:
-> Running ./x.py test library/stdarch/crates/stdarch-verify builds compiler and std successfully.
-> All three integration tests Passes:
tests/arm.rs
tests/mips.rs
tests/x86-intel.rs
-> Doc tests for stdarch_verify also Passes.

r? @Kobzol

try-job: x86_64-gnu-distcheck

rustbot · 2026-03-16T13:56:45Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Kobzol

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

xonx4l · 2026-03-17T19:37:33Z

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

I have idea focussed towards this route only (run the whole stdarch testsuite under a single rust-lang/rust runner and eventually fully migrate stdarch into rust-lang/rust) as mentioned by amanieu’s . For this PR I Kept the scope small so we can get one piece (stdarch-verify) hooked into bootstrap and then can see how it behaves on CI. And in Follow-ups I have idea to go through the practical and possible route . which is to me is shaping and designing intrinsic-test and core_arch in a way that they are hooked with better data on runtime and flakiness. Then we can reshape (Maybe refactor) the bootstrap steps into single bootstrap step under one job . what you think? I hope that makes sense.

Thank you!

Kobzol · 2026-03-18T16:39:35Z

@bors squash

rust-bors · 2026-03-18T16:39:57Z

🔨 4 commits were squashed into a085b68.

Kobzol · 2026-03-18T16:40:46Z

@bors r+ rollup=iffy

rust-bors · 2026-03-18T16:40:50Z

📌 Commit a085b68 has been approved by Kobzol

It is now in the queue for this repository.

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

…uwer Rollup of 9 pull requests Successful merges: - #153957 (Add bootstrap step for stdarch-verify) - #153727 (When single impl can satisfy inference error, suggest type) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153987 (mGCA: Lower const generic args to infer when needed) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file)

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

…uwer Rollup of 9 pull requests Successful merges: - #153957 (Add bootstrap step for stdarch-verify) - #153727 (When single impl can satisfy inference error, suggest type) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153987 (mGCA: Lower const generic args to infer when needed) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file)

JonathanBrouwer · 2026-03-19T12:15:16Z

@bors try jobs=x86_64-gnu-distcheck

Add bootstrap step for stdarch-verify try-job: x86_64-gnu-distcheck

rust-bors · 2026-05-30T06:48:27Z

☀️ Try build successful (CI)
Build commit: e235dda (e235dda6f9088e94c3d5da70aab515d09a9b4849, parent: 6368fd52cb9f230dfb156097625993e7a8891800)

Kobzol · 2026-05-30T14:34:38Z

Okay, let's try with stdarch being vendored!

@bors r+ rollup=never

rust-bors · 2026-05-30T14:34:40Z

📌 Commit 0dbbede has been approved by Kobzol

It is now in the queue for this repository.

Kobzol · 2026-05-30T18:16:40Z

@bors r-

To fix tidy.

rust-bors · 2026-05-30T18:16:44Z

This pull request was unapproved.

View changes since this unapproval

rustbot · 2026-06-01T04:55:54Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

Kobzol · 2026-06-01T08:15:03Z

Ok, let's try again!

@bors r=Kobzol,bjorn3

rust-bors · 2026-06-01T08:15:06Z

📌 Commit 6535f0b has been approved by Kobzol,bjorn3

It is now in the queue for this repository.

rust-bors · 2026-06-01T15:15:17Z

☀️ Test successful - CI
Approved by: Kobzol,bjorn3
Duration: 3h 34m 30s
Pushing 968d50a to main...

github-actions · 2026-06-01T15:18:22Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4804ad7 (parent) -> 968d50a (this PR)

Test differences

Show 3 test diffs

Stage 0

verify_all_signatures: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-21-1, aarch64-msvc-1, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, optional-x86_64-gnu-parallel-frontend, x86_64-gnu, x86_64-gnu-llvm-21-2, x86_64-gnu-llvm-21-3, x86_64-gnu-llvm-22-2, x86_64-gnu-llvm-22-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 968d50ad35115bc2c8c19cb9039f7ed3dfe56a81 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-llvm-21: 1h 16m -> 45m 46s (-39.9%)
x86_64-msvc-ext3: 1h 25m -> 1h 56m (+36.1%)
i686-msvc-2: 1h 40m -> 2h 14m (+33.8%)
x86_64-msvc-1: 2h 28m -> 1h 42m (-30.8%)
x86_64-gnu-llvm-21-3: 1h 28m -> 1h 52m (+26.5%)
dist-loongarch64-linux: 1h 30m -> 1h 51m (+23.5%)
x86_64-mingw-2: 2h 44m -> 2h 5m (-23.5%)
x86_64-gnu: 2h 25m -> 1h 51m (-23.3%)
i686-gnu-nopt-1: 2h 4m -> 1h 37m (-21.6%)
x86_64-gnu-debug: 2h -> 1h 34m (-21.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-01T15:56:25Z

Finished benchmarking commit (968d50a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.9%	[4.9%, 4.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 509.892s -> 511.125s (0.24%)
Artifact size: 400.78 MiB -> 400.79 MiB (0.00%)

rustbot assigned Kobzol Mar 16, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 16, 2026

This comment has been minimized.

Sign in to view

Kobzol reviewed Mar 17, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/test.rs

Kobzol mentioned this pull request Mar 17, 2026

Teach bootstrap test/doc plumbing to handle an initial stdarch workspace subset #153951

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the stdarch-verify branch from c2e430c to a085b68 Compare March 18, 2026 16:39

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2026

JonathanBrouwer mentioned this pull request Mar 18, 2026

Rollup of 9 pull requests #154062

Closed

Zalathar mentioned this pull request Mar 19, 2026

Rollup of 20 pull requests #154079

Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026

Rollup of 20 pull requests #154080

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Mar 19, 2026

Auto merge of #153957 - xonx4l:stdarch-verify, r=<try>

0225b04

Add bootstrap step for stdarch-verify try-job: x86_64-gnu-distcheck

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 30, 2026

Auto merge of #153957 - xonx4l:stdarch-verify, r=<try>

e235dda

Add bootstrap step for stdarch-verify try-job: x86_64-gnu-distcheck

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2026

bjorn3 reviewed May 30, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/vendor.rs

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 30, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 30, 2026

Add bootstrap step for stdarch-verify

6535f0b

xonx4l force-pushed the stdarch-verify branch from 0dbbede to 6535f0b Compare June 1, 2026 04:55

rustbot added the A-tidy Area: The tidy tool label Jun 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2026

rust-bors Bot merged commit 968d50a into rust-lang:main Jun 1, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 1, 2026

This was referenced Jun 1, 2026

bootstrap: add bootstrap step to run intrinsic-test in CI #156356

Open

bootstrap: add bootstrap step to run stdarch-gen checks in CI #156674

Open

Uh oh!

Conversation

xonx4l commented Mar 16, 2026 • edited by Kobzol Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 16, 2026

Uh oh!

This comment has been minimized.

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

xonx4l commented Mar 17, 2026

Uh oh!

Kobzol commented Mar 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Mar 18, 2026

Uh oh!

Kobzol commented Mar 18, 2026

Uh oh!

rust-bors Bot commented Mar 18, 2026

Uh oh!

JonathanBrouwer commented Mar 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 30, 2026

Uh oh!

Kobzol commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

Uh oh!

Kobzol commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

rustbot commented Jun 1, 2026

Uh oh!

Kobzol commented Jun 1, 2026

Uh oh!

rust-bors Bot commented Jun 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 1, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026

Test differences

Stage 0

Job duration changes

Uh oh!

rust-timer commented Jun 1, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xonx4l commented Mar 16, 2026 •

edited by Kobzol

Loading

Kobzol left a comment •

edited by rustbot

Loading