Suggest adding quotation marks to identifiers in attributes by ariagivens · Pull Request #156797 · rust-lang/rust

ariagivens · 2026-05-21T12:40:45Z

When the user provides an identifier when a literal was expected in an attribute value, suggest adding quotation marks to the identifier to make it a string literal.

For instance:

error: attribute value must be a literal
  --> $DIR/crate-type-non-crate.rs:9:16
   |
LL | #[crate_type = lib]
   |                ^^^ help: try adding quotation marks: `"lib"`

…literal was expected

rustbot · 2026-05-21T12:40:59Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-05-21T12:41:02Z

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

JonathanBrouwer

Thanks for the work ❤️
@bors r+ rollup

View changes since this review

JonathanBrouwer · 2026-05-21T13:46:00Z

Bors u there???
@bors r+ rollup

rust-bors · 2026-05-21T13:46:04Z

📌 Commit 8fec623 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…hanBrouwer Suggest adding quotation marks to identifiers in attributes When the user provides an identifier when a literal was expected in an attribute value, suggest adding quotation marks to the identifier to make it a string literal. For instance: ``` error: attribute value must be a literal --> $DIR/crate-type-non-crate.rs:9:16 | LL | #[crate_type = lib] | ^^^ help: try adding quotation marks: `"lib"` ```

…uwer Rollup of 2 pull requests Successful merges: - #152112 (Use strongly typed wrapped indices in `VecDeque`) - #156797 (Suggest adding quotation marks to identifiers in attributes)

…hanBrouwer Suggest adding quotation marks to identifiers in attributes When the user provides an identifier when a literal was expected in an attribute value, suggest adding quotation marks to the identifier to make it a string literal. For instance: ``` error: attribute value must be a literal --> $DIR/crate-type-non-crate.rs:9:16 | LL | #[crate_type = lib] | ^^^ help: try adding quotation marks: `"lib"` ```

…uwer Rollup of 3 pull requests Successful merges: - #155307 (Stabilize `--remap-path-prefix` in rustdoc) - #152112 (Use strongly typed wrapped indices in `VecDeque`) - #156797 (Suggest adding quotation marks to identifiers in attributes)

JonathanBrouwer · 2026-05-22T05:31:14Z

@bors r-
#156808 (comment)

rust-bors · 2026-05-22T05:31:21Z

This pull request was unapproved.

This PR was contained in a rollup (#156808), which was unapproved.

View changes since this unapproval

ariagivens · 2026-05-27T16:22:42Z

I believe this will fix the test issue, but I haven't figured out how to run the apple tests to be sure.

JonathanBrouwer · 2026-05-27T16:56:55Z

@bors try jobs=aarch64-apple

Suggest adding quotation marks to identifiers in attributes try-job: aarch64-apple

rust-bors · 2026-05-27T18:15:42Z

💔 Test for 77f4876 failed: CI. Failed job:

try - aarch64-apple (web logs, enhanced plaintext logs)

ariagivens · 2026-05-27T19:50:16Z

Okay I have learned the dark secrets of macos emulation. We should be good to go 🙏

@rustbot ready

JonathanBrouwer · 2026-05-27T22:06:20Z

@bors try jobs=aarch64-apple

Suggest adding quotation marks to identifiers in attributes try-job: aarch64-apple

JonathanBrouwer · 2026-05-27T22:06:48Z

(Also how did you emulate macos? I haven't tried that myself yet, usually just rely on CI)

rust-bors · 2026-05-28T01:00:30Z

☀️ Try build successful (CI)
Build commit: 8bc6e9f (8bc6e9ffbbf0617ae2aa63ffce6ae93f1eb906cb, parent: 77a4fb62f70c6ea05e1820216d903938e331d42b)

ariagivens · 2026-05-28T02:51:58Z

(Also how did you emulate macos? I haven't tried that myself yet, usually just rely on CI)

I used QEMU and followed the instructions in this repo: https://github.com/kholia/OSX-KVM

JonathanBrouwer

@bors r+ rollup
Thanks! ❤️

View changes since this review

rust-bors · 2026-05-28T05:09:27Z

📌 Commit 1fa9548 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 6 pull requests Successful merges: - #156932 (relnotes for 1.96) - #156403 (Add `TypeId` methods `variants` `fields` `field` for `type_info`) - #156797 (Suggest adding quotation marks to identifiers in attributes) - #157014 (Allow building the source tarballs while offline) - #157023 (`#[expect]` is an attribute valid for outer style) - #157025 (Show crate root path in misplaced crate-level attribute diagnostic)

Inside attributes, suggest adding quotation marks to identifier when …

8fec623

…literal was expected

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2026

rustbot assigned Kivooeo May 21, 2026

JonathanBrouwer approved these changes May 21, 2026

View reviewed changes

JonathanBrouwer assigned JonathanBrouwer and unassigned Kivooeo May 21, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2026

JonathanBrouwer mentioned this pull request May 21, 2026

Rollup of 2 pull requests #156804

Closed

JonathanBrouwer mentioned this pull request May 21, 2026

Rollup of 3 pull requests #156808

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 27, 2026

Auto merge of #156797 - ariagivens:suggest-quotes, r=<try>

77f4876

Suggest adding quotation marks to identifiers in attributes try-job: aarch64-apple

This comment has been minimized.

Sign in to view

Support quotation mark suggestion for attributes in apple tests

1fa9548

ariagivens force-pushed the suggest-quotes branch from d7be300 to 1fa9548 Compare May 27, 2026 19:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 27, 2026

Auto merge of #156797 - ariagivens:suggest-quotes, r=<try>

8bc6e9f

Suggest adding quotation marks to identifiers in attributes try-job: aarch64-apple

JonathanBrouwer approved these changes May 28, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2026

matthiaskrgr mentioned this pull request May 28, 2026

Rollup of 6 pull requests #157044

Merged

rust-bors Bot merged commit c67006e into rust-lang:main May 28, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone May 28, 2026

Uh oh!

Conversation

ariagivens commented May 21, 2026

Uh oh!

rustbot commented May 21, 2026

Uh oh!

rustbot commented May 21, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented May 21, 2026

Uh oh!

rust-bors Bot commented May 21, 2026

Uh oh!

JonathanBrouwer commented May 22, 2026

Uh oh!

rust-bors Bot commented May 22, 2026

Uh oh!

ariagivens commented May 27, 2026

Uh oh!

JonathanBrouwer commented May 27, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 27, 2026

Uh oh!

This comment has been minimized.

ariagivens commented May 27, 2026

Uh oh!

JonathanBrouwer commented May 27, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented May 27, 2026

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

ariagivens commented May 28, 2026

Uh oh!

JonathanBrouwer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited

Loading