Skip to content

rustdoc: avoid ICE when rendering body-less type consts#156851

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
reddevilmidzy:mgca-doc
May 27, 2026
Merged

rustdoc: avoid ICE when rendering body-less type consts#156851
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
reddevilmidzy:mgca-doc

Conversation

@reddevilmidzy
Copy link
Copy Markdown
Member

@reddevilmidzy reddevilmidzy commented May 23, 2026

close: #149287

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 23, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 23, 2026

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, camelid, fmease, lolbinarycat, notriddle

GuillaumeGomez
GuillaumeGomez reviewed May 25, 2026
View reviewed changes
Comment thread tests/rustdoc-ui/type-const-associated-const-no-body.rs
@@ -0,0 +1,14 @@
//! Regression test for <https://github.com/rust-lang/rust/issues/149287>
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez May 25, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description of what this test is checking.

View changes since the review

Copy link
Copy Markdown
Member Author

@reddevilmidzy reddevilmidzy May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks!

@rustbot ready

GuillaumeGomez
GuillaumeGomez requested changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small nit, looks all good to me, thanks!

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented May 26, 2026

Thanks!

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 26, 2026

📌 Commit bc12569 has been approved by GuillaumeGomez

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156851 - reddevilmidzy:mgca-doc, r=Guillaum…
6730f8f 
…eGomez

rustdoc: avoid ICE when rendering body-less type consts

close: rust-lang#149287
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 26, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request May 26, 2026
@jhpratt
Rollup merge of rust-lang#156851 - reddevilmidzy:mgca-doc, r=Guillaum…
6e06ebd 
…eGomez

rustdoc: avoid ICE when rendering body-less type consts

close: rust-lang#149287
@jhpratt jhpratt mentioned this pull request May 26, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156851 - reddevilmidzy:mgca-doc, r=Guillaum…
a476602 
…eGomez

rustdoc: avoid ICE when rendering body-less type consts

close: rust-lang#149287
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 26, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 26, 2026
@bors
Auto merge of #156986 - JonathanBrouwer:rollup-SGCQqBl, r=JonathanBro…
d666280 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #156796 (Fix missing suggestion when matching `String` with `&str`)
 - #156933 (rustc_parse_format: improve the error diagnostic for `+` sign flag)
 - #156545 (fix issue-144595)
 - #156851 (rustdoc: avoid ICE when rendering body-less type consts)
 - #156942 (Remove unneeded `#[skip_arg]` attributes)
 - #156972 (add field_projections fixme)
 - #156975 (Move check_cfg out of diagnostic attr module)
rust-bors Bot pushed a commit that referenced this pull request May 26, 2026
@bors
Auto merge of #156986 - JonathanBrouwer:rollup-SGCQqBl, r=JonathanBro…
207044a 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #156796 (Fix missing suggestion when matching `String` with `&str`)
 - #156933 (rustc_parse_format: improve the error diagnostic for `+` sign flag)
 - #156545 (fix issue-144595)
 - #156851 (rustdoc: avoid ICE when rendering body-less type consts)
 - #156942 (Remove unneeded `#[skip_arg]` attributes)
 - #156972 (add field_projections fixme)
 - #156975 (Move check_cfg out of diagnostic attr module)
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 27, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 27, 2026
@bors
Auto merge of #157005 - JonathanBrouwer:rollup-1BZFgyy, r=JonathanBro…
ddc1a64 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #156796 (Fix missing suggestion when matching `String` with `&str`)
 - #156933 (rustc_parse_format: improve the error diagnostic for `+` sign flag)
 - #156545 (fix issue-144595)
 - #156814 (Extend macOS deployment target mismatch filter to cover dylib and new ld formats)
 - #156851 (rustdoc: avoid ICE when rendering body-less type consts)
 - #156942 (Remove unneeded `#[skip_arg]` attributes)
 - #156972 (add field_projections fixme)
 - #156975 (Move check_cfg out of diagnostic attr module)
 - #156989 (Add missing --set rust.codegen-backends=["gcc"] in the gcc codegen Dockerfile for the core tests)
@rust-bors rust-bors Bot merged commit 03e935f into rust-lang:main May 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 27, 2026
@reddevilmidzy reddevilmidzy deleted the mgca-doc branch May 27, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

ICE: rustdoc: body_owned_by: HirId(..) has no associated body

3 participants

@reddevilmidzy @rustbot @GuillaumeGomez