Note irrefutable while let in loop type errors#157033
Merged
rust-bors[bot] merged 3 commits intoMay 30, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? @Nadrieril |
Collaborator
|
|
Nadrieril
reviewed
May 29, 2026
Nadrieril
reviewed
May 29, 2026
Nadrieril
reviewed
May 29, 2026
Member
|
Hi @anoshyn, thanks for your PR! The implementation looks good to me, I only have some nitpicks about the exact error message. |
Contributor
Author
|
@Nadrieril Thanks for the review. I addressed both nits in 4fe62be:
The focused UI test still passes: |
Member
|
Nice! There's a third nit, I'm just not sure what's the right method call to make that happen. Can I let you look around first? If you don't find how we can ask on Zulip. |
Contributor
Author
|
Oh, right, I missed it. I think the missing piece is to make this a span label rather than a separate span note, so the text appears next to the underline: I’ll try replacing span_note with span_label and bless the UI output. If that doesn’t produce the intended shape, I’ll ask on Zulip. |
Member
|
Very nice, looks good to me! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 30, 2026
…hile-let-note, r=Nadrieril Note irrefutable while let in loop type errors When a while-let loop is used where a non-unit value is expected, rustc already notes that while loops evaluate to unit. For simple irrefutable while-let patterns, add an extra note explaining that the pattern always matches and the loop condition never fails. Covers binding, wildcard, and tuples made from those patterns. Fixes rust-lang#116572. Tested with: ```./x test tests/ui/coercion/coerce-loop-issue-122561.rs --bless```
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 30, 2026
…hile-let-note, r=Nadrieril Note irrefutable while let in loop type errors When a while-let loop is used where a non-unit value is expected, rustc already notes that while loops evaluate to unit. For simple irrefutable while-let patterns, add an extra note explaining that the pattern always matches and the loop condition never fails. Covers binding, wildcard, and tuples made from those patterns. Fixes rust-lang#116572. Tested with: ```./x test tests/ui/coercion/coerce-loop-issue-122561.rs --bless```
This was referenced May 30, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
May 30, 2026
…uwer Rollup of 12 pull requests Successful merges: - #154591 (Remove `will_cache_on_disk_for_key_fn`) - #156672 (Misc improvements to coroutine transform code) - #157027 (HIR ty lowering: Move some things into submodules) - #157051 (Allow two object files for a single CGU in CompiledModule) - #157100 (Some more per owner things) - #153497 (Use `trait_object_dummy_self` more & heavily fix+update related docs) - #155638 (Fix tupled closure signature in `AsyncFn` arg mismatch diagnostic) - #156826 (style: Clarify nullary call and `()` no-break rule applies past max width) - #157004 (Remove unused functions in `value_analysis.rs`) - #157032 (Fixed more &x ->&mut x suggestions) - #157033 (Note irrefutable while let in loop type errors) - #157139 (compiler: `ops::RangeInclusive` → `range::RangeInclusive`) Failed merges: - #156875 (Correct and document semantics of `yield` terminator)
rust-timer
added a commit
that referenced
this pull request
May 30, 2026
Rollup merge of #157033 - anoshyn:issue-116572-irrefutable-while-let-note, r=Nadrieril Note irrefutable while let in loop type errors When a while-let loop is used where a non-unit value is expected, rustc already notes that while loops evaluate to unit. For simple irrefutable while-let patterns, add an extra note explaining that the pattern always matches and the loop condition never fails. Covers binding, wildcard, and tuples made from those patterns. Fixes #116572. Tested with: ```./x test tests/ui/coercion/coerce-loop-issue-122561.rs --bless```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a while-let loop is used where a non-unit value is expected, rustc already notes that while loops evaluate to unit. For simple irrefutable while-let patterns, add an extra note explaining that the pattern always matches and the loop condition never fails. Covers binding, wildcard, and tuples made from those patterns.
Fixes #116572.
Tested with:
./x test tests/ui/coercion/coerce-loop-issue-122561.rs --bless