Skip to content

add ABI check logic for wasm#157106

Open
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:wasm-abi
Open

add ABI check logic for wasm#157106
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:wasm-abi

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented May 29, 2026

As far as I can tell, this logic is trivial: the only registers that are just conditionally available are SIMD registers, which are already handled by WASM_FEATURES_FOR_CORRECT_FIXED_LENGTH_VECTOR_ABI.

Cc @alexcrichton @rylev @loganek

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 29, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 29, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 29, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@RalfJung RalfJung mentioned this pull request May 29, 2026
Open
17 tasks
@alexcrichton
Copy link
Copy Markdown
Member

alexcrichton commented May 29, 2026

@bors r? me r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 29, 2026

Unknown command "r?". Run @bors help to see available commands.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 29, 2026

Error: Parsing assign command in comment failed: specify user to assign to (if you want to reroll without a specific reviewer in mind, use @rustbot reroll) when parsing: commands.
[!]

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@alexcrichton
Copy link
Copy Markdown
Member

alexcrichton commented May 29, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 29, 2026

📌 Commit 2c0f9de has been approved by alexcrichton

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157106 - RalfJung:wasm-abi, r=alexcrichton
e78122a 
add ABI check logic for wasm

As far as I can tell, this logic is trivial: the only registers that are just conditionally available are SIMD registers, which are already handled by `WASM_FEATURES_FOR_CORRECT_FIXED_LENGTH_VECTOR_ABI`.

Cc @alexcrichton @rylev @loganek
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 29, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157113 - JonathanBrouwer:rollup-OQIpn3C, r=JonathanBro…
1aa8c32 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157103 (Add reproducibly failing tests for parallel frontend)

Failed merges:

 - #157100 (Some more per owner things)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157106 - RalfJung:wasm-abi, r=alexcrichton
8d889f9 
add ABI check logic for wasm

As far as I can tell, this logic is trivial: the only registers that are just conditionally available are SIMD registers, which are already handled by `WASM_FEATURES_FOR_CORRECT_FIXED_LENGTH_VECTOR_ABI`.

Cc @alexcrichton @rylev @loganek
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 29, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157114 - JonathanBrouwer:rollup-z0XiMA0, r=JonathanBro…
eb17695 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157103 (Add reproducibly failing tests for parallel frontend)

Failed merges:

 - #157100 (Some more per owner things)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157106 - RalfJung:wasm-abi, r=alexcrichton
e2df185 
add ABI check logic for wasm

As far as I can tell, this logic is trivial: the only registers that are just conditionally available are SIMD registers, which are already handled by `WASM_FEATURES_FOR_CORRECT_FIXED_LENGTH_VECTOR_ABI`.

Cc @alexcrichton @rylev @loganek
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 29, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157121 - JonathanBrouwer:rollup-htRw3jp, r=JonathanBro…
efcaddb 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157098 (Add the `clflushopt` x86 target feature)
 - #157103 (Add reproducibly failing tests for parallel frontend)
 - #157111 (Update target maintainer for x86_64-unknown-linux-none)
 - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`)
 - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`)
 - #157120 (Cleanups around attribute target checking)

Failed merges:

 - #157100 (Some more per owner things)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157121 - JonathanBrouwer:rollup-htRw3jp, r=JonathanBro…
30484b3 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157098 (Add the `clflushopt` x86 target feature)
 - #157103 (Add reproducibly failing tests for parallel frontend)
 - #157111 (Update target maintainer for x86_64-unknown-linux-none)
 - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`)
 - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`)
 - #157120 (Cleanups around attribute target checking)

Failed merges:

 - #157100 (Some more per owner things)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157121 - JonathanBrouwer:rollup-htRw3jp, r=JonathanBro…
d3199a7 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157098 (Add the `clflushopt` x86 target feature)
 - #157103 (Add reproducibly failing tests for parallel frontend)
 - #157111 (Update target maintainer for x86_64-unknown-linux-none)
 - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`)
 - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`)
 - #157120 (Cleanups around attribute target checking)

Failed merges:

 - #157100 (Some more per owner things)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157121 - JonathanBrouwer:rollup-htRw3jp, r=JonathanBro…
25ad2bd 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157098 (Add the `clflushopt` x86 target feature)
 - #157103 (Add reproducibly failing tests for parallel frontend)
 - #157111 (Update target maintainer for x86_64-unknown-linux-none)
 - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`)
 - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`)
 - #157120 (Cleanups around attribute target checking)

Failed merges:

 - #157100 (Some more per owner things)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
@bors
Auto merge of #157121 - JonathanBrouwer:rollup-htRw3jp, r=JonathanBro…
c24e9c9 
…uwer

Rollup of 16 pull requests



Successful merges:

 - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error)
 - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
 - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`)
 - #157053 (Eagerly resolve delegations in late resolution)
 - #157068 (NVPTX: Remove the unstable ptx linker flavor)
 - #157076 (Various proc-macro related code cleanups)
 - #157106 (add ABI check logic for wasm)
 - #154835 (std::offload sharedmem)
 - #157065 (Stabilize `Path::is_empty`)
 - #157088 (Improve suggestions for malformed deprecated attribute)
 - #157098 (Add the `clflushopt` x86 target feature)
 - #157103 (Add reproducibly failing tests for parallel frontend)
 - #157111 (Update target maintainer for x86_64-unknown-linux-none)
 - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`)
 - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`)
 - #157120 (Cleanups around attribute target checking)

Failed merges:

 - #157100 (Some more per owner things)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

@alexcrichton alexcrichton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung @rustbot @alexcrichton @jackh726