Clean up attribute target checking diagnostics#157291
Merged
rust-bors[bot] merged 3 commits intoJun 2, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
JonathanBrouwer
changed the title
JonathanBrouwer
commented
Jun 2, 2026
| | | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = help: `#[inline]` can only be applied to functions | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! |
Contributor
Author
There was a problem hiding this comment.
This reordering is unavoidable with this cleanup sadly, but also imo the new order is slightly better, putting the "previously accepted" last since it has least to do with the rest of the diagnostic
JonathanBrouwer
force-pushed
the
cleanup-target-checking
branch
from
84074ab to
397dd46
Compare
GuillaumeGomez
approved these changes
Jun 2, 2026
Member
|
Looks good to me, thanks! Please wait for @mejrs review though. ;) |
mejrs
approved these changes
Jun 2, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
…uwer Rollup of 14 pull requests Successful merges: - #156467 (mark the 'import linkage' statics as unnamed_addr) - #156923 (Couple of diagnostics improvements for EII) - #157240 (Enable Enzyme for aarch64-apple-darwin) - #157244 (Privacy: tweak macros + more tests) - #157276 (miri subtree update) - #157130 (Use a `ArrayVec` in `CastTarget`) - #157131 (Add regression test for issue #144888) - #157195 (Move feature gating to the new attr parsing infrastructure) - #157233 (rustdoc: Fix trait impl ordering) - #157256 (tests: adapt for LLVM codegen change) - #157265 (Update books) - #157277 (triagebot.toml: add LawnGnome to libs reviewers) - #157291 (Clean up attribute target checking diagnostics) - #157301 (Remove unused import from a test)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
…uwer Rollup of 14 pull requests Successful merges: - #156467 (mark the 'import linkage' statics as unnamed_addr) - #156923 (Couple of diagnostics improvements for EII) - #157240 (Enable Enzyme for aarch64-apple-darwin) - #157244 (Privacy: tweak macros + more tests) - #157276 (miri subtree update) - #157130 (Use a `ArrayVec` in `CastTarget`) - #157131 (Add regression test for issue #144888) - #157195 (Move feature gating to the new attr parsing infrastructure) - #157233 (rustdoc: Fix trait impl ordering) - #157256 (tests: adapt for LLVM codegen change) - #157265 (Update books) - #157277 (triagebot.toml: add LawnGnome to libs reviewers) - #157291 (Clean up attribute target checking diagnostics) - #157301 (Remove unused import from a test)
rust-timer
added a commit
that referenced
this pull request
Jun 2, 2026
Rollup merge of #157291 - JonathanBrouwer:cleanup-target-checking, r=mejrs Clean up attribute target checking diagnostics Split off from me trying to process your review comments in #157215 Thanks to @GuillaumeGomez for making this possible <3 r? @mejrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from me trying to process your review comments in #157215
Thanks to @GuillaumeGomez for making this possible <3
r? @mejrs