Skip to content

Add more tests for the optimize attribute#157297

Open
veluca93 wants to merge 1 commit into
rust-lang:mainfrom
veluca93:more-optimize-tests
Open

Add more tests for the optimize attribute#157297
veluca93 wants to merge 1 commit into
rust-lang:mainfrom
veluca93:more-optimize-tests

Conversation

@veluca93
Copy link
Copy Markdown
Contributor

@veluca93 veluca93 commented Jun 2, 2026

Tracking issue: #54882
Stabilization PR: #157273

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 2, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@veluca93 veluca93 mentioned this pull request Jun 2, 2026
Open
jieyouxu
jieyouxu reviewed Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few more coverage nits
@rustbot author

View changes since this review

Comment thread tests/ui/attributes/malformed-attrs.rs
Comment thread tests/ui/attributes/optimize.rs
Comment thread tests/ui/attributes/optimize.rs
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 2, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jieyouxu
jieyouxu reviewed Jun 2, 2026
View reviewed changes
Comment thread tests/ui/attributes/malformed-attrs.rs
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu Jun 2, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: I feel like we should probably hoist the optimize attr ones into a separate test, this test is kinda of an abomination of everything

View changes since the review

Copy link
Copy Markdown
Contributor Author

@veluca93 veluca93 Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily disagree, but I'm not sure this PR is the best place to do that -- if you have strong opinions I can move them in optimize.rs though.

Copy link
Copy Markdown
Member

@jieyouxu jieyouxu Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as-is in this PR for now.

@jieyouxu jieyouxu self-assigned this Jun 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@veluca93 veluca93 force-pushed the more-optimize-tests branch from 534f1da to 14b4baf Compare June 2, 2026 20:37
@veluca93
Copy link
Copy Markdown
Contributor Author

veluca93 commented Jun 2, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2026
@veluca93 veluca93 force-pushed the more-optimize-tests branch from 14b4baf to 1333de7 Compare June 2, 2026 21:26
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 2, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented Jun 2, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[TIMING:end] compile::StdLink { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: [], force_recompile: false } -- 0.001
##[group]Building stage1 compiler artifacts (stage0 -> stage1, x86_64-unknown-linux-gnu)
error: process didn't exit successfully: `sccache /checkout/obj/build/bootstrap/debug/rustc -vV` (exit status: 2)
--- stderr
sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information

Bootstrap failed while executing `build --stage 2 compiler rustdoc`
Build completed unsuccessfully in 0:00:36
  local time: Tue Jun  2 21:30:55 UTC 2026
  network time: Tue, 02 Jun 2026 21:30:55 GMT

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 2, 2026

☔ The latest upstream changes (presumably #157329) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu
jieyouxu approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good but needs a rebase.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@dingxiangfei2009 dingxiangfei2009

@jieyouxu jieyouxu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@veluca93 @rustbot @rust-log-analyzer @jieyouxu @dingxiangfei2009