Rollup of 9 pull requests by JonathanBrouwer · Pull Request #157329 · rust-lang/rust

JonathanBrouwer · 2026-06-02T19:16:58Z

Successful merges:

LivenessValues: use dedicated enum rather than mutually exclusive Options #157035 (LivenessValues: use dedicated enum rather than mutually exclusive Options)
Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize)
rustdoc: Render impl restriction #157310 (rustdoc: Render impl restriction)
Remove skip_arg attribute from Diagnostic and Subdiagnostic proc-macros #157070 (Remove skip_arg attribute from Diagnostic and Subdiagnostic proc-macros)
rustc_target: Use +spe for powerpcspe targets #157137 (rustc_target: Use +spe for powerpcspe targets)
Implement argument-dependent target checking for the #[repr] parser #157215 (Implement argument-dependent target checking for the #[repr] parser)
additional changes for issue-144595 #157235 (additional changes for issue-144595)
Remove unnecessary arm in handle_res #157321 (Remove unnecessary arm in handle_res)
Add test for undefined EII static error #157324 (Add test for undefined EII static error)

…c-macros, skipping fields based on whether or not they are used in error messages

…agnostics/message.rs`

…, r=jackh726 `LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s I was reading through `LivenessValues` and realised it had a lot of comments explaining that two `Option`s were mutually exclusive, plus some redundant logic to handle this. This is a drive-by fix to use ~~an `Either`~~ a dedicated enum instead, which makes that property obvious from the code. It also removes the repeated logic.

…ochenkov Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize This fixes the perf regression in rust-lang#157076.

@Urgau

…tion, r=GuillaumeGomez,jhpratt,Urgau rustdoc: Render `impl` restriction According to the [Zulip conversation](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/Documenting.20.60impl.60.20restrictions/with/598960498), this PR implements the rendering of `impl` restrictions. Following the pattern used for `#[rustc_must_implement_one_of]`, this adds an information note saying, "This trait cannot be implemented outside \<crate-name\>". When `--document-private-items` is passed, the note instead says, "This trait cannot be implemented outside \<path-to-module\>". The screenshots show the generated documentation for the following code: ```rust pub mod inner { pub impl(self) trait Bar {} } ``` in a crate `c`. The latter image corresponds to the case where `--document-private-items` is passed. Tracking issue: rust-lang#105077 r? @Urgau cc @jhpratt <img width="920" height="309" alt="screenshot" src="https://github.com/user-attachments/assets/586c97d6-0f41-41de-9673-eaf12b96c4a1" /> <img width="902" height="316" alt="document-private-screenshot" src="https://github.com/user-attachments/assets/56aedc38-bd05-4ece-885a-8d928a59089c" />

@JonathanBrouwer

…thanBrouwer Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros Instead of having users to manually add `#[skip_arg]` for each field that is not used in fluent messages, I think it's better to instead let the proc-macro only call `diag.arg("name", field)` on the fields actually used. r? @JonathanBrouwer

@RalfJung

rustc_target: Use +spe for powerpcspe targets LLVM does not infer this from the target name and `abi: "spe"` is just for cfg. To actually generate the correct instructions for these targets (without `-C target-cpu`), we need to pass `+spe` to LLVM. Fixes rust-lang#138960 See also rust-lang#157085 Related rust-lang#137860 cc @RalfJung cc @BKPepe ([powerpc-unknown-linux-muslspe target maintainer](https://doc.rust-lang.org/nightly/rustc/platform-support/powerpc-unknown-linux-muslspe.html#target-maintainers)) cc @glaubitz (who added powerpc-unknown-linux-gnuspe in rust-lang#48484) cc @biabbas @hax0kartik ([*-wrs-vxworks target maintainers](https://doc.rust-lang.org/nightly/rustc/platform-support/vxworks.html#target-maintainers)) @rustbot label +O-PowerPC +A-target-feature

@mejrs

…ng3, r=mejrs Implement argument-dependent target checking for the `#[repr]` parser Fixes some of rust-lang#156499 Fixes some of rust-lang#153101 Alternative approach to rust-lang#156569, which was suggested in the comments here: rust-lang#156569 (review) How do you feel about this approach? r? @mejrs

@ada4a

…mejrs additional changes for issue-144595 - add spaces between the braces @ada4a - remove `:` in the help message. I learn this from estebank ("In the text we don't include a trailing :, unless we have a very specific reason. These messages can render in the terminal, in different ways, or in IDEs. Having a : can look out of place in some cases, specifically in rust-analyzer in VSCode is one of them.") - suggest to use `::` for any colon encountered in tuple struct. So it now display help message for `std::string:String`. The same logic also appears in `parse_block_tail`, it suggest the user to use `::` when `parse_full_stmt` stops at a colon. So I think it's okay to make this change. r? mejrs

…ouwer Remove unnecessary arm in `handle_res` Just nits found when reading the code

@jdonszelmann

Add test for undefined EII static error Meant to add this to rust-lang#156923, but pushed to the wrong branch. r? @jdonszelmann

JonathanBrouwer · 2026-06-02T19:17:12Z

@bors r+ rollup=never p=5

rust-bors · 2026-06-02T19:17:15Z

📌 Commit 51c415a has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 9 pull requests Successful merges: - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s) - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize) - #157310 (rustdoc: Render `impl` restriction) - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros) - #157137 (rustc_target: Use +spe for powerpcspe targets) - #157215 (Implement argument-dependent target checking for the `#[repr]` parser) - #157235 (additional changes for issue-144595) - #157321 (Remove unnecessary arm in `handle_res`) - #157324 (Add test for undefined EII static error)

rust-bors · 2026-06-02T19:31:09Z

💔 Test for 71fe9bf failed: CI. Failed job:

auto - dist-powerpc64le-linux-gnu (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-02T19:31:59Z

@bors retry

…uwer Rollup of 9 pull requests Successful merges: - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s) - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize) - #157310 (rustdoc: Render `impl` restriction) - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros) - #157137 (rustc_target: Use +spe for powerpcspe targets) - #157215 (Implement argument-dependent target checking for the `#[repr]` parser) - #157235 (additional changes for issue-144595) - #157321 (Remove unnecessary arm in `handle_res`) - #157324 (Add test for undefined EII static error)

rust-log-analyzer · 2026-06-02T19:37:26Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-06-02T19:38:34Z

💔 Test for 8be9415 failed: CI. Failed job:

auto - dist-loongarch64-musl (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-02T19:42:04Z

@bors retry

rust-bors · 2026-06-02T19:42:13Z

⌛ Testing commit 51c415a with merge d595fce...

Workflow: https://github.com/rust-lang/rust/actions/runs/26843721920

…uwer Rollup of 9 pull requests Successful merges: - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s) - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize) - #157310 (rustdoc: Render `impl` restriction) - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros) - #157137 (rustc_target: Use +spe for powerpcspe targets) - #157215 (Implement argument-dependent target checking for the `#[repr]` parser) - #157235 (additional changes for issue-144595) - #157321 (Remove unnecessary arm in `handle_res`) - #157324 (Add test for undefined EII static error)

rust-log-analyzer · 2026-06-02T20:00:39Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

taiki-e and others added 25 commits May 30, 2026 13:11

rustc_target: Use +spe for powerpcspe targets

3277a9c

Region values: use an enum as opposed to two Options

a5b1187

Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize

936f0ce

fix

381cea9

Render impl restriction

b5acf95

Add tests for impl restriction rendering

5358c2f

Remove unnecessary arm

49f80b3

Remove skip_arg attribute from Diagnostic and Subdiagnostic pro…

5521a56

…c-macros, skipping fields based on whether or not they are used in error messages

Remove #[skip_arg] references from rustc-dev-guide

551940e

Fix compilation error because of potential_query_instability in `di…

579831c

…agnostics/message.rs`

Add test for undefined EII static error

62fbbec

Integrate target checking for #[repr] into its attribute parser

87a08b1

Add specific arguments to the diagnostic message

b40c43d

Re-add hints for rustc_align

a78d218

Add debug assertion to ensure target checking is not missed

80d33c7

Add regression test for repr on mac call

79e666b

Rollup merge of rust-lang#157182 - bjorn3:fix_perf_regression, r=petr…

9ca6103

…ochenkov Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize This fixes the perf regression in rust-lang#157076.

Rollup merge of rust-lang#157321 - mu001999-contrib:nit, r=JonathanBr…

7f2e2bd

…ouwer Remove unnecessary arm in `handle_res` Just nits found when reading the code

Rollup merge of rust-lang#157324 - bjorn3:eii_error_test, r=jdonszelmann

51c415a

Add test for undefined EII static error Meant to add this to rust-lang#156923, but pushed to the wrong branch. r? @jdonszelmann

rust-bors Bot added the rollup A PR which is a rollup label Jun 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests#157329

Rollup of 9 pull requests#157329
JonathanBrouwer wants to merge 25 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-DyoIgRF

JonathanBrouwer commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 2, 2026

Uh oh!

rust-bors Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

rust-bors Bot commented Jun 2, 2026 •

edited

Loading