Rollup of 7 pull requests by jhpratt · Pull Request #157361 · rust-lang/rust

jhpratt · 2026-06-03T06:41:33Z

Successful merges:

Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2 #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2)
Remove -Zemscripten-wasm-eh #156928 (Remove -Zemscripten-wasm-eh)
Reorganize tests/ui/issues [3/N] #157236 (Reorganize tests/ui/issues [3/N])
Split coroutine layout computation to its own file #157294 (Split coroutine layout computation to its own file)
windows: Elide division-by-zero checks in Instant::now() #157328 (windows: Elide division-by-zero checks in Instant::now())
Rewrite target checking for #[link] #157331 (Rewrite target checking for #[link])
Enable clippy::mem_replace_with_default #157336 (Enable clippy::mem_replace_with_default)

We already have a vector of `CoroutineSavedTy`, no need to have a separate one just for debuginfo.

Avoid complicated loops just for an optimization.

`coroutine.rs` was getting too large, and mixing MIR analyses for trait solving and runtime transformations.

This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code.

this removes the panic path when dividing by the frequency. this also makes calls to Instant::now() faster.

…=petrochenkov Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2 This PR promotes five Thumb-mode bare-metal Arm targets to Tier 2, joining their Arm-mode counterparts which are already Tier 2: | Thumb-mode target (Tier 3 → Tier 2) | Arm-mode counterpart (already Tier 2) | |:---|:---| | `thumbv7a-none-eabi` | `armv7a-none-eabi` | | `thumbv7a-none-eabihf` | `armv7a-none-eabihf` | | `thumbv7r-none-eabi` | `armv7r-none-eabi` | | `thumbv7r-none-eabihf` | `armv7r-none-eabihf` | | `thumbv8r-none-eabihf` | `armv8r-none-eabihf` | Note: There is no `thumbv8r-none-eabi` target because the Cortex-R52 processor always includes an FPU, making a soft-float ABI variant unnecessary. These Thumb-mode targets generate T32 code by default while their Arm-mode counterparts generate A32 code. They share the same LLVM backend, ABI, and data layout — the only spec differences are the `llvm_target` string and the description. See rust-lang/compiler-team#985

…r=TaKO8Ki Remove -Zemscripten-wasm-eh This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code. This is the final step of rust-lang#112195.

@Teapot4195

Reorganize `tests/ui/issues` [3/N] Part of [GSoC'26 project](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Reorganizing.20tests.2Fui.2Fissues) r? Kivooeo @Teapot4195

…=oli-obk Split coroutine layout computation to its own file `coroutine.rs` is getting too large, and mixes MIR analyses for trait solving and runtime transformations.

…ChrisDenton windows: Elide division-by-zero checks in Instant::now() This PR teaches LLVM that the frequency of the performance counter is non null so it is able to remove division by zero checks. This removes the panic path in `mul_div_u64` and should make calls to `Instant::now()` (very slightly) faster. As seen in the assembly (see godbolt below), telling LLVM that the frequency is non zero suffices to get the optimization, but I don't know if it could be a great idea to also update the signature of `mul_div_u64`? MSDN page for [QueryPerformanceFrequency](https://learn.microsoft.com/en-us/windows/win32/api/profileapi/nf-profileapi-queryperformancefrequency): > On systems that run Windows XP or later, the function will always succeed when given valid parameters and will thus never return zero. Godbolt: https://rust.godbolt.org/z/xr6x8MrPE

@mejrs

Rewrite target checking for `#[link]` r? @mejrs

…lt, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closes rust-lang#157245.

jhpratt · 2026-06-03T06:41:43Z

@bors r+ rollup=never p=4

rust-bors · 2026-06-03T06:41:47Z

📌 Commit 025c0a0 has been approved by jhpratt

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

jhpratt · 2026-06-03T07:46:35Z

@bors p=7

threading between two rollup=never PRs

Rollup of 7 pull requests Successful merges: - #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - #156928 (Remove -Zemscripten-wasm-eh) - #157236 (Reorganize `tests/ui/issues` [3/N]) - #157294 (Split coroutine layout computation to its own file) - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157331 (Rewrite target checking for `#[link]`) - #157336 (Enable `clippy::mem_replace_with_default`)

rust-bors · 2026-06-03T09:19:27Z

💔 Test for 86e387d failed: CI. Failed job:

auto - armhf-gnu (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-03T09:28:05Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-06-03T09:38:16Z

@bors retry

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

JonathanBrouwer · 2026-06-03T11:56:57Z

Made a bigger rollup of 15 PRs

rust-bors · 2026-06-03T11:57:01Z

This pull request was unapproved due to being closed.

rust-bors · 2026-06-03T13:07:21Z

☀️ Try build successful (CI)
Build commit: dae0102 (dae0102a12e4405fa86dc7ec896d40db2d1ca01c, parent: 53509ca37e3b507887607c2f4a7f23bd4838f099)

zedddie and others added 21 commits June 1, 2026 14:12

move batch

3c6c901

bless batch

01f5cc8

Integrate field_names inside field_tys.

7092ebf

We already have a vector of `CoroutineSavedTy`, no need to have a separate one just for debuginfo.

Simplify compute_layout.

c8ce74a

Avoid complicated loops just for an optimization.

Split coroutine layout computation to its own file.

2a2e4c9

`coroutine.rs` was getting too large, and mixing MIR analyses for trait solving and runtime transformations.

Move coroutine.rs to be a mod.rs

62690a6

Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2

e3468ae

Pacify doc-checker.

ac63a3e

Remove -Zemscripten-wasm-eh

9b7623a

This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code.

bootstrap: enable clippy::mem_replace_with_default

3a850de

compiler: fix clippy::mem_replace_with_default warnings

3dacac8

windows: remove division-by-zero checks for performance counters

c2b9f39

this removes the panic path when dividing by the frequency. this also makes calls to Instant::now() faster.

Rewrite target checking for #[link]

b6a204f

Add a test for #[link] on macro calls

d8698f5

Rollup merge of rust-lang#157236 - zedddie:gsoc-batch-3-meow, r=Kivooeo

33d981a

Reorganize `tests/ui/issues` [3/N] Part of [GSoC'26 project](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Reorganizing.20tests.2Fui.2Fissues) r? Kivooeo @Teapot4195

Rollup merge of rust-lang#157294 - cjgillot:split-coroutine-layout, r…

7e3cec9

…=oli-obk Split coroutine layout computation to its own file `coroutine.rs` is getting too large, and mixes MIR analyses for trait solving and runtime transformations.

Rollup merge of rust-lang#157331 - JonathanBrouwer:target-link, r=mejrs

200201f

Rewrite target checking for `#[link]` r? @mejrs

Rollup merge of rust-lang#157336 - JarlEvanson:mem-replace-with-defau…

025c0a0

…lt, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closes rust-lang#157245.

rust-bors Bot added the rollup A PR which is a rollup label Jun 3, 2026

rustbot added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer closed this Jun 3, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2026

jhpratt deleted the rollup-ua6tt0N branch June 3, 2026 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#157361

Rollup of 7 pull requests#157361
jhpratt wants to merge 21 commits into
rust-lang:mainfrom
jhpratt:rollup-ua6tt0N

jhpratt commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 3, 2026

Uh oh!

rust-log-analyzer commented Jun 3, 2026

Uh oh!

JonathanBrouwer commented Jun 3, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

jhpratt commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 3, 2026

Uh oh!

rust-log-analyzer commented Jun 3, 2026

Uh oh!

JonathanBrouwer commented Jun 3, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants