Skip to content

librustdoc: fix CSS border issue to support Firefox high contrast mode #157381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Jun 3, 2026
+7 −7
Merged

librustdoc: fix CSS border issue to support Firefox high contrast mode #157381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ec9b30
librustdoc: fix CSS border issue to support Firefox high contrast mod…
robbycbennett Jun 3, 2026
8e9173f
librustdoc: update test to fix CSS border issue to support Firefox hi…
robbycbennett Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,8 @@ ul.block, .block li, .block ul {
}

.block ul a {
padding-left: 1rem;
/* extend click target to far edge of screen (mile wide bar) */
padding-left: calc(1rem + var(--sidebar-elems-left-padding));
}

.sidebar-elems a,
Expand All @@ -740,7 +741,7 @@ ul.block, .block li, .block ul {
padding: 0.25rem; /* 4px */
margin-right: 0.25rem;
/* extend click target to far edge of screen (mile wide bar) */
border-left: solid var(--sidebar-elems-left-padding) transparent;
padding-left: calc(0.25rem + var(--sidebar-elems-left-padding));
margin-left: calc(-0.25rem - var(--sidebar-elems-left-padding));
background-clip: border-box;
}
Expand Down Expand Up @@ -861,7 +862,7 @@ ul.block, .block li, .block ul {
| └─────┘
*/
margin-top: -16px;
border-top: solid 16px transparent;
padding-top: 16px;
box-sizing: content-box;
position: relative;
background-clip: border-box;
Expand All @@ -870,8 +871,6 @@ ul.block, .block li, .block ul {

.sidebar-crate h2 a {
display: block;
/* extend click target to far edge of screen (mile wide bar) */
border-left: solid var(--sidebar-elems-left-padding) transparent;
background-clip: border-box;
margin: 0 calc(-24px + 0.25rem) 0 calc(-0.2rem - var(--sidebar-elems-left-padding));
/* Align the sidebar crate link with the search bar, which have different
Expand All @@ -888,7 +887,8 @@ ul.block, .block li, .block ul {
x = ( 16px - 0.57rem ) / 2
*/
padding: calc( ( 16px - 0.57rem ) / 2 ) 0.25rem;
padding-left: 0.2rem;
/* extend click target to far edge of screen (mile wide bar) */
padding-left: calc(0.2rem + var(--sidebar-elems-left-padding));
}

.sidebar-crate h2 .version {
Expand Down
2 changes: 1 addition & 1 deletion tests/rustdoc-gui/huge-logo.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ set-window-size: (1280, 1024)
assert-property: (".sidebar-crate .logo-container", {"offsetWidth": "96", "offsetHeight": 48})
// offsetWidth = width of sidebar, offsetHeight = height + top padding
assert-property: (".sidebar-crate .logo-container img", {"offsetWidth": "48", "offsetHeight": 64})
assert-css: (".sidebar-crate .logo-container img", {"border-top-width": "16px", "margin-top": "-16px"})
assert-css: (".sidebar-crate .logo-container img", {"padding-top": "16px", "margin-top": "-16px"})
Loading