Skip to content

Rollup of 4 pull requests#157421

Merged
rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-FgDsiba
Jun 4, 2026
Merged

Rollup of 4 pull requests#157421
rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-FgDsiba

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented Jun 4, 2026

Successful merges:

r? @ghost

Create a similar rollup

Omnikar and others added 8 commits May 31, 2026 14:20
@Omnikar
Add doc comment to Vec::clone
aa9e76e
@kohsine
Add regression test for late-bound type param in nested impl Trait
7f6a63c
@veluca93
Add more tests for the optimize attribute
1745325
@JonathanBrouwer
Add target checking to #[register_tool]
957e505
@JonathanBrouwer
Rollup merge of rust-lang#157297 - veluca93:more-optimize-tests, r=ji…
411e9fc 
…eyouxu

Add more tests for the `optimize` attribute

Tracking issue: rust-lang#54882
Stabilization PR: rust-lang#157273
@JonathanBrouwer
Rollup merge of rust-lang#157377 - JonathanBrouwer:target-register-to…
96fc9b8 
…ol, r=mejrs

Add target checking to `#[register_tool]`

r? @mejrs
@JonathanBrouwer
Rollup merge of rust-lang#157138 - Omnikar:vec-clone-doc, r=joboet
649f157 
Add doc comment to `Vec::clone`

I read about Clippy's [`repeat_vec_with_capacity`](https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#repeat_vec_with_capacity) lint and figured it was worth adding a note about the relevant behavior to the documentation of `Vec::clone` itself, which previously did not have its own doc comment.
@JonathanBrouwer
Rollup merge of rust-lang#157400 - kohsine:late-bound-assoc-type-reg-…
accc90f 
…test, r=Kivooeo

Add regression test for late-bound type param in nested `impl Trait`

Regression test for rust-lang#132055
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 4, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 4, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Jun 4, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 4, 2026

📌 Commit accc90f has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 4, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 21m 43s
Pushing 9ae765d to main...

@rust-bors rust-bors Bot merged commit 9ae765d into rust-lang:main Jun 4, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 4, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Jun 4, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#157138 Add doc comment to Vec::clone f5ee405188c4d50dda9e2560f9d3e15e634d05b3 (link)
#157297 Add more tests for the optimize attribute 9c625fc299f4ee2a98dc226aef5ff1656eec3ce5 (link)
#157377 Add target checking to #[register_tool] cb0f4a6878d825fede8c4f6035bfb554ed6ff5cb (link)
#157400 Add regression test for late-bound type param in nested `im… 03fb582c59b717c0fe22f04ea4afd396eb32661a (link)

previous master: 0cf9681261

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0cf9681 (parent) -> 9ae765d (this PR)

Test differences

Show 90 test diffs

Stage 1

  • [ui] tests/ui/attributes/register-tool-target.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/non_lifetime_binders/late-bound-assoc-type.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/attributes/register-tool-target.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/non_lifetime_binders/late-bound-assoc-type.rs: [missing] -> pass (J1)

Additionally, 86 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9ae765da471fd0bc3b305953e72c4eb12f304416 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 14m 49s -> 9m 52s (-33.4%)
  2. dist-x86_64-apple: 1h 39m -> 2h 8m (+30.1%)
  3. i686-gnu-1: 1h 51m -> 2h 20m (+26.1%)
  4. dist-x86_64-solaris: 1h 16m -> 1h 35m (+25.1%)
  5. x86_64-msvc-ext1: 2h 17m -> 1h 42m (-25.1%)
  6. x86_64-gnu-llvm-21-1: 55m 43s -> 43m 19s (-22.3%)
  7. x86_64-gnu-aux: 2h 18m -> 1h 48m (-21.6%)
  8. dist-x86_64-illumos: 1h 45m -> 1h 24m (-20.1%)
  9. dist-powerpc64-linux-musl: 1h 34m -> 1h 16m (-19.0%)
  10. pr-check-1: 34m 32s -> 29m 2s (-15.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Jun 4, 2026

Finished benchmarking commit (9ae765d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.7%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.7% [1.5%, 1.9%] 2
Regressions ❌
(secondary)		 2.3% [1.6%, 3.4%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.5% [-6.1%, -1.6%] 3
All ❌✅ (primary) 1.7% [1.5%, 1.9%] 2

Cycles

Results (secondary 5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.7% [2.0%, 10.5%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 4
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 4

Bootstrap: 512.762s -> 515.26s (0.49%)
Artifact size: 400.63 MiB -> 400.73 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @rust-timer @rustbot @Omnikar @kohsine @veluca93