Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0.#46411
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 12, 2017
Merged
Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0.#46411bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
cc @LukasKalbertodt. This fixes an apparent oversight in #46411. |
kennytm
added
S-waiting-on-review
Contributor
|
They're not in 1.22.0 either. 1.23.0 is the first version with these methods. Also, I assume you meant to link to #44042. |
Contributor
Author
|
Oops, yes, that's correct. Thanks! |
rillian
force-pushed
the
str_ascii
branch
2 times, most recently
from
2949f54 to
6fdbf4b
Compare
rillian
changed the title
Contributor
Author
|
The documentation is also incorrect in 1.23.0 beta. Could someone please nominate this issue for inclusion there? |
Collaborator
|
☔ The latest upstream changes (presumably #46288) made this pull request unmergeable. Please resolve the merge conflicts. |
The ascii_methods_on_intrinsics feature stabilization didn't land in time for 1.21.0. Update the annotation so the documentation is correct about when these methods became available.
Contributor
Author
|
@Kimundi review ping? |
Contributor
Author
rillian
changed the title
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 6aef5e3 has been approved by |
kennytm
added
beta-nominated
Collaborator
bors
added a commit
that referenced
this pull request
Dec 12, 2017
Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. The ascii_methods_on_intrinsics feature stabilization didn't land in time for 1.21.0. Update the annotation so the documentation is correct about when these methods became available.
Contributor
Author
|
Thanks @kennytm! :D |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added
the
beta-accepted
Member
|
Looks like we forgot to backport this to 1.23.0 (sorry about that!) so removing the beta tags. |
alexcrichton
removed
beta-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ascii_methods_on_intrinsics feature stabilization
didn't land in time for 1.21.0. Update the annotation
so the documentation is correct about when these
methods became available.