[WIP] Make derive(Clone) memcpy on enum variants containing Copy types#47848
Closed
Manishearth wants to merge 7 commits intorust-lang:masterfrom
Closed
[WIP] Make derive(Clone) memcpy on enum variants containing Copy types#47848Manishearth wants to merge 7 commits intorust-lang:masterfrom
Manishearth wants to merge 7 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
force-pushed
the
faster-clone-derive
branch
from
8beaf52 to
7725ee5
Compare
Member
Author
|
nowehere near ready for review, this was just me messing around. I might rewrite this to do something rather differently soon. |
estebank
reviewed
Jan 29, 2018
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
Will wait for further changes before properly reviewing, but we'll want somebody else besides me from the compiler team to look at it too.
| /// | ||
| /// For enums, the second field is the index of the variant | ||
| /// within AdtDef::fields | ||
| Adt(&'tcx AdtDef, usize, &'tcx Substs<'tcx>, Option<usize>), |
Contributor
There was a problem hiding this comment.
I wonder if we should start moving to struct-like variants for anything that has more than 3 fields throughout the compiler...
Member
Author
|
Yeah I'm going to get review from eddyb later. |
Member
Author
|
Superseded by #47867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #47796