Stabilize match_default_bindings by cramertj · Pull Request #49394 · rust-lang/rust

cramertj · 2018-03-26T21:45:03Z

This includes a submodule update to rustfmt
in order to allow a stable feature declaration.

Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.

rust-highfive · 2018-03-26T21:45:13Z

Warning

These commits modify submodules.

petrochenkov · 2018-03-26T22:00:25Z

The tracking issue has two unresolved questions (#44848, #44849) - how they are currently treated? Is there some conservative future-compatible behavior implemented?

cramertj · 2018-03-26T22:11:44Z

@petrochenkov See my comment above-- these are both errors now, and I believe they could be made to not error in the future in a backwards-compatible way.

bors · 2018-03-27T00:12:53Z

☔ The latest upstream changes (presumably #49053) made this pull request unmergeable. Please resolve the merge conflicts.

kennytm · 2018-03-27T07:21:00Z

src/libsyntax/feature_gate.rs

This should definitely not be 1.22.0...

nikomatsakis · 2018-03-27T16:00:37Z

@bors r+

bors · 2018-03-27T16:00:38Z

📌 Commit d36eee1 has been approved by nikomatsakis

kennytm · 2018-03-27T16:06:42Z

@bors p=15

bors · 2018-03-27T17:21:22Z

⌛ Testing commit d36eee1 with merge 8d20660...

@nikomatsakis

Stabilize match_default_bindings This includes a submodule update to rustfmt in order to allow a stable feature declaration. r? @nikomatsakis cc #42640 Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.

bors · 2018-03-27T20:21:51Z

💔 Test failed - status-appveyor

kennytm · 2018-03-27T21:02:40Z

@bors retry

3 hour timeout

bors · 2018-03-27T23:39:59Z

⌛ Testing commit d36eee1 with merge 7cd6ced665f481746902e12d9d5fd3da2ed314b3...

bors · 2018-03-28T02:41:24Z

💔 Test failed - status-appveyor

kennytm · 2018-03-28T09:10:40Z

@cramertj I think you need to actually rebase.

This includes a submodule update to rustfmt in order to allow a stable feature declaration.

cramertj · 2018-03-28T09:14:04Z

@kennytm Weird-- I didn't see any conflicts. Rebased anyways.

@bors r=nikomatsakis p=15

bors · 2018-03-28T09:14:05Z

📌 Commit 3c65f53 has been approved by nikomatsakis

bors · 2018-03-28T10:57:32Z

⌛ Testing commit 3c65f53 with merge 29b54f86dc2d61faf66686fc40cc7f11759ac7fa...

bors · 2018-03-28T12:56:05Z

💔 Test failed - status-travis

Mark-Simulacrum · 2018-03-28T13:00:29Z

I will assume that this is spurious, but I suppose we should also cc @BurntSushi.

@bors retry

[01:54:53] thread 'test_cat::prop_cat_cols' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (CsvData { data: [[[]]] }, CsvData { data: [[[239, 187, 191]]] })
[01:54:53] Error: "assertion failed: `(left == right)`\n  left: `[]`,\n right: `[[\"\", \"\\u{feff}\"]]`"', /cargo/registry/src/github.com-1ecc6299db9ec823/quickcheck-0.4.1/src/tester.rs:147:28
[01:54:53]
[01:54:53]
[01:54:53] failures:
[01:54:53]     test_cat::prop_cat_cols
[01:54:53]
[01:54:53] test result: FAILED. 421 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:54:53]
[01:54:53]
[01:54:53] error: test failed, to rerun pass '--test tests'
[01:54:53] thread 'main' panicked at 'tests failed for https://github.com/BurntSushi/xsv', tools/cargotest/main.rs:100:9

kennytm · 2018-03-28T14:38:03Z

The xsv error is supposed to be fixed by BurntSushi/xsv@92de288 and #45550, not sure why this is coming back...

BurntSushi · 2018-03-28T14:50:07Z

@Mark-Simulacrum I would say that is definitely spurious. I'll try to take a closer look soonish, but not sure exactly when.

bors · 2018-03-28T15:31:35Z

⌛ Testing commit 3c65f53 with merge 1169541...

@nikomatsakis

Stabilize match_default_bindings This includes a submodule update to rustfmt in order to allow a stable feature declaration. r? @nikomatsakis cc #42640 Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.

bors · 2018-03-28T18:11:39Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 1169541 to master...

rust-highfive assigned nikomatsakis Mar 26, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2018

cramertj force-pushed the stable-match-bindings branch from dd98f84 to 1f6a313 Compare March 26, 2018 21:55

cramertj force-pushed the stable-match-bindings branch from 1f6a313 to 38520cf Compare March 26, 2018 22:11

cramertj force-pushed the stable-match-bindings branch from 38520cf to 578ab15 Compare March 27, 2018 07:12

kennytm reviewed Mar 27, 2018

View reviewed changes

src/libsyntax/feature_gate.rs Outdated

Copy link

Member

kennytm Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely not be 1.22.0...

cramertj force-pushed the stable-match-bindings branch from 578ab15 to d36eee1 Compare March 27, 2018 07:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018

cramertj added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 27, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 27, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2018

Stabilize match_default_bindings

3c65f53

This includes a submodule update to rustfmt in order to allow a stable feature declaration.

cramertj force-pushed the stable-match-bindings branch from d36eee1 to 3c65f53 Compare March 28, 2018 09:13

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018

bors merged commit 3c65f53 into rust-lang:master Mar 28, 2018

bors mentioned this pull request Mar 28, 2018

Stabilize underscore lifetimes #49458

Merged

This was referenced Apr 26, 2018

tracking issue for default binding modes in match (RFC 2005, match_default_bindings) #42640

Closed

update the book for default_match_bindings rust-lang/book#1288

Closed

zackmdavis mentioned this pull request Apr 28, 2018

Poor help error message for unused variable on struct enum match #50303

Closed

flier mentioned this pull request May 14, 2018

normalize match reference style, #929 rust-lang/rustfmt#2697

Closed

koba-e964 added a commit to koba-e964/min-caml-rust that referenced this pull request Jun 10, 2018

Adapt to rustc 1.26.0 features (rust-lang/rust#49394)

1a25224

d3lio mentioned this pull request Jul 9, 2018

Compiler unexpectedly panics #52170

Closed

csmoe mentioned this pull request Oct 5, 2018

Add option to open URLs on click alacritty/alacritty#1617

Merged

azriel91 mentioned this pull request Dec 13, 2018

Maintain compatibility with Rust 1.25 rust-lang/backtrace-rs#137

Merged

Nadrieril mentioned this pull request Mar 16, 2019

Extend &pattern to general Deref implementation. rust-lang/rfcs#2099

Open

ollie27 mentioned this pull request Mar 15, 2020

Regenerate tables for Unicode 13.0.0 #69929

Merged

Uh oh!

Comments

Conversation

cramertj commented Mar 26, 2018

Uh oh!

rust-highfive commented Mar 26, 2018

Uh oh!

petrochenkov commented Mar 26, 2018

Uh oh!

cramertj commented Mar 26, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

kennytm Mar 27, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

kennytm commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

kennytm commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

kennytm commented Mar 28, 2018

Uh oh!

cramertj commented Mar 28, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

Mark-Simulacrum commented Mar 28, 2018

Uh oh!

kennytm commented Mar 28, 2018

Uh oh!

BurntSushi commented Mar 28, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

bors commented Mar 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants