implement the chalk-engine traits by nikomatsakis · Pull Request #50937 · rust-lang/rust

nikomatsakis · 2018-05-21T13:14:04Z

Preliminary implementation for the Chalk traits in rustc. Lots of panic!() placeholders to be filled in later.

This is currently blocked on us landing rust-lang/chalk#131 in chalk and issuing a new release, which should occur later today.

r? @scalexm
cc @leodasvacas

rust-highfive · 2018-05-21T13:33:02Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

####                                                                       6.7%
##############################################################            87.3%
######################################################################## 100.0%
[00:01:16] extracting /checkout/obj/build/cache/2018-05-10/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:16] error: failed to read `/chalk/chalk-engine/Cargo.toml`
[00:01:16] Caused by:
[00:01:16]   No such file or directory (os error 2)
[00:01:16]   No such file or directory (os error 2)
[00:01:16] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:16] Build completed unsuccessfully in 0:00:14
[00:01:16] make: *** [prepare] Error 1
[00:01:16] Makefile:81: recipe for target 'prepare' failed
[00:01:17] Command failed. Attempt 2/5:
[00:01:17] error: failed to read `/chalk/chalk-engine/Cargo.toml`
[00:01:17] Caused by:
[00:01:17]   No such file or directory (os error 2)
[00:01:17]   No such file or directory (os error 2)
[00:01:17] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:17] Build completed unsuccessfully in 0:00:00
[00:01:17] make: *** [prepare] Error 1
[00:01:17] Makefile:81: recipe for target 'prepare' failed
[00:01:19] Command failed. Attempt 3/5:
[00:01:19] error: failed to read `/chalk/chalk-engine/Cargo.toml`
[00:01:19] Caused by:
[00:01:19]   No such file or directory (os error 2)
[00:01:19]   No such file or directory (os error 2)
[00:01:19] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:19] Build completed unsuccessfully in 0:00:00
[00:01:19] Makefile:81: recipe for target 'prepare' failed
[00:01:19] make: *** [prepare] Error 1
[00:01:22] Command failed. Attempt 4/5:
[00:01:22] error: failed to read `/chalk/chalk-engine/Cargo.toml`
[00:01:22] Caused by:
[00:01:22]   No such file or directory (os error 2)
[00:01:22]   No such file or directory (os error 2)
[00:01:22] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:22] Build completed unsuccessfully in 0:00:00
[00:01:22] Makefile:81: recipe for target 'prepare' failed
[00:01:22] make: *** [prepare] Error 1
[00:01:26] Command failed. Attempt 5/5:
[00:01:26] error: failed to read `/chalk/chalk-engine/Cargo.toml`
[00:01:26] Caused by:
[00:01:26]   No such file or directory (os error 2)
[00:01:26]   No such file or directory (os error 2)
[00:01:26] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:26] Build completed unsuccessfully in 0:00:00
[00:01:26] make: *** [prepare] Error 1
[00:01:26] Makefile:81: recipe for target 'prepare' failed
[00:01:26] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:0a91c3ee
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-21T15:01:15Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

################################################################          89.8%
######################################################################## 100.0%
[00:01:19] extracting /checkout/obj/build/cache/2018-05-10/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:19]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:37] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:37] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:37] Build completed unsuccessfully in 0:00:36
[00:01:37] make: *** [prepare] Error 1
[00:01:37] Makefile:81: recipe for target 'prepare' failed
[00:01:38]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:38]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:39] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:39] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:39] Build completed unsuccessfully in 0:00:00
[00:01:39] make: *** [prepare] Error 1
[00:01:39] Makefile:81: recipe for target 'prepare' failed
[00:01:41]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:41]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:41] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:41] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:41] Build completed unsuccessfully in 0:00:00
[00:01:41] make: *** [prepare] Error 1
[00:01:41] Makefile:81: recipe for target 'prepare' failed
[00:01:45]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:45]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:46] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:46] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:46] Build completed unsuccessfully in 0:00:01
[00:01:46] make: *** [prepare] Error 1
[00:01:46] Makefile:81: recipe for target 'prepare' failed
[00:01:50]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:50]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:53] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:53] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:53] Build completed unsuccessfully in 0:00:03
[00:01:53] make: *** [prepare] Error 1
[00:01:53] Makefile:81: recipe for target 'prepare' failed
[00:01:53] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:06656e88
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-21T16:00:09Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:12]  Downloading rustc-ap-rustc_cratesio_shim v128.0.0
[00:03:12]  Downloading ena v0.9.3
[00:03:13]  Downloading parking_lot v0.5.5
[00:03:13]  Downloading byteorder v1.2.2
[00:03:13]  Downloading chalk-engine v0.4.0
[00:03:13]  Downloading rustc-ap-rustc_errors v128.0.0
[00:03:13]  Downloading owning_ref v0.3.3
[00:03:13]  Downloading schannel v0.1.12
[00:03:13]  Downloading globset v0.3.0
---
[00:03:16]  Downloading crossbeam-epoch v0.3.1
[00:03:16]  Downloading itertools v0.6.5
[00:03:16]  Downloading chalk-macros v0.1.0
[00:03:16]  Downloading docopt v0.8.3
[00:03:16]  Downloading lalrpop-intern v0.14.0
[00:03:17]  Downloading stacker v0.1.3
[00:03:17]  Downloading rustyline v1.0.0
[00:03:18]  Downloading fxhash v0.2.1
[00:03:18]  Downloading bitflags v0.9.1
[00:03:18]  Downloading unreachable v1.0.0
[00:03:18]  Downloading utf-8 v0.7.2
---

[00:05:45] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:45] tidy error: /checkout/src/librustc_traits/chalk_context.rs: incorrect license
[00:05:45] tidy error: /checkout/src/librustc/ty/context.rs:1651: line longer than 100 chars
[00:05:45] tidy error: /checkout/src/librustc/ty/context.rs:1666: line longer than 100 chars
[00:05:46] Dependencies not on the whitelist:
[00:05:46] * chalk-engine 
[00:05:46] * chalk-macros 
[00:05:46] * diff 
[00:05:46] * encode_unicode 
[00:05:46] * error-chain 
[00:05:46] * fixedbitset 
[00:05:46] * fxhash 
[00:05:46] * fxhash 
[00:05:46] * gcc 
[00:05:46] * itertools 
[00:05:46] * lalrpop-intern 
[00:05:46] * nix 
[00:05:46] * petgraph 
[00:05:46] * proc-macro2 
[00:05:46] * quote 
[00:05:46] * rustyline 
---
[00:05:46] * unicode-xid 
[00:05:46] some tidy checks failed
[00:05:46] 
[00:05:46] 
[00:05:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:46] 
[00:05:46] 
[00:05:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:46] Build completed unsuccessfully in 0:02:26
[00:05:46] Build completed unsuccessfully in 0:02:26
[00:05:46] make: *** [tidy] Error 1
[00:05:46] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d706a48
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

leoyvens · 2018-05-21T16:11:19Z

src/librustc_traits/chalk_context.rs

Isn't it better to use an unimplemented!() here?

rust-highfive · 2018-05-22T00:44:51Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:55]  Downloading foreign-types-shared v0.1.1
[00:02:55]  Downloading kernel32-sys v0.2.2
[00:02:55]  Downloading jobserver v0.1.11
[00:02:55]  Downloading backtrace v0.3.6
[00:02:55]  Downloading chalk-engine v0.5.0
[00:02:55]  Downloading arrayvec v0.4.7
[00:02:56]  Downloading memoffset v0.2.1
[00:02:56]  Downloading nodrop v0.1.12
[00:02:56]  Downloading miow v0.3.1
---

[00:05:04] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:04] tidy error: /checkout/src/librustc_traits/chalk_context.rs: incorrect license
21136 ./src/llvm-emscripten/test/Transforms
20692 ./obj/build/x86_64-unknown-linux-gnu/stage0-tools
20488 ./.git/modules/src/liblibc
20328 ./.git/modules/src/liblibc/objects

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

leoyvens · 2018-05-22T11:18:19Z

src/librustc/ty/mod.rs

This will conflict with #50930, this file can be reverted to master version.

rust-highfive · 2018-05-24T13:33:19Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

#####################################################################     97.2%
######################################################################## 100.0%
[00:01:26] extracting /checkout/obj/build/cache/2018-05-10/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:26]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:45] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:45] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:45] Build completed unsuccessfully in 0:00:41
[00:01:45] Makefile:81: recipe for target 'prepare' failed
[00:01:45] make: *** [prepare] Error 1
[00:01:46] Command failed. Attempt 2/5:
[00:01:47] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:47] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:47] Build completed unsuccessfully in 0:00:00
[00:01:47] Makefile:81: recipe for target 'prepare' failed
[00:01:47] make: *** [prepare] Error 1
[00:01:49] Command failed. Attempt 3/5:
[00:01:49] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:49] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:49] Build completed unsuccessfully in 0:00:00
[00:01:49] make: *** [prepare] Error 1
[00:01:49] Makefile:81: recipe for target 'prepare' failed
[00:01:52] Command failed. Attempt 4/5:
[00:01:52] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:52] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:52] Build completed unsuccessfully in 0:00:00
[00:01:52] Makefile:81: recipe for target 'prepare' failed
[00:01:52] make: *** [prepare] Error 1
[00:01:56] Command failed. Attempt 5/5:
[00:01:56] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:56] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:56] Build completed unsuccessfully in 0:00:00
[00:01:56] make: *** [prepare] Error 1
[00:01:56] Makefile:81: recipe for target 'prepare' failed
[00:01:56] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:01fbe831
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-24T13:49:16Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:08]  Downloading phf_generator v0.7.21
[00:03:08]  Downloading matches v0.1.6
[00:03:08]  Downloading percent-encoding v1.0.1
[00:03:08]  Downloading idna v0.1.4
[00:03:08]  Downloading chalk-engine v0.6.0
[00:03:09]  Downloading compiletest_rs v0.3.9
[00:03:09]  Downloading regex v0.2.10
[00:03:09]  Downloading is-match v0.1.0
[00:03:09]  Downloading error-chain v0.11.0
---

[00:05:49] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:49] tidy error: /checkout/src/librustc_traits/chalk_context.rs: incorrect license
[00:05:49] tidy error: /checkout/src/librustc/ty/context.rs:1532: line longer than 100 chars
[00:05:49] tidy error: /checkout/src/librustc/ty/context.rs:1547: line longer than 100 chars
[00:05:51] Dependencies not on the whitelist:
[00:05:51] * chalk-engine 
[00:05:51] * chalk-macros 
[00:05:51] * rustc-hash 
[00:05:51] some tidy checks failed
[00:05:51] 
[00:05:51] 
[00:05:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:51] 
[00:05:51] 
[00:05:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:51] Build completed unsuccessfully in 0:02:28
[00:05:51] Build completed unsuccessfully in 0:02:28
[00:05:51] make: *** [tidy] Error 1
[00:05:51] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0dfebf70
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-05-24T16:45:51Z

@bors delegate=scalexm,leodasvacas -- I figure this is pretty chalk-focused, so they're best qualified to r+

bors · 2018-05-24T16:45:52Z

📌 Commit 8fd316f has been approved by nikomatsakis

bors · 2018-05-24T16:45:53Z

✌️ @scalexm,leodasvacas can now approve this pull request

scalexm · 2018-05-24T16:57:04Z

@bors r+

bors · 2018-05-24T16:57:06Z

@scalexm: 🔑 Insufficient privileges: Not in reviewers

nikomatsakis · 2018-05-24T16:57:17Z

@bors delegate=scalexm

bors · 2018-05-24T16:57:22Z

✌️ @scalexm can now approve this pull request

nikomatsakis · 2018-05-24T16:57:35Z

@bors r=scalexm

scalexm · 2018-05-24T16:57:46Z

@bors r+

bors · 2018-05-24T16:57:51Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Enforce stability of const fn in promoteds #50909

bors · 2018-05-24T16:57:52Z

📌 Commit 8fd316f has been approved by scalexm

bors · 2018-05-24T16:58:06Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Enforce stability of const fn in promoteds #50909

bors · 2018-05-24T16:58:06Z

📌 Commit 8fd316f has been approved by scalexm

bors · 2018-05-24T19:21:17Z

⌛ Testing commit 8fd316f with merge 670f4dcb166188e86423f6e914ce6d14e556b6f5...

bors · 2018-05-24T20:54:37Z

💔 Test failed - status-travis

rust-highfive · 2018-05-24T20:54:40Z

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:41]  Downloading log_settings v0.1.1
[00:02:41]  Downloading num-integer v0.1.36
[00:02:42]  Downloading backtrace v0.3.6
[00:02:42]  Downloading tempdir v0.3.7
[00:02:42]  Downloading chalk-engine v0.6.0
[00:02:42]  Downloading flate2 v1.0.1
[00:02:42]  Downloading mdbook v0.1.7
[00:02:42]  Downloading clap v2.31.2
[00:02:42]  Downloading failure v0.1.1
---
[00:14:11] [RUSTC-TIMING] atty test:false 0.211
[00:14:11]    Compiling log_settings v0.1.1
[00:14:12] [RUSTC-TIMING] log_settings test:false 0.419
[00:14:12]    Compiling backtrace v0.3.6
[00:14:13] [RUSTC-TIMING] chalk_macros test:false 1.280
[00:14:14] [RUSTC-TIMING] backtrace test:false 2.217
[00:14:15]    Compiling humantime v1.1.1
[00:14:15]    Compiling ena v0.9.3
[00:14:16] [RUSTC-TIMING] ena test:false 0.912
---
[00:14:20]    Compiling crossbeam-epoch v0.3.1
[00:14:20]    Compiling rls-span v0.4.0
[00:14:21] [RUSTC-TIMING] rustc_platform_intrinsics test:false 15.619
[00:14:21] [RUSTC-TIMING] rls_span test:false 1.526
[00:14:22]    Compiling chalk-engine v0.6.0
[00:14:22]    Compiling parking_lot_core v0.2.14
[00:14:22] [RUSTC-TIMING] jobserver test:false 5.670
[00:14:22]    Compiling tempdir v0.3.7
[00:14:23] [RUSTC-TIMING] tempdir test:false 1.288
[00:14:23] [RUSTC-TIMING] tempdir test:false 1.288
[00:14:24]    Compiling rustc_apfloat v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_apfloat)
[00:14:25] [RUSTC-TIMING] parking_lot_core test:false 2.954
[00:14:25]    Compiling env_logger v0.5.8
[00:14:28] [RUSTC-TIMING] rustc_apfloat test:false 4.224
[00:14:28]    Compiling rls-data v0.16.0
[00:14:29] [RUSTC-TIMING] chalk_engine test:false 7.068
[00:14:29] [RUSTC-TIMING] env_logger test:false 4.427
[00:14:30] [RUSTC-TIMING] miniz_sys test:false 0.174
[00:14:30] [RUSTC-TIMING] crossbeam_deque test:false 0.493
[00:14:30]    Compiling parking_lot v0.5.5
---
[00:34:17]    Compiling num_cpus v1.8.0
[00:34:17] [RUSTC-TIMING] num_cpus test:false 0.354
[00:34:17]    Compiling atty v0.2.8
[00:34:18] [RUSTC-TIMING] atty test:false 0.248
[00:34:18]    Compiling chalk-macros v0.1.0
[00:34:19] [RUSTC-TIMING] chalk_macros test:false 1.418
[00:34:20] [RUSTC-TIMING] log_settings test:false 0.490
[00:34:20]    Compiling backtrace v0.3.6
[00:34:22] [RUSTC-TIMING] rand test:false 5.394
[00:34:22] [RUSTC-TIMING] backtrace test:false 2.196
---
[00:34:25] [RUSTC-TIMING] ena test:false 0.744
[00:34:26]    Compiling jobserver v0.1.11
[00:34:26]    Compiling crossbeam-epoch v0.3.1
[00:34:27] [RUSTC-TIMING] rustc_serialize test:false 15.456
[00:34:28]    Compiling chalk-engine v0.6.0
[00:34:28]    Compiling parking_lot_core v0.2.14
[00:34:28] [RUSTC-TIMING] rustc_platform_intrinsics test:false 16.370
[00:34:28]    Compiling tempdir v0.3.7
[00:34:29] [RUSTC-TIMING] tempdir test:false 0.994
[00:34:29] [RUSTC-TIMING] tempdir test:false 0.994
[00:34:30] [RUSTC-TIMING] jobserver test:false 3.993
[00:34:30]    Compiling env_logger v0.5.8
[00:34:31] [RUSTC-TIMING] parking_lot_core test:false 2.323
[00:34:31]    Compiling rustc_apfloat v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_apfloat)
[00:34:34] [RUSTC-TIMING] chalk_engine test:false 5.778
[00:34:34]    Compiling rls-span v0.4.0
[00:34:34]    Compiling crossbeam-deque v0.2.0
[00:34:34] [RUSTC-TIMING] rustc_apfloat test:false 3.465
[00:34:34] [RUSTC-TIMING] miniz_sys test:false 0.162
---
$ travis_retry gem update --system
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
    no such name (https://api.rubygems.org/specs.4.8.gz)
The command "gem update --system" failed. Retrying, 2 of 3.
ERROR:  While executing gem ... (Gem::RemoteFetcher::FetchError)
    Errno::EHOSTUNREACH: Failed to open TCP connection to rubygems.org:443 (No route to host - connect(2) for "rubygems.org" port 443) (https://rubygems.org/specs.4.8.gz)
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
    no such name (https://api.rubygems.org/quick/Marshal.4.8/rubygems-update-2.7.7.gemspec.rz)
The command "gem update --system" failed 3 times.
travis_time:end:1a33c62c:start=1527194927078275000,finish=1527195208260579000,duration=281182304000


The command "travis_retry gem update --system" failed and exited with 1 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-24T20:55:15Z

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

$ travis_retry gem update --system
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
    no such name (https://api.rubygems.org/specs.4.8.gz)
The command "gem update --system" failed. Retrying, 2 of 3.
ERROR:  While executing gem ... (Gem::RemoteFetcher::FetchError)
    Errno::EHOSTUNREACH: Failed to open TCP connection to rubygems.org:443 (No route to host - connect(2) for "rubygems.org" port 443) (https://rubygems.org/specs.4.8.gz)
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
    no such name (https://api.rubygems.org/quick/Marshal.4.8/rubygems-update-2.7.7.gemspec.rz)
The command "gem update --system" failed 3 times.
travis_time:end:1a33c62c:start=1527194927078275000,finish=1527195208260579000,duration=281182304000


The command "travis_retry gem update --system" failed and exited with 1 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-05-24T21:42:34Z

travis failures look spurious.

emilyalbini · 2018-05-24T21:48:47Z

That error is caused by travis itself (it wasn't able to download a ruby gem it needs to deploy things).

@bors retry

bors · 2018-05-24T23:10:24Z

⌛ Testing commit 8fd316f with merge b86d909...

@scalexm

implement the chalk-engine traits Preliminary implementation for the Chalk traits in rustc. Lots of `panic!()` placeholders to be filled in later. This is currently blocked on us landing rust-lang/chalk#131 in chalk and issuing a new release, which should occur later today. r? @scalexm cc @leodasvacas

bors · 2018-05-25T01:33:37Z

☀️ Test successful - status-appveyor, status-travis
Approved by: scalexm
Pushing b86d909 to master...

rust-highfive assigned scalexm May 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2018

nikomatsakis force-pushed the chalkify-engine-2 branch from a2f0e10 to 5ef8cc9 Compare May 21, 2018 13:29

nikomatsakis force-pushed the chalkify-engine-2 branch 3 times, most recently from c9e1a26 to fd52186 Compare May 21, 2018 14:54

nikomatsakis force-pushed the chalkify-engine-2 branch from fd52186 to d5486da Compare May 21, 2018 15:20

leoyvens reviewed May 21, 2018

View reviewed changes

src/librustc_traits/chalk_context.rs Outdated

Copy link

Contributor

leoyvens May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use an unimplemented!() here?

nikomatsakis force-pushed the chalkify-engine-2 branch from d5486da to 9dde1b2 Compare May 22, 2018 00:37

leoyvens reviewed May 22, 2018

View reviewed changes

src/librustc/ty/mod.rs Outdated

Copy link

Contributor

leoyvens May 22, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #50930, this file can be reverted to master version.

nikomatsakis force-pushed the chalkify-engine-2 branch from 9dde1b2 to 70f0030 Compare May 24, 2018 13:27

nikomatsakis force-pushed the chalkify-engine-2 branch from 70f0030 to 9ab03d9 Compare May 24, 2018 13:34

nikomatsakis force-pushed the chalkify-engine-2 branch from 9fc3dd1 to b0a926f Compare May 24, 2018 14:41

nikomatsakis added 4 commits May 24, 2018 12:01

implement the chalk traits, albeit with many placeholders

6f425a9

get rustc_hash from external crate

9c548bf

extend the crate whitelist to include rustc-hash, chalk

3b1a170

pacify the mercilous tidy

8fd316f

nikomatsakis force-pushed the chalkify-engine-2 branch from b0a926f to 8fd316f Compare May 24, 2018 16:25

nikomatsakis changed the title ~~[WIP] Implement the chalk-engine traits~~ implement the chalk-engine traits May 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2018

scalexm approved these changes May 24, 2018

View reviewed changes

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2018

emilyalbini mentioned this pull request May 24, 2018

Spurious failure while installing deploy dependencies #44159

Closed

bors merged commit 8fd316f into rust-lang:master May 25, 2018

This was referenced May 25, 2018

Replace tempdir by tempfile #50698

Merged

Blocking Rayon queries #50699

Merged

kennytm mentioned this pull request May 25, 2018

Hash up to 8 bytes at once with FxHasher #51019

Merged

Uh oh!

Comments

Conversation

nikomatsakis commented May 21, 2018

Uh oh!

rust-highfive commented May 21, 2018

Uh oh!

rust-highfive commented May 21, 2018

Uh oh!

rust-highfive commented May 21, 2018

Uh oh!

leoyvens May 21, 2018

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented May 22, 2018

Uh oh!

leoyvens May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

nikomatsakis commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

scalexm commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

nikomatsakis commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

nikomatsakis commented May 24, 2018

Uh oh!

scalexm commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

nikomatsakis commented May 24, 2018

Uh oh!

emilyalbini commented May 24, 2018

Uh oh!

bors commented May 24, 2018

Uh oh!

bors commented May 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

leoyvens May 22, 2018 •

edited

Loading