Made std::intrinsics::transmute() const fn. by TheDarkula · Pull Request #53535 · rust-lang/rust

TheDarkula · 2018-08-20T18:55:36Z

tracking issue: #53605

rust-highfive · 2018-08-20T20:13:30Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:44:58] ....................................................................................................
[00:45:01] ....................................................................................................
[00:45:04] ....................................................................................................
[00:45:07] ............i.......................................................................................
[00:45:12] ..............................................................F....................................i
[00:45:18] .............ii.iii.................................................................................
[00:45:20] ....................................................................................................
[00:45:22] ....................................................................................................
[00:45:25] ....................................................................................................
---
travis_time:end:2dc7b9f5:start=1534796007490465638,finish=1534796007498866080,duration=8400442
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1c72aea0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk

You need to add transmute to

rust/src/librustc_mir/transform/qualify_consts.rs

Line 819 in 1558ae7

| "size_of"

and then (because transmute is special) add a language feature gate for blocking its use without a feature gate (e.g. next to

rust/src/libsyntax/feature_gate.rs

Line 222 in 6bf6d50

(active, const_raw_ptr_deref, "1.27.0", Some(51911), None),

)

oli-obk · 2018-08-21T08:41:55Z

src/test/run-pass/ctfe/transmute-const.rs

please write this test in terms of std::mem::transmute

oli-obk · 2018-08-21T08:43:27Z

src/test/run-pass/ctfe/transmute-const.rs

This test should not be passing without an additional const_transmute feature gate

rust-highfive · 2018-08-21T20:57:58Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:start:tidy
tidy check
[00:04:44] * 555 error codes
[00:04:44] * highest error code: E0712
[00:04:44] tidy error: libsyntax/feature_gate.rs:225: no tracking issue for feature const_transmute
[00:04:45] Expected a gate test for the feature 'const_transmute'.
[00:04:45] Hint: create a failing test file named 'feature-gate-const_transmute.rs'
[00:04:45]       in the 'ui' test suite, with its failures due to
[00:04:45]       missing usage of #![feature(const_transmute)].
[00:04:45] Hint: If you already have such a test and don't want to rename it,
[00:04:45]       you can also add a // gate-test-const_transmute line to the test file.
[00:04:45] tidy error: Found 1 features without a gate test.
[00:04:45] tidy error: libsyntax/feature_gate.rs:225: no tracking issue for feature const_transmute
[00:04:45] some tidy checks failed
[00:04:45] 
[00:04:45] 
[00:04:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:45] 
[00:04:45] 
[00:04:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:45] Build completed unsuccessfully in 0:00:53
[00:04:45] Build completed unsuccessfully in 0:00:53
[00:04:45] Makefile:79: recipe for target 'tidy' failed
[00:04:45] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0261126c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:044b36bf:start=1534884540033777515,finish=1534884540039846810,duration=6069295
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0186be64
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:211d1fac
travis_time:start:211d1fac
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:22bb6c60
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-08-22T14:49:40Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:14:13]    Compiling rustc_metadata_utils v0.0.0 (file:///checkout/src/librustc_metadata_utils)
[00:14:13]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:14:13]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:14:13]    Compiling rustc_allocator v0.0.0 (file:///checkout/src/librustc_allocator)
[00:14:26] error[E0599]: no method named `write_value_to_ptr` found for type `&mut interpret::eval_context::EvalContext<'a, 'mir, 'tcx, interpret::const_eval::CompileTimeEvaluator>` in the current scope
[00:14:26]    --> librustc_mir/interpret/const_eval.rs:350:21
[00:14:26]     |
[00:14:26] 350 |                 ecx.write_value_to_ptr(args[0].value, ptr.into(), dest_align, src_ty).unwrap();
[00:14:26] 
[00:14:26] error[E0609]: no field `value` on type `interpret::operand::OpTy<'tcx>`
[00:14:26]    --> librustc_mir/interpret/const_eval.rs:350:48
[00:14:26]     |
[00:14:26]     |
[00:14:26] 350 |                 ecx.write_value_to_ptr(args[0].value, ptr.into(), dest_align, src_ty).unwrap();
[00:14:26]     |
[00:14:26]     |
[00:14:26]     = note: available fields are: `op`, `layout`
[00:14:27] error: aborting due to 2 previous errors
[00:14:27] 
[00:14:27] Some errors occurred: E0599, E0609.
[00:14:27] For more information about an error, try `rustc --explain E0599`.
[00:14:27] For more information about an error, try `rustc --explain E0599`.
[00:14:27] error: Could not compile `rustc_mir`.
[00:14:27] 
[00:14:27] Caused by:
[00:14:27]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=0d31b3db998f4b07 -C extra-filename=-0d31b3db998f4b07 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-b8f9e6fb5ae336d7.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-3907cba388d41ef0.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-8246be02936c9b1b.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-0a515e87c8afea9e.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-45ae4394366d07fd.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-b6c566856a1e65b9.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-f501f9d595863bbf.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-c6e8cf18dad58451.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-3a367afe0d047d15.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-165c205e2819b15f.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-8b624a6d6082b2ff.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-89eed8215142aadd.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-20eb47b9c402fee3.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8c9bc9ee6cc9592f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8c9bc9ee6cc9592f.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-64bbe8e4870170a3.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-3b51f50aecba154c.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-6c2cab36846647d7/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-3c585aa15bfc4e69/out` (exit code: 1)
time:start:296021cb
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:296021cb:start=1534949376934774870,finish=1534949376941892415,duration=7117545
---
travis_time:end:08a06fd8:start=1534949376948587839,finish=1534949376955788214,duration=7200375
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:32141708
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1b03a9b5
travis_time:start:1b03a9b5
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers ||

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-08-22T16:01:10Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:47:29] ..............ii.iii................................................................................
[00:47:31] ....................................................................................................
[00:47:33] ....................................................................................................
[00:47:36] ....................................................................................................
[00:47:38] ...................................................................................F................
[00:47:44] ...i...................................................................i............................
[00:47:47] ....................................................................................................
[00:47:50] ....................................................................................................
[00:47:52] ..................................................i.................................................
---
[00:48:51] ....................................................................................................
[00:48:55] .....................................................i..............................................
[00:48:59] ....................................................................................................
[00:49:04] ................................................................................................i...
/rfcs/blob/master/text/0911-const-fn.md\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/feature-gates/feature-gate-const_transmute.rs","byte_start":558,"byte_end":580,"line_start":16,"line_end":16,"column_start":38,"column_end":60,"is_primary":true,"text":[{"text":"const TRANSMUTED_U32: u32 = unsafe { mem::transmute(Foo(3)) };","highlight_start":38,"highlight_end":60}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants\n  --> /checkout/src/test/ui/feature-gates/feature-gate-const_transmute.rs:16:38\n   |\nLL | const TRANSMUTED_U32: u32 = unsafe { mem::transmute(Foo(3)) };\n   |                                      ^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:49:06] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:49:06] {"message":"Some errors occurred: E0015, E0658.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0015, E0658.\n"}
[00:49:06] {"message":"For more information about an error, try `rustc --explain E0015`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about an error, try `rustc --explain E0015`.\n"}
[00:49:06] ------------------------------------------
[00:49:06] 
[00:49:06] thread '[ui] ui/feature-gates/feature-gate-const_transmute.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3189:9
[00:49:06] note: Run with `RUST_BACK

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-08-24T11:25:32Z

src/librustc_mir/transform/qualify_consts.rs

weird indent

oli-obk · 2018-08-24T11:28:45Z

src/test/ui/feature-gates/feature-gate-const_transmute.stderr

hmm... this error duplication isn't too great. Maybe unconditionally do is_const_fn = Some(def_id), so in case we emit the feature gate error, the rest of the code happily treats transmute as const fn (which doesn't matter, because we already emitted an error)

oli-obk · 2018-08-24T11:29:35Z

src/test/ui/consts/const-eval/transmute-const.rs

can you also add a test that checks that static FOO: bool = unsafe { mem::transmute(3) }; is an error?

The test exists now but it fails saying the sizes are wrong.

Likely you meant mem::transmute(3u8)?

I'm slightly confused, because I built it on my box and it passes, as does the travis build.

rust-highfive · 2018-08-24T18:18:09Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:47:26] ................................................................i...i................ii.............
[00:47:28] ..................................................................................iii...............
[00:47:31] .....................................................................i..........i...................
[00:47:34] .......i............................................................................................
[00:47:39] ...............................................................F...................................i
[00:47:45] .............ii.iii.................................................................................
[00:47:48] ....................................................................................................
[00:47:50] ....................................................................................................
[00:47:52] ....................................................................................................
---
[00:48:11] ....................................................................................................
[00:48:14] ....................................................................................................
[00:48:17] ............i.......................................................................................
[00:48:20] ....................................................................................................
[00:48:22] .............................................................iiiiiiiii..............................
[00:48:27] ....................................................................................................
[00:48:31] ....................................................................................................
[00:48:34] ..........................................i.........................................................
[00:48:37] ............................................................................................i.i..ii.
---
[00:49:17] ---- [ui (nll)] ui/consts/const-eval/transmute-const-promotion.rs stdout ----
[00:49:17] 
[00:49:17] error: ui test compiled successfully!
[00:49:17] status: exit code: 0
[00:49:17] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/transmute-const-promotion.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/transmute-const-promotion.nll/a" "-Zborrowck=mir" "-Ztwo-phase-borrows" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/transmute-const-promotion.nll/auxiliary" "-A" "unused"
[00:49:17] ------------------------------------------
[00:49:17] 
[00:49:17] ------------------------------------------
[00:49:17] stderr:
---
[00:49:17] 
[00:49:17] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:497:22
[00:49:17] 
[00:49:17] 
[00:49:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcfl

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-08-25T06:51:15Z

src/librustc_mir/transform/qualify_consts.rs

this needs to happen inside the mode != Fn, otherwise we are promoting transmute (treating anything as const inside Fn makes it immediately promotable)

still needs to be outside the feature gate check in order to have the better diagnostic

bors · 2018-08-29T02:13:54Z

☔ The latest upstream changes (presumably #53671) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2018-08-29T08:23:33Z

When this lands, please also open an issue (or, better, a PR :D ) against miri to remove the transmute implementation there.

tbu- · 2018-08-29T13:53:10Z

What is the motivation for this change?

Using mem::transmute in const fn (i.e. evaluated at compile-time) sounds like it could break some stuff, e.g. cross-compilation, if this isn't implemented correctly. Suppose you have const MAYBE_ONE: i32 = std::mem::transmute([1, 0, 0, 0]);. Is that evaluated with host or target semantics, is the resulting constant 1 or 16777216 (0x01000000)?

oli-obk · 2018-08-29T14:10:13Z

The motivation is that there's no reason not to do it. you can already emulate this with unions on nightly. all this PR does is to allow doing suchconversions with transmute.

Miri evaluates everything in the target's platform, so the endianess, pointer size and alignment oddities of the target platform is observable, completely ignoring the platform you are compiling on. I think you only run into trouble with the host when you go beyond the host's limits, e.g. [0u8; 1 << 32] on a 32 bit host for a 64 bit target is likely to not work

tbu- · 2018-08-29T14:25:35Z

Miri evaluates everything in the target's platform, so the endianess, pointer size and alignment oddities of the target platform is observable, completely ignoring the platform you are compiling on. I think you only run into trouble with the host when you go beyond the host's limits, e.g. [0u8; 1 << 32] on a 32 bit host for a 64 bit target is likely to not work

Ah, thanks, that is reassuring. Ignore my comment. :)

oli-obk · 2018-08-30T06:16:29Z

src/test/ui/consts/const-eval/transmute-const.rs

Your test is passing because you are testing for the type size error message instead of the UB message

oli-obk · 2018-08-30T13:53:17Z

@bors r+

bors · 2018-08-30T13:53:18Z

📌 Commit c5cae79 has been approved by oli-obk

bors · 2018-08-30T14:18:29Z

⌛ Testing commit c5cae79 with merge 685fb54...

@oli-obk

Made std::intrinsics::transmute() const fn. r? @oli-obk tracking issue: #53605

bors · 2018-08-30T17:29:07Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 685fb54 to master...

rust-highfive assigned oli-obk Aug 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2018

TheDarkula force-pushed the master branch from 020c2d7 to 54f71ac Compare August 20, 2018 21:30

oli-obk requested changes Aug 21, 2018

View reviewed changes

TheDarkula force-pushed the master branch from 54f71ac to 7b38f74 Compare August 21, 2018 20:41

TheDarkula force-pushed the master branch from 7b38f74 to 5128c31 Compare August 22, 2018 14:31

TheDarkula force-pushed the master branch from 5128c31 to d6d56d1 Compare August 22, 2018 15:10

TheDarkula force-pushed the master branch from d6d56d1 to 197bb27 Compare August 22, 2018 18:34

oli-obk requested changes Aug 24, 2018

View reviewed changes

TheDarkula force-pushed the master branch from 197bb27 to 19ea266 Compare August 24, 2018 17:26

oli-obk reviewed Aug 25, 2018

View reviewed changes

TheDarkula force-pushed the master branch from 19ea266 to d15c3db Compare August 25, 2018 13:19

TimDiekmann mentioned this pull request Aug 25, 2018

Add more const int ops #53697

Merged

oli-obk approved these changes Aug 26, 2018

View reviewed changes

TheDarkula force-pushed the master branch 2 times, most recently from 6d8f885 to 3409be9 Compare August 29, 2018 21:06

oli-obk reviewed Aug 30, 2018

View reviewed changes

Made std::intrinsics::transmute() const fn.

c5cae79

TheDarkula force-pushed the master branch from 3409be9 to c5cae79 Compare August 30, 2018 12:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2018

bors added a commit that referenced this pull request Aug 30, 2018

Auto merge of #53535 - TheDarkula:master, r=oli-obk

685fb54

Made std::intrinsics::transmute() const fn. r? @oli-obk tracking issue: #53605

bors merged commit c5cae79 into rust-lang:master Aug 30, 2018

bors mentioned this pull request Aug 30, 2018

Implement the min_const_fn feature gate #53604

Merged

oli-obk mentioned this pull request Oct 2, 2018

mem::transmute should be a const fn. #49450

Closed

burrbull mentioned this pull request Feb 9, 2019

Tracking issue for #![feature(const_fn_floating_point_arithmetic)] #57241

Closed

Uh oh!

Conversation

TheDarkula commented Aug 20, 2018 • edited by oli-obk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Aug 20, 2018

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Aug 21, 2018

Uh oh!

rust-highfive commented Aug 22, 2018

Uh oh!

rust-highfive commented Aug 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Aug 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 29, 2018

Uh oh!

RalfJung commented Aug 29, 2018

Uh oh!

tbu- commented Aug 29, 2018

Uh oh!

oli-obk commented Aug 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbu- commented Aug 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

TheDarkula commented Aug 20, 2018 •

edited by oli-obk

Loading

RalfJung Aug 29, 2018 •

edited

Loading

oli-obk commented Aug 29, 2018 •

edited

Loading