[WIP] migrate more of src/test/run-pass to src/test/ui/run-pass#54139
Closed
pnkfelix wants to merge 7 commits intorust-lang:masterfrom
Closed
[WIP] migrate more of src/test/run-pass to src/test/ui/run-pass#54139pnkfelix wants to merge 7 commits intorust-lang:masterfrom
pnkfelix wants to merge 7 commits intorust-lang:masterfrom
Conversation
…test/ui/run-pass/*/` These are cases where I feel reasonably confident that I chose a "good" target subdirectory for the file.
…i/run-pass/*.rs` A followup task would be to categorize all of these files and move them into appropriate subdirectories. But I reached a point where I stopped being able to do trivial categorizations, and I decided it was better to focus on the main goal (which is to get compare-mode=nll testing of all the run-pass test suite). --- Also, as a special case, I discovered that lexer-crlf-line-endings-string-literal-doc-comment.rs test needs special `.gitattributes` to be ported over.
pnkfelix
force-pushed
the
issue-53764-migrate-run-pass-more-root-files-to-ui
branch
from
20576e8 to
6c5fe50
Compare
Contributor
pnkfelix
changed the title
Contributor
Author
|
marking as WIP until T-compiler decides how we are going to resolve #54047 |
Member
pnkfelix
added
the
T-compiler
Collaborator
|
☔ The latest upstream changes (presumably #54146) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Discussed at compiler team meeting. Long term we will probably adopt some test layout that puts everything in a place that acts like But short term I am going to move stuff back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be enough to consider marking #53764 as closed