Rollup of 10 pull requests

[kennytm]

Successful merges:

• Add doc for impl From for Std Error #53523 (Add doc for impl From for Std Error)
• Add checking for tool distribution in Tier 1 #54638 (Add checking for tool distribution in Tier 1)
• [NFC] getopts is used by librustc and librustc_driver, but isn't declared in their Cargo.toml. #54698 ([NFC] getopts is used by librustc and librustc_driver, but isn't declared in their Cargo.toml.)
• Cleanup rustc/ty part 2 #54743 (Cleanup rustc/ty part 2)
• Make spec_extend use for_each() #54761 (Make spec_extend use for_each())
• Run debuginfo tests against rust-enabled lldb, when possible #54764 (Run debuginfo tests against rust-enabled lldb, when possible)
• Fix typo in CONTRIBUTING.md #54769 (Fix typo in CONTRIBUTING.md)
• Update a FIXME in memory.rs #54773 (Update a FIXME in memory.rs)
• Update clippy #54784 (Update clippy)
• A handful of cleanups for rustc/mir #54788 (A handful of cleanups for rustc/mir)

Failed merges:

r? @ghost

[kennytm]

@bors r+ p=10

[bors]

📌 Commit 94508ca has been approved by kennytm

[bors]

⌛ Testing commit 94508ca with merge c629af2bff8abd6b2e58e7fdba25a894de207288...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:07:34] [RUSTC-TIMING] syntax test:false 61.913
[00:07:34]    Compiling proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:07:42] [RUSTC-TIMING] proc_macro test:false 8.134
[00:07:42]    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[00:07:42] error[E0523]: found two different crates with name `getopts` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
[00:07:42]     |
[00:07:42] 119 | extern crate test;
[00:07:42]     | ^^^^^^^^^^^^^^^^^^
[00:07:42] 
---
[00:07:58] [RUSTC-TIMING] syntax_ext test:false 15.992
[00:07:58] error: build failed
[00:07:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:07:58] expected success, got: exit code: 101
[00:07:58] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1112:9
[00:07:58] travis_fold:end:stage0-rustc

[00:07:58] travis_time:end:stage0-rustc:start=1538585624347499190,finish=1538585762699240976,duration=138351741786

---
travis_time:end:0b3a71a6:start=1538585763397753282,finish=1538585763407501091,duration=9747809
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2d41eef0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0659d2d0
$ cat ./obj/build/x86_64-unknown-lin

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)