Skip to content

Comments

experiment: Support aliasing local crate root in extern prelude#55275

Merged
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:extself
Dec 1, 2018
Merged

experiment: Support aliasing local crate root in extern prelude#55275
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:extself

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Oct 22, 2018 •
edited
Loading

This PR provides some minimally invasive solution for the 2018 edition migration issue described in #54647 and affecting proc macro crates.

extern crate NAME as RENAME; now accepts NAME=self and interprets it as referring to the local crate.
As with other extern crate items, RENAME in this case gets into extern prelude in accordance with #54658, thus resolving #54647.

extern crate self as serde; // Adds local crate to extern prelude as `serde`

This solution doesn't introduce any new syntax and has minimal maintenance cost, so it can be easily deprecated if something better is found in the future.

Closes #54647

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 22, 2018

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2018
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Oct 22, 2018

cc @rust-lang/lang

@petrochenkov petrochenkov added T-lang Relevant to the language team S-waiting-on-team F-rust_2018_preview `#![feature(rust_2018_preview)]` and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2018
@petrochenkov petrochenkov mentioned this pull request Oct 22, 2018
Closed
@Centril
Copy link
Contributor

Centril commented Oct 22, 2018

Seems fine by me (but I can't speak for everyone in the team).
The syntax=>semantics are fairly obvious and it seems like a nice reuse of the syntax that we have.

@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 23, 2018

r? @eddyb maybe? I know too little about name resolution.

@bors
Copy link
Collaborator

bors commented Oct 25, 2018

☔ The latest upstream changes (presumably #54658) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Oct 28, 2018

☔ The latest upstream changes (presumably #54683) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member

eddyb commented Nov 3, 2018

Implementation LGTM.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Nov 3, 2018 •
edited by scottmcm
Loading

Team member @eddyb has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 3, 2018
@bors
Copy link
Collaborator

bors commented Nov 21, 2018

☔ The latest upstream changes (presumably #56032) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis nikomatsakis added this to the Rust 2018 Release milestone Nov 21, 2018
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 21, 2018

(Tagged @pnkfelix as they are on PTO)

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 21, 2018
@rfcbot
Copy link

rfcbot commented Nov 21, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@nikomatsakis nikomatsakis removed this from the Rust 2018 Release milestone Nov 21, 2018
@rfcbot
Copy link

rfcbot commented Dec 1, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 1, 2018
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Dec 1, 2018

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Dec 1, 2018

📌 Commit 549bd45 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Dec 1, 2018
@bors
Copy link
Collaborator

bors commented Dec 1, 2018

⌛ Testing commit 549bd45 with merge d311571...

bors added a commit that referenced this pull request Dec 1, 2018
@bors
Auto merge of #55275 - petrochenkov:extself, r=eddyb
d311571 
experiment: Support aliasing local crate root in extern prelude

This PR provides some minimally invasive solution for the 2018 edition migration issue described in #54647 and affecting proc macro crates.

`extern crate NAME as RENAME;` now accepts `NAME`=`self` and interprets it as referring to the local crate.
As with other `extern crate` items, `RENAME` in this case gets into extern prelude in accordance with #54658, thus resolving #54647.
```rust
extern crate self as serde; // Adds local crate to extern prelude as `serde`
```
This solution doesn't introduce any new syntax and has minimal maintenance cost, so it can be easily deprecated if something better is found in the future.

Closes #54647
@Centril
Copy link
Contributor

Centril commented Dec 1, 2018

@petrochenkov Hmm; If we are adding the unstable feature extern_crate_self, where's the tracking issue? =P (I thought we were doing it on 1.32...?)

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Dec 1, 2018 •
edited
Loading

I'll add it today (maybe in this PR if checkin fails).

UPDATE: Done in #56412.

@petrochenkov petrochenkov mentioned this pull request Dec 1, 2018
Closed
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Dec 1, 2018

Tracking issue: #56409.

@bors
Copy link
Collaborator

bors commented Dec 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d311571 to master...

@bors bors merged commit 549bd45 into rust-lang:master Dec 1, 2018
@bors bors mentioned this pull request Dec 1, 2018
Merged
This was referenced Jan 9, 2019
Closed
Merged
@freesig freesig mentioned this pull request May 22, 2019
Closed
dhardy added a commit to kas-gui/kas that referenced this pull request Oct 25, 2019
@dhardy
Use prefered solution for local crate references from procedural macros
5b7af83 
rust-lang/rust#55275
artob added a commit to artob/protoflow that referenced this pull request Jul 28, 2024
@artob
Alias the crate into the extern prelude.
e6afaa6 
See: rust-lang/rust#54647
See: rust-lang/rust#55275
artob added a commit to artob/protoflow that referenced this pull request Aug 19, 2024
@artob
Alias the crate into the extern prelude.
db8b43c 
See: rust-lang/rust#54647
See: rust-lang/rust#55275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eddyb eddyb

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. F-rust_2018_preview `#![feature(rust_2018_preview)]` finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@petrochenkov @rust-highfive @Centril @michaelwoerister @bors @eddyb @rfcbot @nikomatsakis