Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
steveklabnik
added
the
beta-nominated
Mark-Simulacrum
added
the
beta-accepted
Member
|
cc @rust-lang/release @pietroalbini -- can someone prepare the beta backport for this? @bors r+ p=1 |
Collaborator
|
📌 Commit 934871a has been approved by |
bors
added
S-waiting-on-bors
Member
|
I'll prepare the backport in a few hours max. |
Contributor
Author
|
Let me know if you need any help! |
Contributor
Author
|
I currently cannot build rust (see #56291 (comment)) and so I didn't run linkchecker yet; i'll be watching travis closely. sorry about that! |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 30, 2018
…imulacrum Update books This pulls in @gankro 's final nomicon changes, and adds the edition guide as a submodule. This is the final doc backport to beta for 1.31, as well.
Contributor
Author
|
passed! woot! |
emilyalbini
removed
the
beta-nominated
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 30, 2018
…imulacrum Update books This pulls in @gankro 's final nomicon changes, and adds the edition guide as a submodule. This is the final doc backport to beta for 1.31, as well.
bors
added a commit
that referenced
this pull request
Nov 30, 2018
Rollup of 19 pull requests Successful merges: - #55011 (Add libstd Cargo feature "panic_immediate_abort") - #55821 (Use sort_by_cached_key when the key function is not trivial/free) - #56014 (add test for issue #21335) - #56131 (Assorted tweaks) - #56214 (Implement chalk unification routines) - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy) - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.) - #56324 (Use raw_entry for more efficient interning) - #56336 (Clean up and streamline the pretty-printer) - #56337 (Fix const_fn ICE with non-const function pointer) - #56339 (Remove not used option) - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.) - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker) - #56355 (Add inline attributes and add unit to CommonTypes) - #56360 (Optimize local linkchecker program) - #56364 (Fix panic with outlives in existential type) - #56365 (Stabilize self_struct_ctor feature.) - #56367 (Moved some feature gate tests to correct location) - #56373 (Update books)
Collaborator
bors
added a commit
that referenced
this pull request
Dec 1, 2018
[beta] Rollup backports Approved for backport: * #56373: Update books r? @ghost cc @Mark-Simulacrum @steveklabnik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in @gankro 's final nomicon changes, and adds the edition guide as a submodule.
This is the final doc backport to beta for 1.31, as well.