[WIP] Place unroll -> iterate refactor#58819
[WIP] Place unroll -> iterate refactor#58819spastorino wants to merge 4 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
| /// Iterator over components; see `PlaceProjections::iter` for more | ||
| /// information. | ||
| /// | ||
| /// N.B., this is not a *true* Rust iterator -- the code above just |
There was a problem hiding this comment.
What we could do is make it a real iterator and also implement https://doc.rust-lang.org/std/iter/trait.FusedIterator.html for that iterator. This way we guarantee that after the first None we keep getting Nones.
|
@spastorino this looks like a good intermediate step that we could merge before any further changes. |
|
ping from triage @oli-obk any updates? |
oli-obk
added
S-waiting-on-author
|
@Dylan-DPC I'm the one "working" on this. This is still in WIP, we need to land some stuff before. I'm slowly catching up with stuff but have been very busy. |
|
thanks. I thought some part of the review was pending. Great :) |
|
☔ The latest upstream changes (presumably #59433) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping from triage, @spastorino What other stuff is this blocked on? what PRs if any? |
|
@Centril blocked on https://rustlatam.org 😂. Now that the thing have finished I'm back to work on |
|
Going to close this for now and reopen after I change |
6 participants
Do not merge this is work in progress.
r? @oli-obk