Use a more lightweight cache for erase_regions by Zoxc · Pull Request #59505 · rust-lang/rust

Zoxc · 2019-03-28T19:28:40Z

No description provided.

rust-highfive · 2019-03-28T19:28:50Z

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

Zoxc · 2019-03-28T19:31:24Z

@bors try

bors · 2019-03-28T19:31:35Z

⌛ Trying commit 6b6cb87e9137e5d593e0f42b9af92a135e9e38f7 with merge 6400173020be5019c2bbcadabcabd413750de993...

rust-highfive · 2019-03-28T20:54:28Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:055d534f:start=1553804803168014353,finish=1553804804075804180,duration=907789827
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:27:25]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:27:26]    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:27:26]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:27:27]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:27:28] thread 'rustc' panicked at 'already borrowed: BorrowMutError', src/libcore/result.rs:997:5
[00:27:28] 
[00:27:28] error: internal compiler error: unexpected panic
[00:27:28] 
[00:27:28] note: the compiler unexpectedly panicked. this is a bug.
[00:27:28] note: the compiler unexpectedly panicked. this is a bug.
[00:27:28] 
[00:27:28] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:27:28] 
[00:27:28] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[00:27:28] 
[00:27:28] note: compiler flags: -Z external-macro-backtrace -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:27:28] note: some of the compiler flags provided by cargo are hidden
[00:27:28] 
[00:27:28] error: Could not compile `core`.
[00:27:28] warning: build failed, waiting for other jobs to finish...

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-03-28T21:17:30Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-28T21:17:31Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:083c56c4
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:49:22]    Compiling cmake v0.1.33
[00:49:22]    Compiling backtrace-sys v0.1.27
[00:49:25]    Compiling profiler_builtins v0.0.0 (/checkout/src/libprofiler_builtins)
[00:49:25]    Compiling std v0.0.0 (/checkout/src/libstd)
[00:49:26] thread 'rustc' panicked at 'already borrowed: BorrowMutError', src/libcore/result.rs:997:5
[00:49:26] 
[00:49:26] error: internal compiler error: unexpected panic
[00:49:26] 
[00:49:26] note: the compiler unexpectedly panicked. this is a bug.
[00:49:26] note: the compiler unexpectedly panicked. this is a bug.
[00:49:26] 
[00:49:26] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:49:26] 
[00:49:26] note: rustc 1.35.0-nightly (640017302 2019-03-28) running on x86_64-unknown-linux-gnu
[00:49:26] 
[00:49:26] note: compiler flags: -Z external-macro-backtrace -Z save-analysis -Z force-unstable-if-unmarked -C opt-level=2 -C linker=clang -C prefer-dynamic -C linker=clang -C debuginfo=1 -C debug-assertions=n -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:49:26] note: some of the compiler flags provided by cargo are hidden
[00:49:26] 
[00:49:27] error: Could not compile `core`.
[00:49:27] warning: build failed, waiting for other jobs to finish...
---
travis_time:end:0efffd3f:start=1553807847387479696,finish=1553807847402592018,duration=15112322
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:14647747
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0081a10f
travis_time:start:0081a10f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:27a67a1e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc · 2019-03-28T22:13:37Z

@bors try

bors · 2019-03-28T22:13:48Z

⌛ Trying commit d633fd98da7acf14eee5e4339b8909e986580687 with merge 6284bc1b5909f6452af037b507190bbabb1a4d4d...

rust-highfive · 2019-03-28T23:12:36Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0a477c14:start=1553810422609730461,finish=1553810423505501599,duration=895771138
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:08:58] ..........................................i......................................................... 600/5501
[01:09:02] .................................................................................................... 700/5501
[01:09:07] .................................................................................................... 800/5501
[01:09:11] .................................................................................................... 900/5501
[01:09:16] .i...............i.....FFFFFFF.F.................................................................... 1000/5501
[01:09:19] .................................iiiii.............................................................. 1100/5501
[01:09:24] .................................................................................................... 1300/5501
[01:09:27] .................................................................................................... 1400/5501
[01:09:30] .................................................................................................... 1500/5501
[01:09:33] .................................................................................................... 1600/5501
---
[01:11:56] failures:
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-assoc-type-codegen.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-assoc-type-codegen.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-assoc-type-codegen/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-assoc-type-codegen/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-assoc-type-codegen.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-assoc-type-codegen.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-caller-callee.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-caller-callee.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-caller-callee/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-caller-callee/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-caller-callee.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-caller-callee.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-struct-signature.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-struct-signature.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-struct-signature/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-struct-signature/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-struct-signature.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-struct-signature.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-trait-impl-two-traits-same-method.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-trait-impl-two-traits-same-method.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl-two-traits-same-method/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl-two-traits-same-method/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl-two-traits-same-method.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl-two-traits-same-method.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-trait-impl-two-traits.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-trait-impl-two-traits.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl-two-traits/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl-two-traits/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl-two-traits.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl-two-traits.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-trait-impl.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-trait-impl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-trait-impl/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-trait-impl.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-type-alias.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-type-alias.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-type-alias/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-type-alias/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-type-alias.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-type-alias.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
[01:11:56] 
[01:11:56] ---- [ui] ui/dep-graph/dep-graph-variance-alias.rs stdout ----
[01:11:56] 
[01:11:56] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:11:56] status: exit code: 101
[01:11:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-variance-alias.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-variance-alias/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-variance-alias/auxiliary" "-A" "unused"
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] stderr:
[01:11:56] stderr:
[01:11:56] ------------------------------------------
[01:11:56] thread 'rustc' panicked at 'assertion failed: task_deps.into_inner().reads.is_empty()', src/librustc/dep_graph/graph.rs:160:17
[01:11:56] 
[01:11:56] error: internal compiler error: unexpected panic
[01:11:56] 
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] note: the compiler unexpectedly panicked. this is a bug.
[01:11:56] 
[01:11:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:11:56] 
[01:11:56] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:11:56] 
[01:11:56] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -Z query-dep-graph -C prefer-dynamic -C rpath
[01:11:56] 
[01:11:56] ------------------------------------------
[01:11:56] 
[01:11:56] thread '[ui] ui/dep-graph/dep-graph-variance-alias.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3369:9
---
[01:11:56] 
[01:11:56] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:11:56] 
[01:11:56] 
[01:11:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:11:56] 
[01:11:56] 
[01:11:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:11:56] Build completed unsuccessfully in 0:04:14
[01:11:56] Build completed unsuccessfully in 0:04:14
[01:11:56] Makefile:48: recipe for target 'check' failed
[01:11:56] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1d0bdb74
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Mar 28 23:12:31 UTC 2019
---
travis_time:end:12477bde:start=1553814752739243955,finish=1553814752746414098,duration=7170143
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:020f1e28
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:239dbf76
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc · 2019-03-29T00:27:18Z

@rust-timer build 6284bc1b5909f6452af037b507190bbabb1a4d4d

rust-timer · 2019-03-29T00:27:20Z

Success: Queued 6284bc1b5909f6452af037b507190bbabb1a4d4d with parent 237bf32, comparison URL.

bors · 2019-03-29T00:28:13Z

☀️ Try build successful - checks-travis
Build commit: 6284bc1b5909f6452af037b507190bbabb1a4d4d

rust-timer · 2019-03-29T03:08:22Z

Finished benchmarking try commit 6284bc1b5909f6452af037b507190bbabb1a4d4d

rust-highfive · 2019-03-29T05:04:55Z

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:00e7e7de:start=1553829142514754549,finish=1553829144591295246,duration=2076540697
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:04:42]     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
[00:05:06]     Checking syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[00:05:07]    Compiling synstructure v0.10.1
[00:05:20]    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
[00:05:36] error[E0609]: no field `no_deps` on type `lock_api::mutex::MutexGuard<'_, parking_lot::raw_mutex::RawMutex, dep_graph::graph::TaskDeps>`
[00:05:36]     --> src/librustc/dep_graph/graph.rs:1128:56
[00:05:36]      |
[00:05:36] 1128 |                 if cfg!(debug_assertions) && task_deps.no_deps {
[00:05:36] 
[00:05:50] error: aborting due to previous error
[00:05:50] 
[00:05:50] For more information about this error, try `rustc --explain E0609`.
---
travis_time:end:03b40d08:start=1553829507610929519,finish=1553829507616913933,duration=5984414
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:18b50759
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0bf191cb
travis_time:start:0bf191cb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:04ceaa5b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

michaelwoerister · 2019-04-01T13:12:50Z

I'd like to enable caches for dependency-less functions like this one but I'm not sure a debug assertion is enough. Can we instead of make sure at compile time that a function cannot have dependencies? One way to do that would be to not give it access to the tcx in the first place. From the looks of it, erasing types (and probably quite a few other things like it) only needs access to interners. Maybe we could split out a subset of the context that can do nothing expect for allocating stuff. That would be a safe and generic extension of the query system that might help performance in quite a few places. I'd prefer that to one-off solutions with manual checking.

Zoxc · 2019-04-01T22:11:56Z

Can we instead of make sure at compile time that a function cannot have dependencies?

I don't see how, given that we allow access to TyCtxt in TLS. The debug-only dependency fixed in this PR doesn't have a tcx for example.

michaelwoerister · 2019-04-02T09:01:49Z

I don't see how, given that we allow access to TyCtxt in TLS. The debug-only dependency fixed in this PR doesn't have a tcx for example.

Yeah, that's true :(

It would still be good to turn this into a generic, sanctioned pattern with safe-guards against foot gunning ourselves. Maybe:

Allow a way of defining a dependency-less query where the provider only gets access to a restricted version of the tcx (e.g. just interners). That already gives a good indication that one should not use the tcx.
Keep the debug-only runtime check from this PR in place for such queries.
Add documentation to the rustc-guide of what these queries are and why they work the way they work.

The tcx would still be accessible through TLS at least we'd have documentation and a clear template that people can use without having to remember that they need to do their checking and what they are allowed to do and what not.

cc @nikomatsakis, who (I think) mentioned wanting to support dependenciless functions in Salsa too.

bors · 2019-04-04T11:20:07Z

☔ The latest upstream changes (presumably #59517) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2019-04-14T13:52:42Z

This is also the only thing using anon queries, which I'd also like to remove since it doesn't make sense to me.

michaelwoerister · 2019-04-24T11:48:52Z

As I said, I'm not against doing something like this in principle. But this isn't a pressing issue (i.e. the current solution works and performance improvement nice but not stellar), so I'd prefer if we supported this pattern in a general way (along the lines I described above) instead of doing a one-off solution.

Dylan-DPC-zz · 2019-05-13T19:15:00Z

ping from triage @michaelwoerister any updates on this?

michaelwoerister · 2019-05-23T09:46:28Z

re: triage: My suggestions on how to move forward here are still up-to-date.

Use a more lightweight cache for `erase_regions` This changes `erase_regions` to use a global hashmap instead of a query to cache types with erased lifetimes. `erase_regions_ty` only depends on the input parameter so it doesn't need to be a query. This is a rebase of rust-lang#59505. <table><tr><td rowspan="2">Benchmark</td><td colspan="1">Before</th><td colspan="2">After</th><td colspan="1">Before</th><td colspan="2">After</th><td colspan="1">Before</th><td colspan="2">After</th></tr><tr><td align="right">Time</td><td align="right">Time</td><td align="right">%</th><td align="right">Physical Memory</td><td align="right">Physical Memory</td><td align="right">%</th><td align="right">Committed Memory</td><td align="right">Committed Memory</td><td align="right">%</th></tr><tr><td>🟣 clap:check</td><td align="right">1.3960s</td><td align="right">1.3883s</td><td align="right"> -0.55%</td><td align="right">147.66 MiB</td><td align="right">147.76 MiB</td><td align="right"> 0.07%</td><td align="right">199.83 MiB</td><td align="right">199.86 MiB</td><td align="right"> 0.01%</td></tr><tr><td>🟣 hyper:check</td><td align="right">0.2346s</td><td align="right">0.2337s</td><td align="right"> -0.38%</td><td align="right">80.35 MiB</td><td align="right">80.54 MiB</td><td align="right"> 0.24%</td><td align="right">129.99 MiB</td><td align="right">130.12 MiB</td><td align="right"> 0.10%</td></tr><tr><td>🟣 regex:check</td><td align="right">0.7811s</td><td align="right">0.7788s</td><td align="right"> -0.30%</td><td align="right">107.75 MiB</td><td align="right">108.07 MiB</td><td align="right"> 0.29%</td><td align="right">153.67 MiB</td><td align="right">153.99 MiB</td><td align="right"> 0.21%</td></tr><tr><td>🟣 syn:check</td><td align="right">1.2999s</td><td align="right">1.2978s</td><td align="right"> -0.17%</td><td align="right">140.24 MiB</td><td align="right">140.35 MiB</td><td align="right"> 0.08%</td><td align="right">188.59 MiB</td><td align="right">188.58 MiB</td><td align="right"> -0.01%</td></tr><tr><td>Total</td><td align="right">3.7117s</td><td align="right">3.6986s</td><td align="right"> -0.35%</td><td align="right">476.00 MiB</td><td align="right">476.72 MiB</td><td align="right"> 0.15%</td><td align="right">672.08 MiB</td><td align="right">672.55 MiB</td><td align="right"> 0.07%</td></tr><tr><td>Summary</td><td align="right">1.0000s</td><td align="right">0.9965s</td><td align="right"> -0.35%</td><td align="right">1 byte</td><td align="right">1.00 bytes</td><td align="right"> 0.17%</td><td align="right">1 byte</td><td align="right">1.00 bytes</td><td align="right"> 0.08%</td></tr></table>

rust-highfive assigned michaelwoerister Mar 28, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2019

Zoxc force-pushed the erase_regions_ty branch from 6b6cb87 to d633fd9 Compare March 28, 2019 21:59

Zoxc force-pushed the erase_regions_ty branch from d633fd9 to 4117c7c Compare March 29, 2019 03:10

Use a more lightweight cache for erase_regions

b72ca1e

Zoxc force-pushed the erase_regions_ty branch from 4117c7c to b72ca1e Compare March 29, 2019 05:08

michaelwoerister mentioned this pull request Apr 26, 2019

Make erase_regions_ty no_hash and remove support for anon queries #59968

Closed

michaelwoerister removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2019

Zoxc closed this May 23, 2019

Zoxc mentioned this pull request Apr 2, 2025

Use a more lightweight cache for erase_regions #139240

Closed

Uh oh!

Conversation

Zoxc commented Mar 28, 2019

Uh oh!

rust-highfive commented Mar 28, 2019

Uh oh!

Zoxc commented Mar 28, 2019

Uh oh!

bors commented Mar 28, 2019

Uh oh!

rust-highfive commented Mar 28, 2019

Uh oh!

bors commented Mar 28, 2019

Uh oh!

rust-highfive commented Mar 28, 2019

Uh oh!

Zoxc commented Mar 28, 2019

Uh oh!

bors commented Mar 28, 2019

Uh oh!

rust-highfive commented Mar 28, 2019

Uh oh!

Zoxc commented Mar 29, 2019

Uh oh!

rust-timer commented Mar 29, 2019

Uh oh!

bors commented Mar 29, 2019

Uh oh!

rust-timer commented Mar 29, 2019

Uh oh!

rust-highfive commented Mar 29, 2019

Uh oh!

michaelwoerister commented Apr 1, 2019

Uh oh!

Zoxc commented Apr 1, 2019

Uh oh!

michaelwoerister commented Apr 2, 2019

Uh oh!

bors commented Apr 4, 2019

Uh oh!

Zoxc commented Apr 14, 2019

Uh oh!

michaelwoerister commented Apr 24, 2019

Uh oh!

Dylan-DPC-zz commented May 13, 2019

Uh oh!

michaelwoerister commented May 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants