Closed
Conversation
Fallback to `static_impl_trait` for nice error message by peeking at the return type and the lifetime type. Point at the return type instead of the return expr/stmt in NLL mode.
…, r=pnkfelix Suggest using anonymous lifetime in `impl Trait` return Fix rust-lang#48467. r? @nikomatsakis
…er_error_msg, r=pnkfelix fixes rust-lang#56766 fixes rust-lang#56766
Fixed URL in cargotest::TEST_REPOS
…excrichton Print the appveyor agent version at the start of the build [AppVeyor support asked for this.](https://help.appveyor.com/discussions/problems/19657-successful-builds-failing-with-code-259#comment_47132359) r? @alexcrichton
Fix small typo This PR fixes a small typo in `eq()` comments.
Contributor
Author
|
@bors r+ p=5 |
Collaborator
|
📌 Commit ab19e15 has been approved by |
Collaborator
|
⌛ Testing commit ab19e15 with merge af188067b15be58ad36015a884acc8385292c8a9... |
Collaborator
|
💔 Test failed - checks-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
|
@bors retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl Traitreturn #58919 (Suggest using anonymous lifetime inimpl Traitreturn)Failed merges:
r? @ghost