Closed
Conversation
The tracking issue rust-lang#50264 still has unresolved question for the corresponding `Result` methods.
This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
Still debating if this is the right approach
Co-Authored-By: Pietro Albini <pietro@pietroalbini.org>
visit_statement default definition does just this, there's no need to redefine it.
It has been fully disabled by default since rust-lang#54639.
This commit makes the `improper_ctype` lint trigger for non-exhaustive types when those types aren't defined in the current crate. Signed-off-by: David Wood <david@davidtw.co>
Stabilize `Option::as_deref` and `Option::as_deref_mut` The tracking issue rust-lang#50264 still has unresolved question for the corresponding `Result` methods.
…r=sfackler std: Reduce checks for `feature = "backtrace"` This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
Do not ICE when dereferencing non-Copy raw pointer CC rust-lang#52262. Confirmed to remove the unnecessary ICE, but without a repro case.
…by-anyone, r=nikomatsakis permit asyncawait-ondeck to be added by anyone Still debating if this is the right approach but r? @pietroalbini to check the format
…olymorphic_promoted_mir, r=oli-obk [const-prop] Fix ICE when trying to eval polymorphic promoted MIR Fixes rust-lang#64908 r? @oli-obk cc @nikomatsakis @pnkfelix
…-err-codes, r=varkor Sort error codes in librustc_passes This is just a little cleanup.
Replace GeneratorSubsts with SubstsRef Closes rust-lang#42340 r? @nikomatsakis
…r=Centril Allow unused attributes to avoid incremental bug cc rust-lang#65023 This isn't labeled as fixing that issue because it's not really a fix, just a patch.
Fix lonely backtick That backtick won't be sad anymore
…i-obk Remove unneeded visit_statement definition r? @oli-obk
…=rkruppe Update the documented default of -Z mutable-noalias It has been fully disabled by default since rust-lang#54639.
…ebank Account for macro invocation in `let mut $pat` diagnostic. Fixes rust-lang#65122. r? @estebank
Replace some instances of `as *[const | mut] _` with `.cast()` While in `codegen_llvm`, noticed some places for the recent `pointer::cast` method.
Fix typo on `now()` comments Fix typo, update words, and remove some redundant word. Also rustfmt on the rest of the file (hope this is okay :) revival of rust-lang#61433 r? @kennytm
… r=petrochenkov lint: extern non-exhaustive types are improper This PR makes the `improper_ctype` lint trigger for non-exhaustive types when those types aren't defined in the current crate, as per [this comment](rust-lang#44109 (comment)). cc @Centril
Member
Author
|
@bors r+ p=15 rollup=never |
Collaborator
|
📌 Commit 4fd8f37 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 4fd8f37 with merge 2d4822bdb9bd2379956d7ed331545784850957bf... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
Author
|
Looks like this succeeded, but timed out... @bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 4fd8f37 with merge 4566201c8294fd960504e7725afca5392ef7bcea... |
tmandry
added
the
A-spurious
Member
|
@tmandry FWIW, it seems the last several bors builds have all failed on asmjs timeouts. The last commit to land was emscripten related, so I think this is not a coincidence. |
Contributor
|
Would it be possible to increase the Bors timeout, given that this didn't actually hit any Azure timeouts? |
Member
Author
|
@bors r- |
bors
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Option::as_derefandOption::as_deref_mut#64708 (StabilizeOption::as_derefandOption::as_deref_mut)feature = "backtrace"#64765 (std: Reduce checks forfeature = "backtrace")let mut $patdiagnostic. #65123 (Account for macro invocation inlet mut $patdiagnostic.)as *[const | mut] _with.cast()#65124 (Replace some instances ofas *[const | mut] _with.cast())now()comments #65126 (Fix typo onnow()comments)Failed merges:
r? @ghost