Add PartialEq and PartialOrd for NonZeroInt to Int#70855
Closed
Lucretiel wants to merge 5 commits intorust-lang:masterfrom
Closed
Add PartialEq and PartialOrd for NonZeroInt to Int#70855Lucretiel wants to merge 5 commits intorust-lang:masterfrom
Lucretiel wants to merge 5 commits intorust-lang:masterfrom
Conversation
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
r? @KodrAus |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
|
These appear to be |
|
@Lucretiel did you run tidy ? |
Contributor
Author
|
Huh, I thought I ran rustfmt already. Published fixes. |
JohnTitor
added
the
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
|
r? @Amanieu |
Amanieu
reviewed
Apr 21, 2020
Member
Amanieu
left a comment
Amanieu
left a comment
There was a problem hiding this comment.
I'd also like to implement PartialEq for Int, but I wasn't sure what the implications were for implementing traits on primitive types like that.
I think this is fine.
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "nonzero_cmp_to_int", issue = "70855")] |
Member
There was a problem hiding this comment.
Trait implementations are always insta-stable. Use #[stable] instead.
Contributor
Author
There was a problem hiding this comment.
I updated to stable; it wants a "since" attribute
Collaborator
|
☔ The latest upstream changes (presumably #71556) made this pull request unmergeable. Please resolve the merge conflicts. |
joelpalmer
added
S-waiting-on-author
Member
|
Ping from triage: |
joelpalmer
added
S-inactive
|
Ping from Triage: Closing due to inactivity. Please re-open with any updates and conflicts resolved. Thank you for the PR. @Lucretiel |
Contributor
Author
|
Updated this branch! Conflicts resolved, tidy passing. Not sure how to account for making the trait insta-stable, I'll need some guidance on that. |
Member
|
You'll need to reopen the PR or open a new one. For the stability attribute just mark it as since 1.45.0. We'll need to run this through FCP for stabilization. |
Contributor
Author
|
I don't have a "reopen" button available to me; maybe @joelpalmer? |
Contributor
Author
|
Opened #72405 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propose adding
PartialEqandPartialOrdto theNonZeroInttypes to compare to their inner types. Seems like a pretty obvious change, but I'm obviously open to any feedback or suggestions.I'd also like to implement
PartialEq<NonZeroInt> for Int, but I wasn't sure what the implications were for implementing traits on primitive types like that.