Conversation
Contributor
Author
|
The cargo update in #71138 will supersede the need for one here, assuming it lands first. |
Co-Authored-By: Jason King <jason.brian.king@gmail.com> Co-Authored-By: Joshua M. Clulow <jmc@oxide.computer>
The ioctl(FIONBIO) method of setting a file descriptor to be non-blocking does not notify the underlying resource in the same way that fcntl(F_SETFL, O_NONBLOCK) does on illumos and Solaris.
pfmooney
force-pushed
the
illumos-triple
branch
from
4a6b607 to
dda5c97
Compare
Contributor
Author
|
Rebased on top of #71138 and updated to include |
Contributor
Author
|
cc: @nagisa |
Member
|
@bors r+ |
Collaborator
|
📌 Commit dda5c97 has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 15, 2020
Add illumos triple This fixes rust-lang#55553 and adds support for `illumos` as a `target_os` on `x86_64`. In addition to the compile spec and libstd additions, several library dependencies have been bumped in order to permit working builds of cargo and rustup for the new target. Work originally started by @jasonbking, with subsequent additions by @pfmooney and @jclulow.
This was referenced Apr 15, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#69903 (Do not ICE in the face of invalid enum discriminant) - rust-lang#70354 (Update RELEASES.md for 1.43.0) - rust-lang#70774 (End cleanup on rustdoc-js tools) - rust-lang#70990 (Improve rustdoc source code a bit) - rust-lang#71145 (Add illumos triple) - rust-lang#71166 (Clean up E0518 explanation) Failed merges: r? @ghost
This was referenced Apr 16, 2020
RalfJung
reviewed
Apr 16, 2020
| pub fn set_nonblocking(&self, nonblocking: bool) -> io::Result<()> { | ||
| // FIONBIO is inadequate for sockets on illumos/Solaris, so use the | ||
| // fcntl(F_[GS]ETFL)-based method provided by FileDesc instead. | ||
| self.0.set_nonblocking(nonblocking) |
Member
There was a problem hiding this comment.
This generally seems to be the portable and recommended method on POSIX. Makes me wonder why we do something else on Linux and other Unices.
ehuss
added a commit
to ehuss/rust-forge
that referenced
this pull request
May 15, 2020
- aarch64-unknown-none: rust-lang/rust#68334 - aarch64-unknown-none-softfloat: rust-lang/rust#64589 - armv7-unknown-linux-gnueabi: rust-lang/rust#63107 - armv7-unknown-linux-musleabi: rust-lang/rust#63107 - aarch64-apple-tvos: rust-lang/rust#68191 - armv7a-none-eabihf: rust-lang/rust#68253 - i686-unknown-uefi: rust-lang/rust#64334 - thumbv7neon-unknown-linux-musleabihf: rust-lang/rust#66103 - x86_64-apple-ios-macabi: rust-lang/rust#63467 - x86_64-apple-tvos: rust-lang/rust#68191 - x86_64-linux-kernel: rust-lang/rust#64051 - x86_64-unknown-hermit-kernel: rust-lang/rust#66713 - x86_64-unknown-illumos: rust-lang/rust#71145 Moved to tier 2: - aarch64-unknown-none: rust-lang/rust#68334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #55553 and adds support for
illumosas atarget_osonx86_64. In addition to the compile spec and libstd additions, several library dependencies have been bumped in order to permit working builds of cargo and rustup for the new target.Work originally started by @jasonbking, with subsequent additions by @pfmooney and @jclulow.